You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Timothee Maret (JIRA)" <ji...@apache.org> on 2019/05/08 12:51:00 UTC
[jira] [Commented] (SLING-8400) Simplify creation of
KafkaMessageInfo
[ https://issues.apache.org/jira/browse/SLING-8400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16835564#comment-16835564 ]
Timothee Maret commented on SLING-8400:
---------------------------------------
Thanks [~chris@die-schneider.net]! I squashed and merged your [PR|https://github.com/apache/sling-org-apache-sling-distribution-journal-kafka/pull/2].
> Simplify creation of KafkaMessageInfo
> -------------------------------------
>
> Key: SLING-8400
> URL: https://issues.apache.org/jira/browse/SLING-8400
> Project: Sling
> Issue Type: Improvement
> Components: Content Distribution
> Affects Versions: Content Distribution Journal Kafka 0.1.0
> Reporter: Christian Schneider
> Priority: Major
> Fix For: Content Distribution Journal Kafka 0.1.2
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The constructor of KafkaMessageInfo currently takes all individual attributes as parameters.
> We could simplifly this by just taking ConsumerRecord<String, ?> record. This way it works kind of like a converter.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)