You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2018/02/06 01:05:56 UTC

[GitHub] Beutlin opened a new pull request #230: CB-13849: (android) getDirectory("") returns current path instead of / path

Beutlin opened a new pull request #230: CB-13849: (android) getDirectory("") returns current path instead of / path
URL: https://github.com/apache/cordova-plugin-file/pull/230
 
 
   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist
   is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   - Android
   
   
   ### What does this PR do?
   Currently the comman getDirectory('') with an empty parameter returns always the root path. It does not matter on which path this command is executed. This is an unexpected behaviour and might cause security issues.
   With this patch the path of the current directory is returned, like in other implementations (i.e. browser).
   
   ### What testing has been done on this change?
   It has been tested on an emulator. Furthermore the sourcecode has been evaluated and there is no negative issues with it. 
   
   ### Checklist
   - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
   - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
   - [ ] Added automated test coverage as appropriate for this change.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org