You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "cxzl25 (via GitHub)" <gi...@apache.org> on 2023/09/11 04:09:52 UTC
[GitHub] [incubator-celeborn] cxzl25 opened a new pull request, #1895: [CELEBORN-900][FOLLOWUP] Disable jemalloc in non-docker environment
cxzl25 opened a new pull request, #1895:
URL: https://github.com/apache/incubator-celeborn/pull/1895
### What changes were proposed in this pull request?
1. Provide `CELEBORN_PREFER_JEMALLOC` configuration to determine whether to enable jemalloc
2. Provide `CELEBORN_JEMALLOC_PATH` to configure the jemalloc path, for example, Centos is `/usr/lib64/libjemalloc.so`
3. Enable jemalloc by default in the docker environment
### Why are the changes needed?
Prevent unnecessary WARNING.
https://github.com/apache/incubator-celeborn/pull/1824#discussion_r1319909938
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
local test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on a diff in pull request #1895: [CELEBORN-900][FOLLOWUP] Disable jemalloc in non-docker environment
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #1895:
URL: https://github.com/apache/incubator-celeborn/pull/1895#discussion_r1320998578
##########
conf/celeborn-env.sh.template:
##########
@@ -23,6 +23,9 @@
# - CELEBORN_WORKER_JAVA_OPTS
# - CELEBORN_PID_DIR
# - CELEBORN_LOG_DIR
+# - CELEBORN_PREFER_JEMALLOC, to enable jemalloc memory allocator
+# - CELEBORN_JEMALLOC_PATH, to set jemalloc library path
+
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture closed pull request #1895: [CELEBORN-900][FOLLOWUP] Disable jemalloc in non-docker environment
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture closed pull request #1895: [CELEBORN-900][FOLLOWUP] Disable jemalloc in non-docker environment
URL: https://github.com/apache/incubator-celeborn/pull/1895
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1895: [CELEBORN-900][FOLLOWUP] Disable jemalloc in non-docker environment
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1895:
URL: https://github.com/apache/incubator-celeborn/pull/1895#issuecomment-1713139078
## [Codecov](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1895?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#1895](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1895?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (e112000) into [main](https://app.codecov.io/gh/apache/incubator-celeborn/commit/cb8ace406bd6df21dd8c16a4afcf8e0377e456ea?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (cb8ace4) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #1895 +/- ##
=======================================
Coverage 46.52% 46.52%
=======================================
Files 164 164
Lines 10226 10226
Branches 937 937
=======================================
Hits 4757 4757
Misses 5156 5156
Partials 313 313
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on a diff in pull request #1895: [CELEBORN-900][FOLLOWUP] Disable jemalloc in non-docker environment
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #1895:
URL: https://github.com/apache/incubator-celeborn/pull/1895#discussion_r1320980105
##########
conf/celeborn-env.sh.template:
##########
@@ -32,4 +32,4 @@
# CELEBORN_MASTER_JAVA_OPTS="-XX:-PrintGC -XX:+PrintGCDetails -XX:+PrintGCTimeStamps -XX:+PrintGCDateStamps -Xloggc:gc-master.out -Dio.netty.leakDetectionLevel=advanced"
# CELEBORN_PID_DIR="$CELEBORN_HOME/pids"
# CELEBORN_LOG_DIR="$CELEBORN_HOME/logs"
-# DISABLE_JEMALLOC="false"
+# CELEBORN_PREFER_JEMALLOC="true"
Review Comment:
can we list `CELEBORN_JEMALLOC_PATH` in the example too? additionally, they should be listed at L26 too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on a diff in pull request #1895: [CELEBORN-900][FOLLOWUP] Disable jemalloc in non-docker environment
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #1895:
URL: https://github.com/apache/incubator-celeborn/pull/1895#discussion_r1320981244
##########
docker/Dockerfile:
##########
@@ -22,6 +22,7 @@ ARG celeborn_uid=10006
ARG celeborn_gid=10006
ENV CELEBORN_HOME=/opt/celeborn
+ENV CELEBORN_PREFER_JEMALLOC=true
ENV PATH=/opt/java/openjdk/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/opt/busybox:${CELEBORN_HOME}/sbin:${CELEBORN_HOME}/bin
Review Comment:
```suggestion
ENV PATH=${PATH}:/opt/busybox:${CELEBORN_HOME}/sbin:${CELEBORN_HOME}/bin
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org