[GitHub] spark pull request #17064: [SPARK-19736][SQL] refreshByPath should clear all...

[viirya <gi...@git.apache.org>]

Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17064#discussion_r103594748
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala ---
    @@ -634,4 +634,28 @@ class CachedTableSuite extends QueryTest with SQLTestUtils with SharedSQLContext
           assert(getNumInMemoryRelations(cachedPlan2) == 4)
         }
       }
    +
    +  test("refreshByPath should refresh all cached plans with the specified path") {
    +    def f(path: String, spark: SparkSession, dataCount: Int): DataFrame = {
    +      spark.catalog.refreshByPath(path)
    +      val data = spark.read.parquet(path)
    +      assert(data.count == dataCount)
    +      val df = data.filter("id > 10")
    +      df.cache
    +      assert(df.count == dataCount - 11)
    +      val df1 = df.filter("id > 11")
    +      df1.cache
    +      assert(df1.count == dataCount - 12)
    +      df1
    +    }
    +
    +    withTempDir { dir =>
    +      val path = dir.getPath()
    +      spark.range(100).write.mode("overwrite").parquet(path)
    +      assert(f(path, spark, 100).count == 88)
    +
    +      spark.range(1000).write.mode("overwrite").parquet(path)
    +      assert(f(path, spark, 1000).count == 988)
    --- End diff --
    
    Ok. Looks simpler and more explicit.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org