You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by EronWright <gi...@git.apache.org> on 2017/04/26 22:54:32 UTC
[GitHub] flink pull request #3784: FLINK-6391
GitHub user EronWright opened a pull request:
https://github.com/apache/flink/pull/3784
FLINK-6391
FLINK-6391
Improve change-scala-version.sh to correctly deal with references to flink-gelly-examples.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/EronWright/flink FLINK-6391
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3784.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3784
----
commit 0985697f071133abf0a512a4a79834a1ccd19cde
Author: Wright, Eron <er...@emc.com>
Date: 2017-04-26T22:48:57Z
FLINK-6391
Improve change-scala-version.sh to correctly deal with references to flink-gelly-examples.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3784: FLINK-6391
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3784
Any ideas why we can't just reference `scala.binary.version` in the Maven configurations rather than specifying `2.10` and modifying this in the change script? I don't see why `change-scala-version.sh` is any more complicated than `change-version.sh`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3784: FLINK-6360
Posted by EronWright <gi...@git.apache.org>.
Github user EronWright commented on the issue:
https://github.com/apache/flink/pull/3784
Fixed by 03afbca5d047988e7fd8aff5d8b83ddee19570c9
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3784: FLINK-6391
Posted by EronWright <gi...@git.apache.org>.
Github user EronWright commented on the issue:
https://github.com/apache/flink/pull/3784
@greghogan that might be a good idea but I don't know much about it. I'm merely focused on fixing the build break.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3784: FLINK-6360
Posted by EronWright <gi...@git.apache.org>.
Github user EronWright closed the pull request at:
https://github.com/apache/flink/pull/3784
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---