You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2020/11/05 22:13:05 UTC

[Bug 64877] New: New implementation of JDBC Based Store with better performances

https://bz.apache.org/bugzilla/show_bug.cgi?id=64877

            Bug ID: 64877
           Summary: New implementation of JDBC Based Store with better
                    performances
           Product: Tomcat 9
           Version: 9.0.39
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: Catalina
          Assignee: dev@tomcat.apache.org
          Reporter: p.mouawad@ubik-ingenierie.com
  Target Milestone: -----

Hello,
First thanks for your great product I've been using for years.

Recently, I worked on a project that uses JDBCStore.
I had to run performance tests on it.
Those tests revealed a high contention point in this component due to the
granularity of synchronization. 
The impact was that 1 thread could block hundreds of others. 
I would have been happy to provide stacktraces but I cannot due to NDA
constraints.

So I implemented (based on existing one) a new one with following differences:

- I kept only the dataSourceName based configuration
- I removed stateful instance variables in order to be able to lift
synchronization

This new implementation improved drastically performances.

I'll propose a PR for this.
I am aware that there is duplication with JDBCStore that could be improved but
it's a first shot and I lack of time unfortunately.

I hope you can take into account this contribution.
Regards
Philippe M.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 64877] New implementation of JDBC Based Store with better performances

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=64877

Remy Maucherat <re...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Remy Maucherat <re...@apache.org> ---
Ok, this looked fine to me after some adjustments.
The functionality will be in 10.0.0-M10, 9.0.40 and 8.5.60.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 64877] New implementation of JDBC Based Store with better performances

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=64877

Philippe Mouawad <p....@ubik-ingenierie.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |PatchAvailable
                 CC|                            |p.mouawad@ubik-ingenierie.c
                   |                            |om

--- Comment #1 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
PR:

https://github.com/apache/tomcat/pull/376

Regards

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org