[GitHub] spark pull request: [SPARK-11507] [MLlib] add compact in Matrices ...

[jkbradley <gi...@git.apache.org>]

Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9520#discussion_r48586886
  
    --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Matrices.scala ---
    @@ -879,6 +879,7 @@ object Matrices {
           case dm: BDM[Double] =>
             new DenseMatrix(dm.rows, dm.cols, dm.data, dm.isTranspose)
           case sm: BSM[Double] =>
    +        sm.compact()
    --- End diff --
    
    We probably should not mutate the argument, unless we check all use cases and make sure this is OK.  I don't like the idea of copying unnecessarily, but it might be needed.
    
    Alternatively, can we just send a fix to Breeze since the error is there?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org