You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/10 23:21:31 UTC
[GitHub] [spark] karuppayya commented on pull request #28715: [SPARK-31897][SQL] Enable codegen for GenerateExec
karuppayya commented on pull request #28715:
URL: https://github.com/apache/spark/pull/28715#issuecomment-796278694
Added the benchmark using the benchmark infra. It tests with codegen on and off .
Since there is no way to disable codegen only for GenerateExec, disabling codegen will disable code generation for all operators. In the added benchmark, Project operator will be affected, but this should not cause a huge deviation in the benchmark. Please let me know otherwise.
Benchmark results:
```
[info] GenerateExec Benchmark: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative
[info] ------------------------------------------------------------------------------------------------------------------------
[info] GenerateExec Benchmark wholestage off 85625 87134 2134 1.2 856.3 1.0X
[info] GenerateExec Benchmark wholestage on 43547 44003 377 2.3 435.5 2.0X
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org