You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "PsiACE (via GitHub)" <gi...@apache.org> on 2023/04/28 12:37:31 UTC

[GitHub] [incubator-opendal] PsiACE opened a new pull request, #2159: docs(website): try to add opendal logo

PsiACE opened a new pull request, #2159:
URL: https://github.com/apache/incubator-opendal/pull/2159

   ![img](https://user-images.githubusercontent.com/36896360/235148638-fb37abcb-b980-48fa-8678-1672c3a524d4.png)
   
   Just added the logo to the navbar, need some advice.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-opendal] Xuanwo commented on a diff in pull request #2159: docs(website): try to add opendal logo

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #2159:
URL: https://github.com/apache/incubator-opendal/pull/2159#discussion_r1180415862


##########
README.md:
##########


Review Comment:
   ![image](https://user-images.githubusercontent.com/5351546/235162285-b3ab8fbe-5f03-4ed7-91a8-578f529977c4.png)
   
   
   emmmmmm



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-opendal] Xuanwo commented on a diff in pull request #2159: docs(website): try to add opendal logo

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #2159:
URL: https://github.com/apache/incubator-opendal/pull/2159#discussion_r1181017289


##########
README.md:
##########


Review Comment:
   Thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-opendal] PsiACE commented on a diff in pull request #2159: docs(website): try to add opendal logo

Posted by "PsiACE (via GitHub)" <gi...@apache.org>.
PsiACE commented on code in PR #2159:
URL: https://github.com/apache/incubator-opendal/pull/2159#discussion_r1180412604


##########
website/docusaurus.config.js:
##########


Review Comment:
   please check [2f90191](https://github.com/apache/incubator-opendal/pull/2159/commits/2f90191f87f620320f7a6e5c81c8b20d1e697bb7). Not quite sure what size to resize to.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-opendal] suyanhanx commented on a diff in pull request #2159: docs(website): try to add opendal logo

Posted by "suyanhanx (via GitHub)" <gi...@apache.org>.
suyanhanx commented on code in PR #2159:
URL: https://github.com/apache/incubator-opendal/pull/2159#discussion_r1180418472


##########
README.md:
##########


Review Comment:
   You may use a `<img>` to limit size, like `<img src="IMAGE_URL_HERE" width="300" height="300">`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-opendal] suyanhanx commented on a diff in pull request #2159: docs(website): try to add opendal logo

Posted by "suyanhanx (via GitHub)" <gi...@apache.org>.
suyanhanx commented on code in PR #2159:
URL: https://github.com/apache/incubator-opendal/pull/2159#discussion_r1180359411


##########
website/docusaurus.config.js:
##########
@@ -84,7 +84,14 @@ const config = {
         disableSwitch: true
       },
       navbar: {
-        title: 'OpenDAL (incubating)',
+        logo: {
+          alt: 'Apache OpenDAL Logo',

Review Comment:
   ```suggestion
             alt: 'Apache OpenDAL(incubating)',
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-opendal] PsiACE commented on a diff in pull request #2159: docs(website): try to add opendal logo

Posted by "PsiACE (via GitHub)" <gi...@apache.org>.
PsiACE commented on code in PR #2159:
URL: https://github.com/apache/incubator-opendal/pull/2159#discussion_r1181011532


##########
README.md:
##########


Review Comment:
   ![img](https://user-images.githubusercontent.com/36896360/235290530-3ca16bf9-4197-42b0-ac51-6cea3e1624db.png)
   
   width 300px
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-opendal] Xuanwo commented on a diff in pull request #2159: docs(website): try to add opendal logo

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #2159:
URL: https://github.com/apache/incubator-opendal/pull/2159#discussion_r1180391964


##########
website/docusaurus.config.js:
##########


Review Comment:
   Please also update our README.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-opendal] Xuanwo merged pull request #2159: docs(website): try to add opendal logo

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #2159:
URL: https://github.com/apache/incubator-opendal/pull/2159


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org