You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/08 13:39:53 UTC

[GitHub] [arrow] lidavidm commented on a diff in pull request #12836: ARROW-16152: [C++] Typo that causes segfault with unknown functions in Substrait

lidavidm commented on code in PR #12836:
URL: https://github.com/apache/arrow/pull/12836#discussion_r846121285


##########
cpp/src/arrow/engine/substrait/serde_test.cc:
##########
@@ -724,5 +724,31 @@ TEST(Substrait, ExtensionSetFromPlan) {
   EXPECT_EQ(decoded_add_func.name, "add");
 }
 
+TEST(Substrait, ExtensionSetFromPlanMissinFunc) {

Review Comment:
   ```suggestion
   TEST(Substrait, ExtensionSetFromPlanMissingFunc) {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org