[GitHub] [incubator-uniffle] wangao1236 commented on a diff in pull request #523: [ISSUE-522] [operator] pass RSS_IP to coordinator container env

["wangao1236 (via GitHub)" <gi...@apache.org>]

wangao1236 commented on code in PR #523:
URL: https://github.com/apache/incubator-uniffle/pull/523#discussion_r1091504460


##########
deploy/kubernetes/operator/pkg/controller/sync/coordinator/coordinator.go:
##########
@@ -287,6 +287,24 @@ func generateMainContainerENV(rss *unifflev1alpha1.RemoteShuffleService) []corev
 			Name:  controllerconstants.ServiceNameEnv,
 			Value: controllerconstants.CoordinatorServiceName,
 		},
+		{
+			Name: controllerconstants.NodeNameEnv,
+			ValueFrom: &corev1.EnvVarSource{
+				FieldRef: &corev1.ObjectFieldSelector{
+					APIVersion: "v1",
+					FieldPath:  "spec.nodeName",
+				},
+			},
+		},
+		{
+			Name: controllerconstants.RssIPEnv,

Review Comment:
   What purpose does the coordinator read the RSS_IP environment variable for?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org