You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/19 05:30:46 UTC
[GitHub] [pulsar] boatrainlsz opened a new pull request, #16131: [fix][python client] Fixed schema validate_type method throw a wrong exception
boatrainlsz opened a new pull request, #16131:
URL: https://github.com/apache/pulsar/pull/16131
Fixes #16056
### Motivation
The validate_type method in definition.py was intended to throw a TypeError when type of elements in array is incorrect, but the `self.array_type.python_type()` would return int type, which can not be concatenated with string. This would cause a confusing error output
### Modifications
Explicitly construct a string with python_type info
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
This change added tests and can be verified as follows:
- Added a unit test method named test_schema_array_wrong_type, see pulsar-client-cpp/python/schema_test.py
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API: (yes / **no**)
- The schema: (yes / **no** / don't know)
- The default values of configurations: (yes / **no**)
- The wire protocol: (yes / **no**)
- The rest endpoints: (yes / **no**)
- The admin cli options: (yes / **no**)
- Anything that affects deployment: (yes / **no** / don't know)
### Documentation
Check the box below or label this PR directly.
Need to update docs?
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [ x] `doc-not-needed`
(Please explain why)
- [ ] `doc`
(Your PR contains doc changes)
- [ ] `doc-complete`
(Docs have been already added)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] boatrainlsz commented on pull request #16131: [fix][python client] Fixed schema validate_type method throw a wrong exception
Posted by GitBox <gi...@apache.org>.
boatrainlsz commented on PR #16131:
URL: https://github.com/apache/pulsar/pull/16131#issuecomment-1159686189
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] boatrainlsz commented on a diff in pull request #16131: [fix][python client] Fixed schema validate_type method throw a wrong exception
Posted by GitBox <gi...@apache.org>.
boatrainlsz commented on code in PR #16131:
URL: https://github.com/apache/pulsar/pull/16131#discussion_r902522201
##########
pulsar-client-cpp/python/pulsar/schema/definition.py:
##########
@@ -444,8 +444,8 @@ def validate_type(self, name, val):
for x in val:
if type(x) != self.array_type.python_type():
- raise TypeError('Array field ' + name + ' items should all be of type '
- + self.array_type.python_type())
+ raise TypeError('Array field ' + name + ' items should all be of type ' +
+ str(self.array_type.type()))
Review Comment:
> The `type()` method already returns a `str`, there is no need to cast it to `str`.
Thanks for your comment, I just removed unnecessary casting, please kindly review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower merged pull request #16131: [fix][python client] Fixed schema validate_type method throw a wrong exception
Posted by GitBox <gi...@apache.org>.
BewareMyPower merged PR #16131:
URL: https://github.com/apache/pulsar/pull/16131
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on a diff in pull request #16131: [fix][python client] Fixed schema validate_type method throw a wrong exception
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on code in PR #16131:
URL: https://github.com/apache/pulsar/pull/16131#discussion_r901774301
##########
pulsar-client-cpp/python/pulsar/schema/definition.py:
##########
@@ -444,8 +444,8 @@ def validate_type(self, name, val):
for x in val:
if type(x) != self.array_type.python_type():
- raise TypeError('Array field ' + name + ' items should all be of type '
- + self.array_type.python_type())
+ raise TypeError('Array field ' + name + ' items should all be of type ' +
+ str(self.array_type.type()))
Review Comment:
```suggestion
self.array_type.type())
```
The `type()` method already returns a `str`, there is no need to cast it to `str`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] boatrainlsz commented on pull request #16131: [fix][python client] Fixed schema validate_type method throw a wrong exception
Posted by GitBox <gi...@apache.org>.
boatrainlsz commented on PR #16131:
URL: https://github.com/apache/pulsar/pull/16131#issuecomment-1159677069
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org