You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "wolf427 (GitHub)" <gi...@apache.org> on 2018/11/20 03:09:34 UTC

[GitHub] [incubator-dubbo-ops] wolf427 opened pull request #188: 代码重构，修复bug，加注释

1.把搜索功能从controller中抽出到service里,替换掉里面的魔法值
2.之前的模糊搜索，因为将filter强制转换成小写了，所以*ExampleService这样的搜索条件搜不到com.xxx.ExampleService这样的service, 通过修改Pattern匹配方式为不区分大小写，修复了该bug
3.主要为主页搜索相关的方法加了一些注释

[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/188 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-ops] codecov-io commented on issue #188: 代码重构，修复bug，加注释

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/188?src=pr&el=h1) Report
> Merging [#188](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/188?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/incubator-dubbo-ops/commit/47bffeb9566fa93af4c165e62398eb56a782e9ef?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `0%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/188/graphs/tree.svg?width=650&token=fYsc8RuDGB&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/188?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##             develop   #188      +/-   ##
===========================================
- Coverage        0.4%   0.4%   -0.01%     
  Complexity         7      7              
===========================================
  Files            102    102              
  Lines           4658   4661       +3     
  Branches         798    798              
===========================================
  Hits              19     19              
- Misses          4638   4641       +3     
  Partials           1      1
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/188?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ache/dubbo/admin/governance/util/WebConstants.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/188/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vZ292ZXJuYW5jZS91dGlsL1dlYkNvbnN0YW50cy5qYXZh) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ache/dubbo/admin/controller/ServiceController.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/188/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vY29udHJvbGxlci9TZXJ2aWNlQ29udHJvbGxlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...n/governance/service/impl/ProviderServiceImpl.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/188/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vZ292ZXJuYW5jZS9zZXJ2aWNlL2ltcGwvUHJvdmlkZXJTZXJ2aWNlSW1wbC5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/188?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/188?src=pr&el=footer). Last update [47bffeb...524c341](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/188?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/188 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-ops] codecov-io commented on issue #188: 代码重构，修复bug，加注释

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/188?src=pr&el=h1) Report
> Merging [#188](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/188?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/incubator-dubbo-ops/commit/58811500bbf8cf1244618d097f04a6e2404a1ec2?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `0%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/188/graphs/tree.svg?width=650&token=fYsc8RuDGB&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/188?src=pr&el=tree)

```diff
@@             Coverage Diff              @@
##             develop    #188      +/-   ##
============================================
- Coverage       0.57%   0.57%   -0.01%     
  Complexity         7       7              
============================================
  Files             82      82              
  Lines           3280    3283       +3     
  Branches         521     521              
============================================
  Hits              19      19              
- Misses          3260    3263       +3     
  Partials           1       1
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/188?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../org/apache/dubbo/admin/common/util/Constants.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/188/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vY29tbW9uL3V0aWwvQ29uc3RhbnRzLmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../dubbo/admin/service/impl/ProviderServiceImpl.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/188/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vc2VydmljZS9pbXBsL1Byb3ZpZGVyU2VydmljZUltcGwuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ache/dubbo/admin/controller/ServiceController.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/188/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vY29udHJvbGxlci9TZXJ2aWNlQ29udHJvbGxlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/188?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/188?src=pr&el=footer). Last update [5881150...3fbf6be](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/188?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/188 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-ops] wolf427 commented on issue #188: 代码重构，修复bug，加注释

Posted by "wolf427 (GitHub)" <gi...@apache.org>.
COMPLETED

[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/188 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-ops] nzomkxia commented on issue #188: 代码重构，修复bug，加注释

Posted by "nzomkxia (GitHub)" <gi...@apache.org>.
sorry for the late reply, can you deal with the conflicting?

[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/188 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-ops] codecov-io commented on issue #188: 代码重构，修复bug，加注释

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/188?src=pr&el=h1) Report
> Merging [#188](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/188?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/incubator-dubbo-ops/commit/5e12d552ec4f0621a67d83ecb801149e6e6ce6fb?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `0%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/188/graphs/tree.svg?width=650&token=fYsc8RuDGB&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/188?src=pr&el=tree)

```diff
@@             Coverage Diff              @@
##             develop    #188      +/-   ##
============================================
- Coverage       1.51%   1.51%   -0.01%     
  Complexity        28      28              
============================================
  Files             82      82              
  Lines           3292    3295       +3     
  Branches         524     524              
============================================
  Hits              50      50              
- Misses          3241    3244       +3     
  Partials           1       1
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/188?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ache/dubbo/admin/controller/ServiceController.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/188/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vY29udHJvbGxlci9TZXJ2aWNlQ29udHJvbGxlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../dubbo/admin/service/impl/ProviderServiceImpl.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/188/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vc2VydmljZS9pbXBsL1Byb3ZpZGVyU2VydmljZUltcGwuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/188?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/188?src=pr&el=footer). Last update [5e12d55...50706ce](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/188?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/188 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-ops] codecov-io commented on issue #188: 代码重构，修复bug，加注释

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/188?src=pr&el=h1) Report
> Merging [#188](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/188?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/incubator-dubbo-ops/commit/5e12d552ec4f0621a67d83ecb801149e6e6ce6fb?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `0%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/188/graphs/tree.svg?width=650&token=fYsc8RuDGB&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/188?src=pr&el=tree)

```diff
@@             Coverage Diff              @@
##             develop    #188      +/-   ##
============================================
- Coverage       1.51%   1.51%   -0.01%     
  Complexity        28      28              
============================================
  Files             82      82              
  Lines           3292    3295       +3     
  Branches         524     524              
============================================
  Hits              50      50              
- Misses          3241    3244       +3     
  Partials           1       1
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/188?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ache/dubbo/admin/controller/ServiceController.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/188/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vY29udHJvbGxlci9TZXJ2aWNlQ29udHJvbGxlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../dubbo/admin/service/impl/ProviderServiceImpl.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/188/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vc2VydmljZS9pbXBsL1Byb3ZpZGVyU2VydmljZUltcGwuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/188?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/188?src=pr&el=footer). Last update [5e12d55...50706ce](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/188?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/188 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-ops] codecov-io commented on issue #188: 代码重构，修复bug，加注释

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/188?src=pr&el=h1) Report
> Merging [#188](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/188?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/incubator-dubbo-ops/commit/58811500bbf8cf1244618d097f04a6e2404a1ec2?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `0%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/188/graphs/tree.svg?width=650&token=fYsc8RuDGB&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/188?src=pr&el=tree)

```diff
@@             Coverage Diff              @@
##             develop    #188      +/-   ##
============================================
- Coverage       0.57%   0.57%   -0.01%     
  Complexity         7       7              
============================================
  Files             82      82              
  Lines           3280    3283       +3     
  Branches         521     521              
============================================
  Hits              19      19              
- Misses          3260    3263       +3     
  Partials           1       1
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/188?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../org/apache/dubbo/admin/common/util/Constants.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/188/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vY29tbW9uL3V0aWwvQ29uc3RhbnRzLmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../dubbo/admin/service/impl/ProviderServiceImpl.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/188/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vc2VydmljZS9pbXBsL1Byb3ZpZGVyU2VydmljZUltcGwuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ache/dubbo/admin/controller/ServiceController.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/188/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vY29udHJvbGxlci9TZXJ2aWNlQ29udHJvbGxlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/188?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/188?src=pr&el=footer). Last update [5881150...3fbf6be](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/188?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/188 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-ops] nzomkxia commented on issue #188: 代码重构，修复bug，加注释

Posted by "nzomkxia (GitHub)" <gi...@apache.org>.
Thanks， I'll merge it

[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/188 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-ops] nzomkxia closed pull request #188: 代码重构，修复bug，加注释

Posted by "nzomkxia (GitHub)" <gi...@apache.org>.
[ pull request closed by nzomkxia ]

[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/188 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org