You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/09/01 00:55:13 UTC

[GitHub] [rocketmq] Oliverwqcwrw commented on a diff in pull request #4957: [ISSUE #4945] Adjust the storedir format of test cases to the Windows platform

Oliverwqcwrw commented on code in PR #4957:
URL: https://github.com/apache/rocketmq/pull/4957#discussion_r960132420


##########
store/src/test/java/org/apache/rocketmq/store/ha/autoswitch/AutoSwitchHATest.java:
##########
@@ -72,9 +73,9 @@ public class AutoSwitchHATest {
     private String store2HaAddress;
 
     private BrokerStatsManager brokerStatsManager = new BrokerStatsManager("simpleTest", true);
-    private String tmpdir = System.getProperty("java.io.tmpdir");
-    private String storePathRootParentDir = (StringUtils.endsWith(tmpdir, File.separator) ? tmpdir : tmpdir + File.separator) + UUID.randomUUID();
-    private String storePathRootDir = storePathRootParentDir + File.separator + "store";
+

Review Comment:
   CI is not passed
   Tests in error: 
     AutoSwitchHATest.testTruncateEpochLogAndChangeMaster:380->checkMessage:193 ยป ConditionTimeout
   
   Tests run: 148, Failures: 0, Errors: 1, Skipped: 9



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org