You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Di Li <di...@ca.ibm.com> on 2017/12/05 16:04:31 UTC

Review Request 64344: AMBARI-22589 Ambari web UI stack version page is empty due to NPE when target stack does not contain all services from the current stack

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64344/
-----------------------------------------------------------

Review request for Ambari, Alexandr Antonenko and Sangeeta Ravindran.


Bugs: AMBARI-22589
    https://issues.apache.org/jira/browse/AMBARI-22589


Repository: ambari


Description
-------

Stack version page where it usually shows the current and target versions is empty when current stack has services that the to-be-upgraded-to stack does not have.
this is due to a null pointer error at the ambari web UI level.


Diffs
-----

  ambari-web/app/messages.js 851e331 
  ambari-web/app/views/main/admin/stack_upgrade/upgrade_version_column_view.js ae01feb 


Diff: https://reviews.apache.org/r/64344/diff/1/


Testing
-------

patch a trunk cluster to have it be able to install a cluster with IOP 4.2.5 stack. register HDP 2.6 stack where it doesn;t have solr. verify UI, with the patch, pops up an alert dialog and also be able to show the stacks registered instead of an empty page.


Thanks,

Di Li


Re: Review Request 64344: AMBARI-22589 Ambari web UI stack version page is empty due to NPE when target stack does not contain all services from the current stack

Posted by Sangeeta Ravindran <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64344/#review193007
-----------------------------------------------------------


Ship it!




Ship It!

- Sangeeta Ravindran


On Dec. 5, 2017, 6:28 p.m., Di Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64344/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2017, 6:28 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and Sangeeta Ravindran.
> 
> 
> Bugs: AMBARI-22589
>     https://issues.apache.org/jira/browse/AMBARI-22589
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Stack version page where it usually shows the current and target versions is empty when current stack has services that the to-be-upgraded-to stack does not have.
> this is due to a null pointer error at the ambari web UI level.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/views/main/admin/stack_upgrade/upgrade_version_column_view.js ae01feb 
> 
> 
> Diff: https://reviews.apache.org/r/64344/diff/2/
> 
> 
> Testing
> -------
> 
> patch a trunk cluster to have it be able to install a cluster with IOP 4.2.5 stack. register HDP 2.6 stack where it doesn;t have solr. verify UI, with the patch, pops up an alert dialog and also be able to show the stacks registered instead of an empty page.
> 
> 
> Thanks,
> 
> Di Li
> 
>


Re: Review Request 64344: AMBARI-22589 Ambari web UI stack version page is empty due to NPE when target stack does not contain all services from the current stack

Posted by Di Li <di...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64344/
-----------------------------------------------------------

(Updated Dec. 5, 2017, 6:28 p.m.)


Review request for Ambari, Alexandr Antonenko and Sangeeta Ravindran.


Bugs: AMBARI-22589
    https://issues.apache.org/jira/browse/AMBARI-22589


Repository: ambari


Description
-------

Stack version page where it usually shows the current and target versions is empty when current stack has services that the to-be-upgraded-to stack does not have.
this is due to a null pointer error at the ambari web UI level.


Diffs (updated)
-----

  ambari-web/app/views/main/admin/stack_upgrade/upgrade_version_column_view.js ae01feb 


Diff: https://reviews.apache.org/r/64344/diff/2/

Changes: https://reviews.apache.org/r/64344/diff/1-2/


Testing
-------

patch a trunk cluster to have it be able to install a cluster with IOP 4.2.5 stack. register HDP 2.6 stack where it doesn;t have solr. verify UI, with the patch, pops up an alert dialog and also be able to show the stacks registered instead of an empty page.


Thanks,

Di Li