You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/07/25 09:31:50 UTC
[GitHub] [doris] Kikyou1997 opened a new pull request, #11181: [Regression] Add tpch plan check
Kikyou1997 opened a new pull request, #11181:
URL: https://github.com/apache/doris/pull/11181
# Proposed changes
Issue Number: noissue
## Problem Summary:
Add plan check for tpch so that we can sense any changes to the final plan opportunely.
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Kikyou1997 commented on pull request #11181: [Regression] Add tpch plan check
Posted by GitBox <gi...@apache.org>.
Kikyou1997 commented on PR #11181:
URL: https://github.com/apache/doris/pull/11181#issuecomment-1194950893
@morrySnow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #11181: [Regression] Add tpch plan check
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #11181:
URL: https://github.com/apache/doris/pull/11181#issuecomment-1197796086
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow commented on a diff in pull request #11181: [Regression] Add tpch plan check
Posted by GitBox <gi...@apache.org>.
morrySnow commented on code in PR #11181:
URL: https://github.com/apache/doris/pull/11181#discussion_r932238919
##########
regression-test/suites/tpch_sf1/load.groovy:
##########
@@ -77,4 +77,5 @@ suite("load") {
def table = "revenue1"
sql new File("""${context.file.parent}/ddl/${table}_delete.sql""").text
sql new File("""${context.file.parent}/ddl/${table}.sql""").text
+ sleep(60000)
Review Comment:
we need a comment on it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow commented on pull request #11181: [Regression] Add tpch plan check
Posted by GitBox <gi...@apache.org>.
morrySnow commented on PR #11181:
URL: https://github.com/apache/doris/pull/11181#issuecomment-1195381987
please fix license
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman merged pull request #11181: [Regression](planner) Add tpch plan check
Posted by GitBox <gi...@apache.org>.
morningman merged PR #11181:
URL: https://github.com/apache/doris/pull/11181
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #11181: [Regression](planner) Add tpch plan check
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #11181:
URL: https://github.com/apache/doris/pull/11181#issuecomment-1198264349
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow commented on a diff in pull request #11181: [Regression] Add tpch plan check
Posted by GitBox <gi...@apache.org>.
morrySnow commented on code in PR #11181:
URL: https://github.com/apache/doris/pull/11181#discussion_r931754052
##########
regression-test/suites/tpch_sf1/script/README:
##########
@@ -0,0 +1,19 @@
+# Manual
+
Review Comment:
We need a more detailed README. And make this script a little more general for any other case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Kikyou1997 commented on pull request #11181: [Regression] Add tpch plan check
Posted by GitBox <gi...@apache.org>.
Kikyou1997 commented on PR #11181:
URL: https://github.com/apache/doris/pull/11181#issuecomment-1197733067
@dataroaring @sodamnsure help to review pls
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Kikyou1997 commented on pull request #11181: [Regression] Add tpch plan check
Posted by GitBox <gi...@apache.org>.
Kikyou1997 commented on PR #11181:
URL: https://github.com/apache/doris/pull/11181#issuecomment-1196222464
@morrySnow review please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org