[jira] [Commented] (THRIFT-4384) Using a concurrent client with cpp async is not safe.

["James E. King III (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-4384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753664#comment-16753664 ] 

James E. King III commented on THRIFT-4384:
-------------------------------------------

The patch as posted does not apply clean.  Non-trivial to fix it up, please submit a pull request.

> Using a concurrent client with cpp async is not safe.
> -----------------------------------------------------
>
>                 Key: THRIFT-4384
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4384
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Compiler, C++ - Library
>    Affects Versions: 0.10.0, 0.11.0, 0.12.0
>         Environment: Should affect all platforms but has been noticed first on Windows, x86_64.
>            Reporter: Michael Eiler
>            Priority: Critical
>              Labels: async
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> I'm using the generated *ServiceConcurrentClient classes. They should allow me to call multiple functions at the same time.
> The issue as that the ::apache::thrift::async::TConcurrentClientSyncInfo class is a member of the generated service. If I have a project with multiple services sharing the same connection (protocol) with each other, the services will not be mutually excluded from reading on the same socket. 
> I did a small test with patching the generated code and injecting the same instance of TConcurrentClientSyncInfo into all my services and everything was fine.
> Question: Do you need a small project to reproduce this or is it obvious enough? Just check out any generated code and you will see that the TConcurrentClientSyncInfo is not shared between different services.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)