You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Gaurav Nagar <gn...@hortonworks.com> on 2016/04/15 17:23:59 UTC

Review Request 46271: Migrate instance specific data from one version to another.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46271/
-----------------------------------------------------------

Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary.


Bugs: AMBARI-15919
    https://issues.apache.org/jira/browse/AMBARI-15919


Repository: ambari


Description
-------

Added ability to migrate data using rest API.
Added data-migrator-class, data-version tags in view.xml . View needs to implement ViewDataMigrator class that contains logic to migrate data from older version.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/api/services/ViewDataMigrationService.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/ViewInstanceService.java 1eea8db 
  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/PrivilegeDAO.java 772d538 
  ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceEntity.java 2555f93 
  ambari-server/src/main/java/org/apache/ambari/server/view/ViewDataMigrationContextImpl.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 7379f37 
  ambari-server/src/main/java/org/apache/ambari/server/view/configuration/ViewConfig.java 728f620 
  ambari-server/src/test/java/org/apache/ambari/server/api/services/ViewDataMigrationServiceTest.java PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/orm/entities/ViewInstanceEntityTest.java c8c15da 
  ambari-server/src/test/java/org/apache/ambari/server/view/ViewDataMigrationContextImplTest.java PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/view/configuration/ViewConfigTest.java 14e5d3c 
  ambari-views/examples/README.md 650f650 
  ambari-views/examples/calculator-view/pom.xml d5e0e8e 
  ambari-views/examples/cluster-view/pom.xml 99582a6 
  ambari-views/examples/favorite-view/pom.xml ba196f5 
  ambari-views/examples/hello-servlet-view/pom.xml ed6fc25 
  ambari-views/examples/hello-spring-view/pom.xml 3475ef4 
  ambari-views/examples/helloworld-view/pom.xml aa89778 
  ambari-views/examples/phone-list-upgrade-view/docs/index.md PRE-CREATION 
  ambari-views/examples/phone-list-upgrade-view/pom.xml PRE-CREATION 
  ambari-views/examples/phone-list-upgrade-view/src/main/java/org/apache/ambari/view/phonelist/DataMigrator.java PRE-CREATION 
  ambari-views/examples/phone-list-upgrade-view/src/main/java/org/apache/ambari/view/phonelist/PhoneListServlet.java PRE-CREATION 
  ambari-views/examples/phone-list-upgrade-view/src/main/java/org/apache/ambari/view/phonelist/PhoneUser.java PRE-CREATION 
  ambari-views/examples/phone-list-upgrade-view/src/main/resources/WEB-INF/web.xml PRE-CREATION 
  ambari-views/examples/phone-list-upgrade-view/src/main/resources/view.xml PRE-CREATION 
  ambari-views/examples/phone-list-view/pom.xml ead9095 
  ambari-views/examples/pom.xml de55ded 
  ambari-views/examples/property-validator-view/pom.xml 045a277 
  ambari-views/examples/property-view/pom.xml ad4630b 
  ambari-views/examples/restricted-view/pom.xml f7fa3d6 
  ambari-views/examples/simple-view/pom.xml 015f192 
  ambari-views/examples/weather-view/pom.xml a018258 
  ambari-views/src/main/java/org/apache/ambari/view/migration/EntityConverter.java PRE-CREATION 
  ambari-views/src/main/java/org/apache/ambari/view/migration/ViewDataMigrationContext.java PRE-CREATION 
  ambari-views/src/main/java/org/apache/ambari/view/migration/ViewDataMigrationException.java PRE-CREATION 
  ambari-views/src/main/java/org/apache/ambari/view/migration/ViewDataMigrator.java PRE-CREATION 
  ambari-views/src/main/java/org/apache/ambari/view/validation/Validator.java ee029a8 
  ambari-views/src/main/resources/view.xsd c3ad711 
  pom.xml f540099 

Diff: https://reviews.apache.org/r/46271/diff/


Testing
-------


Thanks,

Gaurav Nagar


Re: Review Request 46271: Migrate instance specific data from one version to another.

Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46271/
-----------------------------------------------------------

(Updated April 15, 2016, 3:24 p.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary.


Bugs: AMBARI-15919
    https://issues.apache.org/jira/browse/AMBARI-15919


Repository: ambari


Description
-------

Added ability to migrate data using rest API.
Added data-migrator-class, data-version tags in view.xml . View needs to implement ViewDataMigrator class that contains logic to migrate data from older version.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/api/services/ViewDataMigrationService.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/ViewInstanceService.java 1eea8db 
  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/PrivilegeDAO.java 772d538 
  ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceEntity.java 2555f93 
  ambari-server/src/main/java/org/apache/ambari/server/view/ViewDataMigrationContextImpl.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 7379f37 
  ambari-server/src/main/java/org/apache/ambari/server/view/configuration/ViewConfig.java 728f620 
  ambari-server/src/test/java/org/apache/ambari/server/api/services/ViewDataMigrationServiceTest.java PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/orm/entities/ViewInstanceEntityTest.java c8c15da 
  ambari-server/src/test/java/org/apache/ambari/server/view/ViewDataMigrationContextImplTest.java PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/view/configuration/ViewConfigTest.java 14e5d3c 
  ambari-views/examples/README.md 650f650 
  ambari-views/examples/calculator-view/pom.xml d5e0e8e 
  ambari-views/examples/cluster-view/pom.xml 99582a6 
  ambari-views/examples/favorite-view/pom.xml ba196f5 
  ambari-views/examples/hello-servlet-view/pom.xml ed6fc25 
  ambari-views/examples/hello-spring-view/pom.xml 3475ef4 
  ambari-views/examples/helloworld-view/pom.xml aa89778 
  ambari-views/examples/phone-list-upgrade-view/docs/index.md PRE-CREATION 
  ambari-views/examples/phone-list-upgrade-view/pom.xml PRE-CREATION 
  ambari-views/examples/phone-list-upgrade-view/src/main/java/org/apache/ambari/view/phonelist/DataMigrator.java PRE-CREATION 
  ambari-views/examples/phone-list-upgrade-view/src/main/java/org/apache/ambari/view/phonelist/PhoneListServlet.java PRE-CREATION 
  ambari-views/examples/phone-list-upgrade-view/src/main/java/org/apache/ambari/view/phonelist/PhoneUser.java PRE-CREATION 
  ambari-views/examples/phone-list-upgrade-view/src/main/resources/WEB-INF/web.xml PRE-CREATION 
  ambari-views/examples/phone-list-upgrade-view/src/main/resources/view.xml PRE-CREATION 
  ambari-views/examples/phone-list-view/pom.xml ead9095 
  ambari-views/examples/pom.xml de55ded 
  ambari-views/examples/property-validator-view/pom.xml 045a277 
  ambari-views/examples/property-view/pom.xml ad4630b 
  ambari-views/examples/restricted-view/pom.xml f7fa3d6 
  ambari-views/examples/simple-view/pom.xml 015f192 
  ambari-views/examples/weather-view/pom.xml a018258 
  ambari-views/src/main/java/org/apache/ambari/view/migration/EntityConverter.java PRE-CREATION 
  ambari-views/src/main/java/org/apache/ambari/view/migration/ViewDataMigrationContext.java PRE-CREATION 
  ambari-views/src/main/java/org/apache/ambari/view/migration/ViewDataMigrationException.java PRE-CREATION 
  ambari-views/src/main/java/org/apache/ambari/view/migration/ViewDataMigrator.java PRE-CREATION 
  ambari-views/src/main/java/org/apache/ambari/view/validation/Validator.java ee029a8 
  ambari-views/src/main/resources/view.xsd c3ad711 
  pom.xml f540099 

Diff: https://reviews.apache.org/r/46271/diff/


Testing (updated)
-------

Manual testing.


Thanks,

Gaurav Nagar