You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Pallav Kulshreshtha <pa...@gmail.com> on 2017/03/07 11:25:23 UTC
Review Request 57368: JS Lint warning removal
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57368/
-----------------------------------------------------------
Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam.
Bugs: AMBARI-20339
https://issues.apache.org/jira/browse/AMBARI-20339
Repository: ambari
Description
-------
Corrected all the errros/warnings came through JS Lint
Diffs
-----
contrib/views/hive20/src/main/resources/ui/.jshintrc d421faa
contrib/views/hive20/src/main/resources/ui/app/adapters/file-resource.js a25adc7
contrib/views/hive20/src/main/resources/ui/app/adapters/hdfs-viewer.js dcd52b8
contrib/views/hive20/src/main/resources/ui/app/adapters/job.js 7559e9c
contrib/views/hive20/src/main/resources/ui/app/adapters/query.js 4913fe2
contrib/views/hive20/src/main/resources/ui/app/adapters/saved-query.js a25adc7
contrib/views/hive20/src/main/resources/ui/app/adapters/table-info.js 46e7591
contrib/views/hive20/src/main/resources/ui/app/adapters/table.js e133419
contrib/views/hive20/src/main/resources/ui/app/adapters/udf.js c929de7
contrib/views/hive20/src/main/resources/ui/app/adapters/upload-table.js 3bfe15b
contrib/views/hive20/src/main/resources/ui/app/components/create-table.js 670ebd7
contrib/views/hive20/src/main/resources/ui/app/components/edit-table.js 439dbcf
contrib/views/hive20/src/main/resources/ui/app/components/export-result.js 517da1e
contrib/views/hive20/src/main/resources/ui/app/components/fileresource-item.js 12cfb5b
contrib/views/hive20/src/main/resources/ui/app/components/job-item.js 8a6d318
contrib/views/hive20/src/main/resources/ui/app/components/list-filter.js db0b5c0
contrib/views/hive20/src/main/resources/ui/app/components/notification-message.js 339e095
contrib/views/hive20/src/main/resources/ui/app/components/query-editor.js c033e42
contrib/views/hive20/src/main/resources/ui/app/components/query-result-table.js a2eb349
contrib/views/hive20/src/main/resources/ui/app/components/table-advanced-settings.js 5e58cd8
contrib/views/hive20/src/main/resources/ui/app/components/udf-item.js 9e11550
contrib/views/hive20/src/main/resources/ui/app/components/udf-new.js 285ef07
contrib/views/hive20/src/main/resources/ui/app/components/validated-text-field.js 2379a15
contrib/views/hive20/src/main/resources/ui/app/components/visual-explain.js 8f216d1
contrib/views/hive20/src/main/resources/ui/app/configs/datatypes.js 0d07ce2
contrib/views/hive20/src/main/resources/ui/app/controllers/service-check.js 8a621db
contrib/views/hive20/src/main/resources/ui/app/helpers/extract-value.js 76b3dee
contrib/views/hive20/src/main/resources/ui/app/helpers/format-column-size.js a24f797
contrib/views/hive20/src/main/resources/ui/app/models/table-property.js 751f55c
contrib/views/hive20/src/main/resources/ui/app/router.js 250f945
contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/new.js b29d863
contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/table/edit.js 2fa61b4
contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/upload-table.js e4c543b
contrib/views/hive20/src/main/resources/ui/app/routes/jobs.js c27c74d
contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js e1ab620
contrib/views/hive20/src/main/resources/ui/app/routes/queries/query/log.js 52f8dcc
contrib/views/hive20/src/main/resources/ui/app/routes/savedqueries.js f3b27c8
contrib/views/hive20/src/main/resources/ui/app/routes/settings.js f45881b
contrib/views/hive20/src/main/resources/ui/app/routes/udfs.js fdb2cad
contrib/views/hive20/src/main/resources/ui/app/services/jobs.js fe1b596
contrib/views/hive20/src/main/resources/ui/app/services/query.js 6860f4d
contrib/views/hive20/src/main/resources/ui/app/services/saved-queries.js 2752375
contrib/views/hive20/src/main/resources/ui/app/services/service-check.js 608cafe
contrib/views/hive20/src/main/resources/ui/app/services/stats-service.js bb3ed3e
contrib/views/hive20/src/main/resources/ui/app/services/table-operations.js 2071317
contrib/views/hive20/src/main/resources/ui/app/services/udf.js 915e3d0
contrib/views/hive20/src/main/resources/ui/app/templates/components/table-advanced-settings.hbs da1c0b4
contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/enhancer.js a99b82e
contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer-force.js a73d1b2
contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js 1f6ba3c
contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/transformer.js 4a7df10
Diff: https://reviews.apache.org/r/57368/diff/1/
Testing
-------
manually tested.
Thanks,
Pallav Kulshreshtha
Re: Review Request 57368: JS Lint warning removal
Posted by venkat sairam <ve...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57368/#review168114
-----------------------------------------------------------
Ship it!
Ship It!
- venkat sairam
On March 7, 2017, 11:25 a.m., Pallav Kulshreshtha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57368/
> -----------------------------------------------------------
>
> (Updated March 7, 2017, 11:25 a.m.)
>
>
> Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam.
>
>
> Bugs: AMBARI-20339
> https://issues.apache.org/jira/browse/AMBARI-20339
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Corrected all the errros/warnings came through JS Lint
>
>
> Diffs
> -----
>
> contrib/views/hive20/src/main/resources/ui/.jshintrc d421faa
> contrib/views/hive20/src/main/resources/ui/app/adapters/file-resource.js a25adc7
> contrib/views/hive20/src/main/resources/ui/app/adapters/hdfs-viewer.js dcd52b8
> contrib/views/hive20/src/main/resources/ui/app/adapters/job.js 7559e9c
> contrib/views/hive20/src/main/resources/ui/app/adapters/query.js 4913fe2
> contrib/views/hive20/src/main/resources/ui/app/adapters/saved-query.js a25adc7
> contrib/views/hive20/src/main/resources/ui/app/adapters/table-info.js 46e7591
> contrib/views/hive20/src/main/resources/ui/app/adapters/table.js e133419
> contrib/views/hive20/src/main/resources/ui/app/adapters/udf.js c929de7
> contrib/views/hive20/src/main/resources/ui/app/adapters/upload-table.js 3bfe15b
> contrib/views/hive20/src/main/resources/ui/app/components/create-table.js 670ebd7
> contrib/views/hive20/src/main/resources/ui/app/components/edit-table.js 439dbcf
> contrib/views/hive20/src/main/resources/ui/app/components/export-result.js 517da1e
> contrib/views/hive20/src/main/resources/ui/app/components/fileresource-item.js 12cfb5b
> contrib/views/hive20/src/main/resources/ui/app/components/job-item.js 8a6d318
> contrib/views/hive20/src/main/resources/ui/app/components/list-filter.js db0b5c0
> contrib/views/hive20/src/main/resources/ui/app/components/notification-message.js 339e095
> contrib/views/hive20/src/main/resources/ui/app/components/query-editor.js c033e42
> contrib/views/hive20/src/main/resources/ui/app/components/query-result-table.js a2eb349
> contrib/views/hive20/src/main/resources/ui/app/components/table-advanced-settings.js 5e58cd8
> contrib/views/hive20/src/main/resources/ui/app/components/udf-item.js 9e11550
> contrib/views/hive20/src/main/resources/ui/app/components/udf-new.js 285ef07
> contrib/views/hive20/src/main/resources/ui/app/components/validated-text-field.js 2379a15
> contrib/views/hive20/src/main/resources/ui/app/components/visual-explain.js 8f216d1
> contrib/views/hive20/src/main/resources/ui/app/configs/datatypes.js 0d07ce2
> contrib/views/hive20/src/main/resources/ui/app/controllers/service-check.js 8a621db
> contrib/views/hive20/src/main/resources/ui/app/helpers/extract-value.js 76b3dee
> contrib/views/hive20/src/main/resources/ui/app/helpers/format-column-size.js a24f797
> contrib/views/hive20/src/main/resources/ui/app/models/table-property.js 751f55c
> contrib/views/hive20/src/main/resources/ui/app/router.js 250f945
> contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/new.js b29d863
> contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/table/edit.js 2fa61b4
> contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/upload-table.js e4c543b
> contrib/views/hive20/src/main/resources/ui/app/routes/jobs.js c27c74d
> contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js e1ab620
> contrib/views/hive20/src/main/resources/ui/app/routes/queries/query/log.js 52f8dcc
> contrib/views/hive20/src/main/resources/ui/app/routes/savedqueries.js f3b27c8
> contrib/views/hive20/src/main/resources/ui/app/routes/settings.js f45881b
> contrib/views/hive20/src/main/resources/ui/app/routes/udfs.js fdb2cad
> contrib/views/hive20/src/main/resources/ui/app/services/jobs.js fe1b596
> contrib/views/hive20/src/main/resources/ui/app/services/query.js 6860f4d
> contrib/views/hive20/src/main/resources/ui/app/services/saved-queries.js 2752375
> contrib/views/hive20/src/main/resources/ui/app/services/service-check.js 608cafe
> contrib/views/hive20/src/main/resources/ui/app/services/stats-service.js bb3ed3e
> contrib/views/hive20/src/main/resources/ui/app/services/table-operations.js 2071317
> contrib/views/hive20/src/main/resources/ui/app/services/udf.js 915e3d0
> contrib/views/hive20/src/main/resources/ui/app/templates/components/table-advanced-settings.hbs da1c0b4
> contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/enhancer.js a99b82e
> contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer-force.js a73d1b2
> contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js 1f6ba3c
> contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/transformer.js 4a7df10
>
>
> Diff: https://reviews.apache.org/r/57368/diff/1/
>
>
> Testing
> -------
>
> manually tested.
>
>
> Thanks,
>
> Pallav Kulshreshtha
>
>
Re: Review Request 57368: JS Lint warning removal
Posted by Nitiraj Rathore <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57368/#review168118
-----------------------------------------------------------
Ship it!
Ship It!
- Nitiraj Rathore
On March 7, 2017, 11:25 a.m., Pallav Kulshreshtha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57368/
> -----------------------------------------------------------
>
> (Updated March 7, 2017, 11:25 a.m.)
>
>
> Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam.
>
>
> Bugs: AMBARI-20339
> https://issues.apache.org/jira/browse/AMBARI-20339
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Corrected all the errros/warnings came through JS Lint
>
>
> Diffs
> -----
>
> contrib/views/hive20/src/main/resources/ui/.jshintrc d421faa
> contrib/views/hive20/src/main/resources/ui/app/adapters/file-resource.js a25adc7
> contrib/views/hive20/src/main/resources/ui/app/adapters/hdfs-viewer.js dcd52b8
> contrib/views/hive20/src/main/resources/ui/app/adapters/job.js 7559e9c
> contrib/views/hive20/src/main/resources/ui/app/adapters/query.js 4913fe2
> contrib/views/hive20/src/main/resources/ui/app/adapters/saved-query.js a25adc7
> contrib/views/hive20/src/main/resources/ui/app/adapters/table-info.js 46e7591
> contrib/views/hive20/src/main/resources/ui/app/adapters/table.js e133419
> contrib/views/hive20/src/main/resources/ui/app/adapters/udf.js c929de7
> contrib/views/hive20/src/main/resources/ui/app/adapters/upload-table.js 3bfe15b
> contrib/views/hive20/src/main/resources/ui/app/components/create-table.js 670ebd7
> contrib/views/hive20/src/main/resources/ui/app/components/edit-table.js 439dbcf
> contrib/views/hive20/src/main/resources/ui/app/components/export-result.js 517da1e
> contrib/views/hive20/src/main/resources/ui/app/components/fileresource-item.js 12cfb5b
> contrib/views/hive20/src/main/resources/ui/app/components/job-item.js 8a6d318
> contrib/views/hive20/src/main/resources/ui/app/components/list-filter.js db0b5c0
> contrib/views/hive20/src/main/resources/ui/app/components/notification-message.js 339e095
> contrib/views/hive20/src/main/resources/ui/app/components/query-editor.js c033e42
> contrib/views/hive20/src/main/resources/ui/app/components/query-result-table.js a2eb349
> contrib/views/hive20/src/main/resources/ui/app/components/table-advanced-settings.js 5e58cd8
> contrib/views/hive20/src/main/resources/ui/app/components/udf-item.js 9e11550
> contrib/views/hive20/src/main/resources/ui/app/components/udf-new.js 285ef07
> contrib/views/hive20/src/main/resources/ui/app/components/validated-text-field.js 2379a15
> contrib/views/hive20/src/main/resources/ui/app/components/visual-explain.js 8f216d1
> contrib/views/hive20/src/main/resources/ui/app/configs/datatypes.js 0d07ce2
> contrib/views/hive20/src/main/resources/ui/app/controllers/service-check.js 8a621db
> contrib/views/hive20/src/main/resources/ui/app/helpers/extract-value.js 76b3dee
> contrib/views/hive20/src/main/resources/ui/app/helpers/format-column-size.js a24f797
> contrib/views/hive20/src/main/resources/ui/app/models/table-property.js 751f55c
> contrib/views/hive20/src/main/resources/ui/app/router.js 250f945
> contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/new.js b29d863
> contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/table/edit.js 2fa61b4
> contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/upload-table.js e4c543b
> contrib/views/hive20/src/main/resources/ui/app/routes/jobs.js c27c74d
> contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js e1ab620
> contrib/views/hive20/src/main/resources/ui/app/routes/queries/query/log.js 52f8dcc
> contrib/views/hive20/src/main/resources/ui/app/routes/savedqueries.js f3b27c8
> contrib/views/hive20/src/main/resources/ui/app/routes/settings.js f45881b
> contrib/views/hive20/src/main/resources/ui/app/routes/udfs.js fdb2cad
> contrib/views/hive20/src/main/resources/ui/app/services/jobs.js fe1b596
> contrib/views/hive20/src/main/resources/ui/app/services/query.js 6860f4d
> contrib/views/hive20/src/main/resources/ui/app/services/saved-queries.js 2752375
> contrib/views/hive20/src/main/resources/ui/app/services/service-check.js 608cafe
> contrib/views/hive20/src/main/resources/ui/app/services/stats-service.js bb3ed3e
> contrib/views/hive20/src/main/resources/ui/app/services/table-operations.js 2071317
> contrib/views/hive20/src/main/resources/ui/app/services/udf.js 915e3d0
> contrib/views/hive20/src/main/resources/ui/app/templates/components/table-advanced-settings.hbs da1c0b4
> contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/enhancer.js a99b82e
> contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer-force.js a73d1b2
> contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js 1f6ba3c
> contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/transformer.js 4a7df10
>
>
> Diff: https://reviews.apache.org/r/57368/diff/1/
>
>
> Testing
> -------
>
> manually tested.
>
>
> Thanks,
>
> Pallav Kulshreshtha
>
>
Re: Review Request 57368: JS Lint warning removal
Posted by venkat sairam <ve...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57368/#review168115
-----------------------------------------------------------
Ship it!
Ship It!
- venkat sairam
On March 7, 2017, 11:25 a.m., Pallav Kulshreshtha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57368/
> -----------------------------------------------------------
>
> (Updated March 7, 2017, 11:25 a.m.)
>
>
> Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam.
>
>
> Bugs: AMBARI-20339
> https://issues.apache.org/jira/browse/AMBARI-20339
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Corrected all the errros/warnings came through JS Lint
>
>
> Diffs
> -----
>
> contrib/views/hive20/src/main/resources/ui/.jshintrc d421faa
> contrib/views/hive20/src/main/resources/ui/app/adapters/file-resource.js a25adc7
> contrib/views/hive20/src/main/resources/ui/app/adapters/hdfs-viewer.js dcd52b8
> contrib/views/hive20/src/main/resources/ui/app/adapters/job.js 7559e9c
> contrib/views/hive20/src/main/resources/ui/app/adapters/query.js 4913fe2
> contrib/views/hive20/src/main/resources/ui/app/adapters/saved-query.js a25adc7
> contrib/views/hive20/src/main/resources/ui/app/adapters/table-info.js 46e7591
> contrib/views/hive20/src/main/resources/ui/app/adapters/table.js e133419
> contrib/views/hive20/src/main/resources/ui/app/adapters/udf.js c929de7
> contrib/views/hive20/src/main/resources/ui/app/adapters/upload-table.js 3bfe15b
> contrib/views/hive20/src/main/resources/ui/app/components/create-table.js 670ebd7
> contrib/views/hive20/src/main/resources/ui/app/components/edit-table.js 439dbcf
> contrib/views/hive20/src/main/resources/ui/app/components/export-result.js 517da1e
> contrib/views/hive20/src/main/resources/ui/app/components/fileresource-item.js 12cfb5b
> contrib/views/hive20/src/main/resources/ui/app/components/job-item.js 8a6d318
> contrib/views/hive20/src/main/resources/ui/app/components/list-filter.js db0b5c0
> contrib/views/hive20/src/main/resources/ui/app/components/notification-message.js 339e095
> contrib/views/hive20/src/main/resources/ui/app/components/query-editor.js c033e42
> contrib/views/hive20/src/main/resources/ui/app/components/query-result-table.js a2eb349
> contrib/views/hive20/src/main/resources/ui/app/components/table-advanced-settings.js 5e58cd8
> contrib/views/hive20/src/main/resources/ui/app/components/udf-item.js 9e11550
> contrib/views/hive20/src/main/resources/ui/app/components/udf-new.js 285ef07
> contrib/views/hive20/src/main/resources/ui/app/components/validated-text-field.js 2379a15
> contrib/views/hive20/src/main/resources/ui/app/components/visual-explain.js 8f216d1
> contrib/views/hive20/src/main/resources/ui/app/configs/datatypes.js 0d07ce2
> contrib/views/hive20/src/main/resources/ui/app/controllers/service-check.js 8a621db
> contrib/views/hive20/src/main/resources/ui/app/helpers/extract-value.js 76b3dee
> contrib/views/hive20/src/main/resources/ui/app/helpers/format-column-size.js a24f797
> contrib/views/hive20/src/main/resources/ui/app/models/table-property.js 751f55c
> contrib/views/hive20/src/main/resources/ui/app/router.js 250f945
> contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/new.js b29d863
> contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/table/edit.js 2fa61b4
> contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/upload-table.js e4c543b
> contrib/views/hive20/src/main/resources/ui/app/routes/jobs.js c27c74d
> contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js e1ab620
> contrib/views/hive20/src/main/resources/ui/app/routes/queries/query/log.js 52f8dcc
> contrib/views/hive20/src/main/resources/ui/app/routes/savedqueries.js f3b27c8
> contrib/views/hive20/src/main/resources/ui/app/routes/settings.js f45881b
> contrib/views/hive20/src/main/resources/ui/app/routes/udfs.js fdb2cad
> contrib/views/hive20/src/main/resources/ui/app/services/jobs.js fe1b596
> contrib/views/hive20/src/main/resources/ui/app/services/query.js 6860f4d
> contrib/views/hive20/src/main/resources/ui/app/services/saved-queries.js 2752375
> contrib/views/hive20/src/main/resources/ui/app/services/service-check.js 608cafe
> contrib/views/hive20/src/main/resources/ui/app/services/stats-service.js bb3ed3e
> contrib/views/hive20/src/main/resources/ui/app/services/table-operations.js 2071317
> contrib/views/hive20/src/main/resources/ui/app/services/udf.js 915e3d0
> contrib/views/hive20/src/main/resources/ui/app/templates/components/table-advanced-settings.hbs da1c0b4
> contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/enhancer.js a99b82e
> contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer-force.js a73d1b2
> contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js 1f6ba3c
> contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/transformer.js 4a7df10
>
>
> Diff: https://reviews.apache.org/r/57368/diff/1/
>
>
> Testing
> -------
>
> manually tested.
>
>
> Thanks,
>
> Pallav Kulshreshtha
>
>