[GitHub] [solr] laminelam commented on pull request #1508: SOLR-16687: Add a SolrClassLoader to SolrZkClient

["laminelam (via GitHub)" <gi...@apache.org>]

laminelam commented on PR #1508:
URL: https://github.com/apache/solr/pull/1508#issuecomment-1544642363

   > This looks 👍 so far. Given a bit more time for other folks to review and some automated tests, I'd be happy to merge!
   
   Hi @gerlowskija 
   Added a test case to test SCL based instantiation, will add more tests (SC vs DCL scenarios) as part of the main PR to add support of AWS Secret Manager.
   
   I have also changed the behavior in case of an Exception is raised when instantiating _ZkACLProvider_ or _ZkCredentialsInjector_, it should fail-fast rather then ignoring it and go with the default _ZkACLProvider_/_ZkCredentialsInjector_ which sets znodes permissions  to OPEN_ACL_UNSAFE.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org