You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@ratis.apache.org by "Wei-Chiu Chuang (Jira)" <ji...@apache.org> on 2023/09/09 00:41:00 UTC

[jira] [Created] (RATIS-1885) Incorrect clientWriteRequest timer

Wei-Chiu Chuang created RATIS-1885:
--------------------------------------

             Summary: Incorrect clientWriteRequest timer
                 Key: RATIS-1885
                 URL: https://issues.apache.org/jira/browse/RATIS-1885
             Project: Ratis
          Issue Type: Bug
          Components: metrics
    Affects Versions: 2.5.1
            Reporter: Wei-Chiu Chuang


clientWriteRequest timer measures the time from receiving the client request until the leader responds back.

But this timer is only initialized when the leader responds, so the timer is always close to zero.
https://github.com/apache/ratis/blob/branch-2/ratis-server/src/main/java/org/apache/ratis/server/impl/RaftServerImpl.java#L840

The bug is accidentally fixed in 3.0.0 by RATIS-1693. But for users of 2.x this may still be worth fixing.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)