You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Ivan Kozlov <ik...@hortonworks.com> on 2015/04/16 06:17:57 UTC

Review Request 33254: String matches does not work on metrics property of Widget response

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33254/
-----------------------------------------------------------

Review request for Ambari, Jaimin Jetly and Sid Wagle.


Repository: ambari


Description
-------

Following API does not work
api/v1/clusters/c1/widgets?Widgets/metrics.matches(\"service_name\":\"HDFS\")


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/WidgetResourceProvider.java 1bd1058 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/WidgetResourceProviderTest.java 568a89c 

Diff: https://reviews.apache.org/r/33254/diff/


Testing
-------

unittest passed,
checked on working cluster that 
v1/clusters/c1/widgets?Widgets/metrics.matches(.*\"service_name\":\"HDFS\".*)
works


Thanks,

Ivan Kozlov


Re: Review Request 33254: String matches does not work on metrics property of Widget response

Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33254/#review80357
-----------------------------------------------------------

Ship it!


Ship It!

- Sid Wagle


On April 16, 2015, 4:17 a.m., Ivan Kozlov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33254/
> -----------------------------------------------------------
> 
> (Updated April 16, 2015, 4:17 a.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly and Sid Wagle.
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Following API does not work
> api/v1/clusters/c1/widgets?Widgets/metrics.matches(\"service_name\":\"HDFS\")
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/WidgetResourceProvider.java 1bd1058 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/WidgetResourceProviderTest.java 568a89c 
> 
> Diff: https://reviews.apache.org/r/33254/diff/
> 
> 
> Testing
> -------
> 
> unittest passed,
> checked on working cluster that 
> v1/clusters/c1/widgets?Widgets/metrics.matches(.*\"service_name\":\"HDFS\".*)
> works
> 
> 
> Thanks,
> 
> Ivan Kozlov
> 
>