You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "codecov[bot] (via GitHub)" <gi...@apache.org> on 2023/08/09 16:03:24 UTC
[GitHub] [superset] codecov[bot] commented on pull request #24934: feat: add MotherDuck DB engine spec
codecov[bot] commented on PR #24934:
URL: https://github.com/apache/superset/pull/24934#issuecomment-1671715902
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24934?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#24934](https://app.codecov.io/gh/apache/superset/pull/24934?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (ddccbf3) into [master](https://app.codecov.io/gh/apache/superset/commit/ec9e9a46f2f092ce56d3ed5a8a9a3ea0214db88a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (ec9e9a4) will **decrease** coverage by `10.67%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head ddccbf3 differs from pull request most recent head cf01c8c. Consider uploading reports for the commit cf01c8c to get more accurate results
```diff
@@ Coverage Diff @@
## master #24934 +/- ##
===========================================
- Coverage 69.00% 58.33% -10.67%
===========================================
Files 1906 1906
Lines 74133 74131 -2
Branches 8208 8207 -1
===========================================
- Hits 51153 43245 -7908
- Misses 20857 28764 +7907
+ Partials 2123 2122 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `54.08% <100.00%> (+<0.01%)` | :arrow_up: |
| python | `61.05% <100.00%> (-22.32%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `55.06% <100.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files Changed](https://app.codecov.io/gh/apache/superset/pull/24934?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...eatures/databases/DatabaseModal/SqlAlchemyForm.tsx](https://app.codecov.io/gh/apache/superset/pull/24934?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVzL2RhdGFiYXNlcy9EYXRhYmFzZU1vZGFsL1NxbEFsY2hlbXlGb3JtLnRzeA==) | `75.00% <ø> (+13.46%)` | :arrow_up: |
| [...end/src/features/databases/DatabaseModal/index.tsx](https://app.codecov.io/gh/apache/superset/pull/24934?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVzL2RhdGFiYXNlcy9EYXRhYmFzZU1vZGFsL2luZGV4LnRzeA==) | `43.55% <ø> (-0.12%)` | :arrow_down: |
| [superset/databases/api.py](https://app.codecov.io/gh/apache/superset/pull/24934?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `52.39% <ø> (-37.56%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://app.codecov.io/gh/apache/superset/pull/24934?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `77.06% <100.00%> (-13.97%)` | :arrow_down: |
| [superset/db\_engine\_specs/duckdb.py](https://app.codecov.io/gh/apache/superset/pull/24934?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2R1Y2tkYi5weQ==) | `91.42% <100.00%> (+1.10%)` | :arrow_up: |
... and [292 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/24934/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org