You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "yihua (via GitHub)" <gi...@apache.org> on 2023/05/19 19:20:44 UTC
[GitHub] [hudi] yihua commented on a diff in pull request #8714: [HUDI-6212] Hudi Spark 3.0.x integration
yihua commented on code in PR #8714:
URL: https://github.com/apache/hudi/pull/8714#discussion_r1199294944
##########
.github/workflows/bot.yml:
##########
@@ -63,6 +63,10 @@ jobs:
sparkProfile: "spark3.1"
sparkModules: "hudi-spark-datasource/hudi-spark3.1.x"
+ - scalaProfile: "scala-2.12"
Review Comment:
Makes sense. I've uploaded the bundle validation image for Spark 3.0: [`apachehudi/hudi-ci-bundle-validation-base:flink1146hive313spark302`](https://hub.docker.com/layers/apachehudi/hudi-ci-bundle-validation-base/flink1146hive313spark302/images/sha256-647120133e1a4aa4a48b2050c8b7a7fe678049c5368a479f1071e432e7cf84ba?context=explore). Added the config of bundle validation on Spark 3.0.
##########
hudi-spark-datasource/hudi-spark3-common/src/main/scala/org/apache/spark/sql/HoodieSpark3CatalystExpressionUtils.scala:
##########
@@ -17,16 +17,9 @@
package org.apache.spark.sql
-import org.apache.spark.sql.catalyst.expressions.{Attribute, AttributeSet, Expression, Predicate, PredicateHelper}
-import org.apache.spark.sql.execution.datasources.DataSourceStrategy
-
-trait HoodieSpark3CatalystExpressionUtils extends HoodieCatalystExpressionUtils
- with PredicateHelper {
-
- override def normalizeExprs(exprs: Seq[Expression], attributes: Seq[Attribute]): Seq[Expression] =
- DataSourceStrategy.normalizeExprs(exprs, attributes)
-
- override def extractPredicatesWithinOutputSet(condition: Expression,
- outputSet: AttributeSet): Option[Expression] =
- super[PredicateHelper].extractPredicatesWithinOutputSet(condition, outputSet)
+import org.apache.spark.sql.catalyst.expressions.{Attribute, AttributeSet, Expression}
+abstract class HoodieSpark3CatalystExpressionUtils extends HoodieCatalystExpressionUtils {
Review Comment:
Makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org