You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/25 23:27:22 UTC
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28016:
[SPARK-31238][SQL][test-hive1.2] Rebase dates to/from Julian calendar in
write/read for ORC datasource
dongjoon-hyun commented on a change in pull request #28016: [SPARK-31238][SQL][test-hive1.2] Rebase dates to/from Julian calendar in write/read for ORC datasource
URL: https://github.com/apache/spark/pull/28016#discussion_r398231280
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DaysWritable.scala
##########
@@ -35,11 +35,12 @@ import org.apache.spark.sql.catalyst.util.DateTimeUtils.{rebaseGregorianToJulian
* @param julianDays The number of days since the epoch 1970-01-01 in
* Julian calendar.
*/
-private[hive] class DaysWritable(
+class DaysWritable(
var gregorianDays: Int,
var julianDays: Int)
extends DateWritable {
Review comment:
This causes a failure in `hive-1.2` profile due to the following.
- `org.apache.hadoop.hive.serde2.io.DateWritable`
- `org.apache.orc.storage.serde2.io.DateWritable`
```
/home/jenkins/workspace/SparkPullRequestBuilder@3/sql/core/v1.2/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcShimUtils.scala:54: type mismatch;
[error] found : org.apache.spark.sql.execution.datasources.DaysWritable
[error] required: org.apache.orc.storage.serde2.io.DateWritable
[error] result
[error] ^
[info] org.apache.spark.sql.execution.datasources.DaysWritable <: org.apache.orc.storage.serde2.io.DateWritable?
[info] false
[error] /home/jenkins/workspace/SparkPullRequestBuilder@3/sql/core/v1.2/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcShimUtils.scala:57: type mismatch;
[error] found : org.apache.spark.sql.execution.datasources.DaysWritable
[error] required: org.apache.orc.storage.serde2.io.DateWritable
[error] new DaysWritable(getter.getInt(ordinal))
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org