You are viewing a plain text version of this content. The canonical link for it is here.
Posted to adffaces-issues@incubator.apache.org by "Danny Robinson (JIRA)" <ad...@incubator.apache.org> on 2006/07/24 13:53:15 UTC

[jira] Created: (ADFFACES-92) Allow the date picker to restrict the selectable days to only business days (e.g Mon-Fri)

Allow the date picker to restrict the selectable days to only business days (e.g Mon-Fri)
-----------------------------------------------------------------------------------------

                 Key: ADFFACES-92
                 URL: http://issues.apache.org/jira/browse/ADFFACES-92
             Project: MyFaces ADF-Faces
          Issue Type: Improvement
            Reporter: Danny Robinson
            Priority: Minor


Provide the ability for the date picker to display/enable only business-days (e.g. Mon-Fri), and hide/disable non-business days.

When the date picker is used for appointment booking or for selecting a payment date, then it is not valid to select non-working days.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (ADFFACES-92) Allow the date picker to restrict the selectable days to only business days (e.g Mon-Fri)

Posted by "Pierre-Luc Archambault (JIRA)" <ad...@incubator.apache.org>.
    [ http://issues.apache.org/jira/browse/ADFFACES-92?page=comments#action_12423842 ] 
            
Pierre-Luc Archambault commented on ADFFACES-92:
------------------------------------------------

As it was pointed out by a collegue of mine, there is a *major* limitation to this patch I've made... since there is only 1 renderer registered for a component, using a locale private variable to contains the initial value read when rendering a calendar causes troubles if you have more than 1 calendar in your application, the first value read about the selectability of weekend will apply to every other calendar that will get rendered.

The long term solution would then be to find why the propertyKey get lost... the problem I had pointed out in
http://mail-archives.apache.org/mod_mbox/incubator-adffaces-dev/200607.mbox/browser

> Allow the date picker to restrict the selectable days to only business days (e.g Mon-Fri)
> -----------------------------------------------------------------------------------------
>
>                 Key: ADFFACES-92
>                 URL: http://issues.apache.org/jira/browse/ADFFACES-92
>             Project: MyFaces ADF-Faces
>          Issue Type: Improvement
>            Reporter: Danny Robinson
>            Priority: Minor
>         Attachments: ChooseDateRenderer.patch, CoreChooseDate.patch
>
>
> Provide the ability for the date picker to display/enable only business-days (e.g. Mon-Fri), and hide/disable non-business days.
> When the date picker is used for appointment booking or for selecting a payment date, then it is not valid to select non-working days.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (ADFFACES-92) Allow the date picker to restrict the selectable days to only business days (e.g Mon-Fri)

Posted by "Pierre-Luc Archambault (JIRA)" <ad...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/ADFFACES-92?page=all ]

Pierre-Luc Archambault updated ADFFACES-92:
-------------------------------------------

    Attachment: CoreChooseDate.patch
                ChooseDateRenderer.patch

The 2 patchs files provided are more like a *fix* than a complete patch.

First reason is because the change are made only on the chooseDate component rather than the SelectInputDate. (the latest component DO uses a chooseDate, but its creation is deep in the implementation and was out of my understanding zone to be modifiable)

Second, I had to use a locale private variable inside the ChooseDateRenderer to store the initial value of the newly added parameter to CoreChooseDate since I couldn't retrieve the parameter value other than the first call throught.

Third, there was some ongoing discussion about using the Tobago (or was it tomahawk?) calendar component and eventually have only 1 correctly and unifiedly working component for the whole MyFaces projet.

For the rest,  I'm confident enough that at least the small modification I've provided is doing the job and might provide some help later if the calendar component get revisited.

> Allow the date picker to restrict the selectable days to only business days (e.g Mon-Fri)
> -----------------------------------------------------------------------------------------
>
>                 Key: ADFFACES-92
>                 URL: http://issues.apache.org/jira/browse/ADFFACES-92
>             Project: MyFaces ADF-Faces
>          Issue Type: Improvement
>            Reporter: Danny Robinson
>            Priority: Minor
>         Attachments: ChooseDateRenderer.patch, CoreChooseDate.patch
>
>
> Provide the ability for the date picker to display/enable only business-days (e.g. Mon-Fri), and hide/disable non-business days.
> When the date picker is used for appointment booking or for selecting a payment date, then it is not valid to select non-working days.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (ADFFACES-92) Allow the date picker to restrict the selectable days to only business days (e.g Mon-Fri)

Posted by "Pierre-Luc Archambault (JIRA)" <ad...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/ADFFACES-92?page=all ]

Pierre-Luc Archambault updated ADFFACES-92:
-------------------------------------------

    Attachment: ChooseDateRenderer.patch
                CalendarUtils.patch

Modified the ChooseDateRenderer to conserves the parameter at the SessionMap level, also added the fetching of this parameter inside the CalendarUtils so that when a new ChooseDate is created following a PPR, the parameter doesn't get lost. That way, it is possible to have more than 1 chooseDate calendar with differents setting concerning the weekend selectability.

> Allow the date picker to restrict the selectable days to only business days (e.g Mon-Fri)
> -----------------------------------------------------------------------------------------
>
>                 Key: ADFFACES-92
>                 URL: http://issues.apache.org/jira/browse/ADFFACES-92
>             Project: MyFaces ADF-Faces
>          Issue Type: Improvement
>            Reporter: Danny Robinson
>            Priority: Minor
>         Attachments: CalendarUtils.patch, ChooseDateRenderer.patch, ChooseDateRenderer.patch, CoreChooseDate.patch
>
>
> Provide the ability for the date picker to display/enable only business-days (e.g. Mon-Fri), and hide/disable non-business days.
> When the date picker is used for appointment booking or for selecting a payment date, then it is not valid to select non-working days.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (ADFFACES-92) Allow the date picker to restrict the selectable days to only business days (e.g Mon-Fri)

Posted by "Pierre-Luc Archambault (JIRA)" <ad...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/ADFFACES-92?page=all ]

Pierre-Luc Archambault updated ADFFACES-92:
-------------------------------------------

    Attachment: ChooseDateRenderer.patch
                CalendarUtils.patch

Should be last attachments... modified how the parameter was kept, instead of keeping it in a session map (which was causing trouble if more than 1 chooseDate generated calendar were used) it is now sent via the intern mecanism used by other chooseDate value.

> Allow the date picker to restrict the selectable days to only business days (e.g Mon-Fri)
> -----------------------------------------------------------------------------------------
>
>                 Key: ADFFACES-92
>                 URL: http://issues.apache.org/jira/browse/ADFFACES-92
>             Project: MyFaces ADF-Faces
>          Issue Type: Improvement
>            Reporter: Danny Robinson
>            Priority: Minor
>         Attachments: CalendarUtils.patch, CalendarUtils.patch, ChooseDateRenderer.patch, ChooseDateRenderer.patch, ChooseDateRenderer.patch, CoreChooseDate.patch
>
>
> Provide the ability for the date picker to display/enable only business-days (e.g. Mon-Fri), and hide/disable non-business days.
> When the date picker is used for appointment booking or for selecting a payment date, then it is not valid to select non-working days.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (ADFFACES-92) Allow the date picker to restrict the selectable days to only business days (e.g Mon-Fri)

Posted by "Pierre-Luc Archambault (JIRA)" <ad...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/ADFFACES-92?page=all ]

Pierre-Luc Archambault updated ADFFACES-92:
-------------------------------------------

    Attachment: trunk_patch92.patch

Revised all my modifications (not that much!) and made a single .patch files only.

This new patch add a new attribute to BOTH inputDate AND chooseDate that enable or disable the selectability of weekend day.

(small note to pay attention, its in the same format as the modification done to the startValue attribute, BUT those last are not included here, mostly saying that so you pay attention when merging those 2 patches together)

> Allow the date picker to restrict the selectable days to only business days (e.g Mon-Fri)
> -----------------------------------------------------------------------------------------
>
>                 Key: ADFFACES-92
>                 URL: http://issues.apache.org/jira/browse/ADFFACES-92
>             Project: MyFaces ADF-Faces
>          Issue Type: Improvement
>            Reporter: Danny Robinson
>            Priority: Minor
>         Attachments: CalendarUtils.patch, CalendarUtils.patch, ChooseDateRenderer.patch, ChooseDateRenderer.patch, ChooseDateRenderer.patch, CoreChooseDate.patch, trunk_patch92.patch
>
>
> Provide the ability for the date picker to display/enable only business-days (e.g. Mon-Fri), and hide/disable non-business days.
> When the date picker is used for appointment booking or for selecting a payment date, then it is not valid to select non-working days.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (ADFFACES-92) Allow the date picker to restrict the selectable days to only business days (e.g Mon-Fri)

Posted by "Pierre-Luc Archambault (JIRA)" <ad...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/ADFFACES-92?page=all ]

Pierre-Luc Archambault updated ADFFACES-92:
-------------------------------------------

    Status: Patch Available  (was: Open)

> Allow the date picker to restrict the selectable days to only business days (e.g Mon-Fri)
> -----------------------------------------------------------------------------------------
>
>                 Key: ADFFACES-92
>                 URL: http://issues.apache.org/jira/browse/ADFFACES-92
>             Project: MyFaces ADF-Faces
>          Issue Type: Improvement
>            Reporter: Danny Robinson
>            Priority: Minor
>         Attachments: ChooseDateRenderer.patch, CoreChooseDate.patch
>
>
> Provide the ability for the date picker to display/enable only business-days (e.g. Mon-Fri), and hide/disable non-business days.
> When the date picker is used for appointment booking or for selecting a payment date, then it is not valid to select non-working days.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira