You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jaimin Jetly <ja...@hortonworks.com> on 2016/02/18 18:04:50 UTC
Review Request 43722: Edit Widget Wizard still open even though it was
closed/saved in the previous step
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43722/
-----------------------------------------------------------
Review request for Ambari, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
Bugs: AMBARI-15075
https://issues.apache.org/jira/browse/AMBARI-15075
Repository: ambari
Description
-------
STR:
- Login to Ambari UI
- Click on Edit icon of any widget in HDFS services page (say Under Replicated blocks)
- Navigate through wizard. Change the name of the widget
- Save it
- This closes the wizard already
- login to ambari from another browser
- Edit widget wizard is still open
This is an intermittent issue and happens when overall API interaction with ambari-server is taking longer time
Diffs
-----
ambari-web/app/controllers/main/service/widgets/create/wizard_controller.js 69f63ed
Diff: https://reviews.apache.org/r/43722/diff/
Testing
-------
Tested manually on a cluster
Verified that ambari-web unit tests passes with the patch:
10407 tests complete (12 seconds)
121 tests pending
Thanks,
Jaimin Jetly
Re: Review Request 43722: Edit Widget Wizard still open even though
it was closed/saved in the previous step
Posted by Srimanth Gunturi <sr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43722/#review119697
-----------------------------------------------------------
Ship it!
Ship It!
- Srimanth Gunturi
On Feb. 18, 2016, 7:27 p.m., Jaimin Jetly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43722/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2016, 7:27 p.m.)
>
>
> Review request for Ambari, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
>
>
> Bugs: AMBARI-15075
> https://issues.apache.org/jira/browse/AMBARI-15075
>
>
> Repository: ambari
>
>
> Description
> -------
>
> STR:
> - Login to Ambari UI
> - Click on Edit icon of any widget in HDFS services page (say Under Replicated blocks)
> - Navigate through wizard. Change the name of the widget
> - Save it
> - This closes the wizard already
> - login to ambari from another browser
> - Edit widget wizard is still open
>
> This is an intermittent issue and happens when overall API interaction with ambari-server is taking longer time
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/main/service/widgets/create/wizard_controller.js 69f63ed
>
> Diff: https://reviews.apache.org/r/43722/diff/
>
>
> Testing
> -------
>
> Tested manually on a cluster
> Verified that ambari-web unit tests passes with the patch:
>
> 10407 tests complete (12 seconds)
> 121 tests pending
>
>
> Thanks,
>
> Jaimin Jetly
>
>
Re: Review Request 43722: Edit Widget Wizard still open even though
it was closed/saved in the previous step
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43722/
-----------------------------------------------------------
(Updated Feb. 18, 2016, 7:27 p.m.)
Review request for Ambari, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
Bugs: AMBARI-15075
https://issues.apache.org/jira/browse/AMBARI-15075
Repository: ambari
Description
-------
STR:
- Login to Ambari UI
- Click on Edit icon of any widget in HDFS services page (say Under Replicated blocks)
- Navigate through wizard. Change the name of the widget
- Save it
- This closes the wizard already
- login to ambari from another browser
- Edit widget wizard is still open
This is an intermittent issue and happens when overall API interaction with ambari-server is taking longer time
Diffs (updated)
-----
ambari-web/app/controllers/main/service/widgets/create/wizard_controller.js 69f63ed
Diff: https://reviews.apache.org/r/43722/diff/
Testing
-------
Tested manually on a cluster
Verified that ambari-web unit tests passes with the patch:
10407 tests complete (12 seconds)
121 tests pending
Thanks,
Jaimin Jetly