[GitHub] [incubator-pagespeed-mod] oschaaf commented on issue #1914: adding re2 bazel build

[GitBox <gi...@apache.org>]

oschaaf commented on issue #1914: adding re2 bazel build
URL: https://github.com/apache/incubator-pagespeed-mod/pull/1914#issuecomment-510367995
 
 
   Thanks!
   
   So looking at https://github.com/google/re2/blob/e2deff36afd0a71adbf71cb11fba71ed2a407e4f/BUILD it seems this dependency could be added as a bazel native dependency.. Trying that, it seems that that no longer builds with recent bazel versions.
   
   So what I do wonder about is: should we investigate upgrading re2 on the master branch?
   If that works, we can probably go bazel native here by depending on a more recent version, instead of rolling our own `BUILD` file and injecting that.
   
   So, let me attempt to upgrade `re2` on master, and follow up here to let you know how that went. If that turns out to be non-trivial, this is good as-is in my opinion, but if it's easy to upgrade `re2` it may make sense to go bazel-native here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services