You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/07/09 09:36:53 UTC
[GitHub] [beam] echauchot opened a new pull request #12204: [BEAM-4553] Add missing step name in graphite metrics sink messages.
echauchot opened a new pull request #12204:
URL: https://github.com/apache/beam/pull/12204
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Dataflow | Flink | Samza | Spark | Twister2
--- | --- | --- | --- | --- | --- | ---
Go | [](https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) | ---
Java | [](https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/)
Python | [](https://ci-beam.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/) | ---
XLang | --- | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/) | ---
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website
--- | --- | --- | --- | ---
Non-portable | [](https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
Portable | --- | [](https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] echauchot commented on pull request #12204: [BEAM-10431] Add missing step name in graphite metrics sink messages.
Posted by GitBox <gi...@apache.org>.
echauchot commented on pull request #12204:
URL: https://github.com/apache/beam/pull/12204#issuecomment-656587008
Thanks for the quick review as usual Alexey !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aromanenko-dev commented on pull request #12204: [BEAM-10431] Add missing step name in graphite metrics sink messages.
Posted by GitBox <gi...@apache.org>.
aromanenko-dev commented on pull request #12204:
URL: https://github.com/apache/beam/pull/12204#issuecomment-656180610
I merge this PR since failed Java PreCommit test is not related.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aromanenko-dev commented on a change in pull request #12204: [BEAM-4553] Add missing step name in graphite metrics sink messages.
Posted by GitBox <gi...@apache.org>.
aromanenko-dev commented on a change in pull request #12204:
URL: https://github.com/apache/beam/pull/12204#discussion_r452188740
##########
File path: runners/extensions-java/metrics/src/test/java/org/apache/beam/runners/extensions/metrics/MetricsGraphiteSinkTest.java
##########
@@ -69,20 +69,20 @@ public void testWriteMetricsWithCommittedSupported() throws Exception {
countDownLatch.await();
String join = String.join("\n", graphiteServer.getMessages());
String regexpr =
- "beam.counter.ns1.n1.committed.value 10 [0-9]+\\n"
- + "beam.counter.ns1.n1.attempted.value 20 [0-9]+\\n"
- + "beam.gauge.ns1.n3.committed.value 100 [0-9]+\\n"
- + "beam.gauge.ns1.n3.attempted.value 120 [0-9]+\\n"
- + "beam.distribution.ns1.n2.committed.min 5 [0-9]+\\n"
- + "beam.distribution.ns1.n2.attempted.min 3 [0-9]+\\n"
- + "beam.distribution.ns1.n2.committed.max 8 [0-9]+\\n"
- + "beam.distribution.ns1.n2.attempted.max 9 [0-9]+\\n"
- + "beam.distribution.ns1.n2.committed.count 2 [0-9]+\\n"
- + "beam.distribution.ns1.n2.attempted.count 4 [0-9]+\\n"
- + "beam.distribution.ns1.n2.committed.sum 10 [0-9]+\\n"
- + "beam.distribution.ns1.n2.attempted.sum 25 [0-9]+\\n"
- + "beam.distribution.ns1.n2.committed.mean 5.0 [0-9]+\\n"
- + "beam.distribution.ns1.n2.attempted.mean 6.25 [0-9]+";
+ "beam.counter.ns1.n1.s1.committed.value 10 [0-9]+\\n"
Review comment:
What is a reason for this and all other similar changes (`n1` -> `s1`)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] echauchot commented on a change in pull request #12204: [BEAM-10431] Add missing step name in graphite metrics sink messages.
Posted by GitBox <gi...@apache.org>.
echauchot commented on a change in pull request #12204:
URL: https://github.com/apache/beam/pull/12204#discussion_r452239069
##########
File path: runners/extensions-java/metrics/src/test/java/org/apache/beam/runners/extensions/metrics/MetricsGraphiteSinkTest.java
##########
@@ -69,20 +69,20 @@ public void testWriteMetricsWithCommittedSupported() throws Exception {
countDownLatch.await();
String join = String.join("\n", graphiteServer.getMessages());
String regexpr =
- "beam.counter.ns1.n1.committed.value 10 [0-9]+\\n"
- + "beam.counter.ns1.n1.attempted.value 20 [0-9]+\\n"
- + "beam.gauge.ns1.n3.committed.value 100 [0-9]+\\n"
- + "beam.gauge.ns1.n3.attempted.value 120 [0-9]+\\n"
- + "beam.distribution.ns1.n2.committed.min 5 [0-9]+\\n"
- + "beam.distribution.ns1.n2.attempted.min 3 [0-9]+\\n"
- + "beam.distribution.ns1.n2.committed.max 8 [0-9]+\\n"
- + "beam.distribution.ns1.n2.attempted.max 9 [0-9]+\\n"
- + "beam.distribution.ns1.n2.committed.count 2 [0-9]+\\n"
- + "beam.distribution.ns1.n2.attempted.count 4 [0-9]+\\n"
- + "beam.distribution.ns1.n2.committed.sum 10 [0-9]+\\n"
- + "beam.distribution.ns1.n2.attempted.sum 25 [0-9]+\\n"
- + "beam.distribution.ns1.n2.committed.mean 5.0 [0-9]+\\n"
- + "beam.distribution.ns1.n2.attempted.mean 6.25 [0-9]+";
+ "beam.counter.ns1.n1.s1.committed.value 10 [0-9]+\\n"
Review comment:
s1 is the step that declares the counter, s2 the step that declares distribution and s3 is the step that declares gauge.
All the point of this PR is to add missing step names in the graphite sink message format. So we need to update the test as well to expect the step names in the output.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aromanenko-dev commented on a change in pull request #12204: [BEAM-4553] Add missing step name in graphite metrics sink messages.
Posted by GitBox <gi...@apache.org>.
aromanenko-dev commented on a change in pull request #12204:
URL: https://github.com/apache/beam/pull/12204#discussion_r452188740
##########
File path: runners/extensions-java/metrics/src/test/java/org/apache/beam/runners/extensions/metrics/MetricsGraphiteSinkTest.java
##########
@@ -69,20 +69,20 @@ public void testWriteMetricsWithCommittedSupported() throws Exception {
countDownLatch.await();
String join = String.join("\n", graphiteServer.getMessages());
String regexpr =
- "beam.counter.ns1.n1.committed.value 10 [0-9]+\\n"
- + "beam.counter.ns1.n1.attempted.value 20 [0-9]+\\n"
- + "beam.gauge.ns1.n3.committed.value 100 [0-9]+\\n"
- + "beam.gauge.ns1.n3.attempted.value 120 [0-9]+\\n"
- + "beam.distribution.ns1.n2.committed.min 5 [0-9]+\\n"
- + "beam.distribution.ns1.n2.attempted.min 3 [0-9]+\\n"
- + "beam.distribution.ns1.n2.committed.max 8 [0-9]+\\n"
- + "beam.distribution.ns1.n2.attempted.max 9 [0-9]+\\n"
- + "beam.distribution.ns1.n2.committed.count 2 [0-9]+\\n"
- + "beam.distribution.ns1.n2.attempted.count 4 [0-9]+\\n"
- + "beam.distribution.ns1.n2.committed.sum 10 [0-9]+\\n"
- + "beam.distribution.ns1.n2.attempted.sum 25 [0-9]+\\n"
- + "beam.distribution.ns1.n2.committed.mean 5.0 [0-9]+\\n"
- + "beam.distribution.ns1.n2.attempted.mean 6.25 [0-9]+";
+ "beam.counter.ns1.n1.s1.committed.value 10 [0-9]+\\n"
Review comment:
What is a reason for this and all other similar changes (like `n1` -> `n1.s1`)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aromanenko-dev merged pull request #12204: [BEAM-10431] Add missing step name in graphite metrics sink messages.
Posted by GitBox <gi...@apache.org>.
aromanenko-dev merged pull request #12204:
URL: https://github.com/apache/beam/pull/12204
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org