[GitHub] [arrow-adbc] zeroshade commented on a diff in pull request #1097: fix(go/adbc/driver/snowflake): Prevent database options from getting overwritten

["zeroshade (via GitHub)" <gi...@apache.org>]

zeroshade commented on code in PR #1097:
URL: https://github.com/apache/arrow-adbc/pull/1097#discussion_r1334788789


##########
go/adbc/driver/snowflake/driver.go:
##########
@@ -330,6 +330,7 @@ func (d *database) SetOptions(cnOptions map[string]string) error {
 
 	var err error
 	for k, v := range cnOptions {
+		v := v // copy into loop scope

Review Comment:
   since the loop var here is a string and not a pointer, were we actually hitting this foot gun? Strings in Go are immutable so I don't *think* we were hitting this issue and thus this isn't necessary, but I could be wrong



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org