You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/05/18 13:52:05 UTC
[GitHub] [incubator-kvrocks] PragmaTwice opened a new pull request, #588: Fix release CI: use build.sh & use fresh directory & remove useless deps
PragmaTwice opened a new pull request, #588:
URL: https://github.com/apache/incubator-kvrocks/pull/588
- use build.sh to enable `RelWithDebInfo` mode
- use a fresh directory for packaging
- remove libsnappy package since we built snappy static library by ourselves
- other small fix on shell commands
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tisonkun commented on pull request #588: Fix release CI: use build.sh & use fresh directory & remove useless deps
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #588:
URL: https://github.com/apache/incubator-kvrocks/pull/588#issuecomment-1131320266
FWIW we may not use GitHub Actions to do the release work. At least the artifacts should go to Apache distribution file server.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] git-hulk merged pull request #588: Fix release CI: use build.sh & use fresh directory & remove useless deps
Posted by GitBox <gi...@apache.org>.
git-hulk merged PR #588:
URL: https://github.com/apache/incubator-kvrocks/pull/588
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] ShooterIT commented on pull request #588: Fix release CI: use build.sh & use fresh directory & remove useless deps
Posted by GitBox <gi...@apache.org>.
ShooterIT commented on PR #588:
URL: https://github.com/apache/incubator-kvrocks/pull/588#issuecomment-1131067920
Other CI, i think we also should use `RelWithDebInfo` mode.
> use a fresh directory for packaging
Could explain the reason. The old way can't work well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice commented on pull request #588: Fix release CI: use build.sh & use fresh directory & remove useless deps
Posted by GitBox <gi...@apache.org>.
PragmaTwice commented on PR #588:
URL: https://github.com/apache/incubator-kvrocks/pull/588#issuecomment-1131078034
> Other CI, i think we also should use `RelWithDebInfo` mode.
>
> > use a fresh directory for packaging
>
> Could explain the reason. The old way can't work well?
While we use Makefiles, the `build` directory is empty.
But now we use `cd build && cmake ..`, so there is lots of CMake-generated files in the `build` dir, which is useless for packaging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org