[GitHub] tomcat pull request #56: Convert Cluster Manager human-readable SendOptions ...

[violetagg <gi...@git.apache.org>]

Github user violetagg commented on a diff in the pull request:

    https://github.com/apache/tomcat/pull/56#discussion_r119538772
  
    --- Diff: java/org/apache/catalina/ha/tcp/SimpleTcpCluster.java ---
    @@ -339,6 +339,13 @@ public void setChannelSendOptions(int channelSendOptions) {
             this.channelSendOptions = channelSendOptions;
         }
     
    +    public void setChannelSendOptions(String channelSendOptions) {
    +
    +        int value = Channel.parseChannelSendOptions(channelSendOptions);
    +        if (value > 0)
    --- End diff --
    
    Hi,
    
    From code format point of view: We use curly braces even when there is only one statement in "if", "for" blocks.
    
    Regards,
    Violeta


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org