You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/03/25 21:00:02 UTC
[GitHub] [arrow] sanjibansg opened a new pull request #12720: ARROW-15994: [C++] Back out taskify changes
sanjibansg opened a new pull request #12720:
URL: https://github.com/apache/arrow/pull/12720
This PR modifies the `SubmitTask` and `Finish` methods of MapNode in `ExecPlan` to avoid scheduling extra thread tasks.
Performed the TPC-H Benchmark developed in PR #12537 with and without the changes.
```
TPC-H Benchmark (With Extra Thread Tasks)
-------------------------------------------------------------------
Benchmark Time CPU Iterations
-------------------------------------------------------------------
BM_Tpch_Q1/ScaleFactor:1 95035633 ns 178700 ns 100
TPC-H Benchmark (Without Extra Thread Tasks)
-------------------------------------------------------------------
Benchmark Time CPU Iterations
-------------------------------------------------------------------
BM_Tpch_Q1/ScaleFactor:1 91511754 ns 182060 ns 100
```
Also, tested with the Query Tester as proposed in PR #12586
```
With Thread Tasks (batch size = 4096)
./query_tester tpch-1
Average Duration: 0.106694s (+/- 0s)
Average Output Rows/S: 37.4902rps
Average Output Bytes/S: 4573.81bps
Without Thread Tasks (batch size = 4096)
./query_tester tpch-1
Average Duration: 0.104658s (+/- 0s)
Average Output Rows/S: 38.2198rps
Average Output Bytes/S: 4662.82bps
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12720: ARROW-15994: [C++] Back out taskify changes
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12720:
URL: https://github.com/apache/arrow/pull/12720#issuecomment-1082511592
Benchmark runs are scheduled for baseline = ac58b8d5e5f424e2f81da680d3e5c2278c8ed92c and contender = 756f2b7249d00a64bc9efcbbce75445dda6a9008. 756f2b7249d00a64bc9efcbbce75445dda6a9008 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/358a1b2d45414b98a4e1bd06a77417d1...b818f7abff464f3a88f974911ab2c0ea/)
[Finished :arrow_down:0.46% :arrow_up:0.59%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/ebf67949be6040cab9699024eadf2232...bacbe2a7b70741a3a5fb760857a8c214/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/d5be0d5857f94bef81e1eae72c2d4bca...fa5fbbf5230348ab8afdf9f03af1a6b0/)
[Finished :arrow_down:0.43% :arrow_up:0.81%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/422b3e9dca51439c979497adda714309...529ad9a82bcb43bfb8e57c58e9667870/)
Buildkite builds:
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/413| `756f2b72` ec2-t3-xlarge-us-east-2>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/399| `756f2b72` test-mac-arm>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/409| `756f2b72` ursa-thinkcentre-m75q>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/412| `ac58b8d5` ec2-t3-xlarge-us-east-2>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/398| `ac58b8d5` test-mac-arm>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/408| `ac58b8d5` ursa-thinkcentre-m75q>
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #12720: ARROW-15994: [C++] Back out taskify changes
Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #12720:
URL: https://github.com/apache/arrow/pull/12720#issuecomment-1082511592
Benchmark runs are scheduled for baseline = ac58b8d5e5f424e2f81da680d3e5c2278c8ed92c and contender = 756f2b7249d00a64bc9efcbbce75445dda6a9008. 756f2b7249d00a64bc9efcbbce75445dda6a9008 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/358a1b2d45414b98a4e1bd06a77417d1...b818f7abff464f3a88f974911ab2c0ea/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/ebf67949be6040cab9699024eadf2232...bacbe2a7b70741a3a5fb760857a8c214/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/d5be0d5857f94bef81e1eae72c2d4bca...fa5fbbf5230348ab8afdf9f03af1a6b0/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/422b3e9dca51439c979497adda714309...529ad9a82bcb43bfb8e57c58e9667870/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] sanjibansg commented on a change in pull request #12720: ARROW-15994: [C++] Back out taskify changes
Posted by GitBox <gi...@apache.org>.
sanjibansg commented on a change in pull request #12720:
URL: https://github.com/apache/arrow/pull/12720#discussion_r837980845
##########
File path: cpp/src/arrow/compute/exec/exec_plan.cc
##########
@@ -436,22 +436,11 @@ void MapNode::SubmitTask(std::function<Result<ExecBatch>(ExecBatch)> map_fn,
return Status::OK();
};
- if (executor_) {
- status = task_group_.AddTask([this, task]() -> Result<Future<>> {
- return this->executor_->Submit(this->stop_source_.token(), [this, task]() {
- auto status = task();
- if (this->input_counter_.Increment()) {
- this->Finish(status);
- }
- return status;
- });
- });
- } else {
- status = task();
- if (input_counter_.Increment()) {
- this->Finish(status);
- }
+ status = task();
+ if (input_counter_.Increment()) {
+ this->Finish(status);
}
+
// If we get a cancelled status from AddTask it means this node was stopped
// or errored out already so we can just drop the task.
if (!status.ok() && !status.IsCancelled()) {
Review comment:
Made the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12720: ARROW-15994: [C++] Back out taskify changes
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12720:
URL: https://github.com/apache/arrow/pull/12720#issuecomment-1082511592
Benchmark runs are scheduled for baseline = ac58b8d5e5f424e2f81da680d3e5c2278c8ed92c and contender = 756f2b7249d00a64bc9efcbbce75445dda6a9008. 756f2b7249d00a64bc9efcbbce75445dda6a9008 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/358a1b2d45414b98a4e1bd06a77417d1...b818f7abff464f3a88f974911ab2c0ea/)
[Finished :arrow_down:0.46% :arrow_up:0.59%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/ebf67949be6040cab9699024eadf2232...bacbe2a7b70741a3a5fb760857a8c214/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/d5be0d5857f94bef81e1eae72c2d4bca...fa5fbbf5230348ab8afdf9f03af1a6b0/)
[Finished :arrow_down:0.43% :arrow_up:0.81%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/422b3e9dca51439c979497adda714309...529ad9a82bcb43bfb8e57c58e9667870/)
Buildkite builds:
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/413| `756f2b72` ec2-t3-xlarge-us-east-2>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/399| `756f2b72` test-mac-arm>
[Scheduled] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/399| `756f2b72` ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/409| `756f2b72` ursa-thinkcentre-m75q>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/412| `ac58b8d5` ec2-t3-xlarge-us-east-2>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/398| `ac58b8d5` test-mac-arm>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/398| `ac58b8d5` ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/408| `ac58b8d5` ursa-thinkcentre-m75q>
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace closed pull request #12720: ARROW-15994: [C++] Back out taskify changes
Posted by GitBox <gi...@apache.org>.
westonpace closed pull request #12720:
URL: https://github.com/apache/arrow/pull/12720
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12720: ARROW-15994: [C++] Back out taskify changes
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12720:
URL: https://github.com/apache/arrow/pull/12720#issuecomment-1082511592
Benchmark runs are scheduled for baseline = ac58b8d5e5f424e2f81da680d3e5c2278c8ed92c and contender = 756f2b7249d00a64bc9efcbbce75445dda6a9008. 756f2b7249d00a64bc9efcbbce75445dda6a9008 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Failed] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/358a1b2d45414b98a4e1bd06a77417d1...b818f7abff464f3a88f974911ab2c0ea/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/ebf67949be6040cab9699024eadf2232...bacbe2a7b70741a3a5fb760857a8c214/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/d5be0d5857f94bef81e1eae72c2d4bca...fa5fbbf5230348ab8afdf9f03af1a6b0/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/422b3e9dca51439c979497adda714309...529ad9a82bcb43bfb8e57c58e9667870/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12720: ARROW-15994: [C++] Back out taskify changes
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12720:
URL: https://github.com/apache/arrow/pull/12720#issuecomment-1082511592
Benchmark runs are scheduled for baseline = ac58b8d5e5f424e2f81da680d3e5c2278c8ed92c and contender = 756f2b7249d00a64bc9efcbbce75445dda6a9008. 756f2b7249d00a64bc9efcbbce75445dda6a9008 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/358a1b2d45414b98a4e1bd06a77417d1...b818f7abff464f3a88f974911ab2c0ea/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/ebf67949be6040cab9699024eadf2232...bacbe2a7b70741a3a5fb760857a8c214/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/d5be0d5857f94bef81e1eae72c2d4bca...fa5fbbf5230348ab8afdf9f03af1a6b0/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/422b3e9dca51439c979497adda714309...529ad9a82bcb43bfb8e57c58e9667870/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace commented on a change in pull request #12720: ARROW-15994: [C++] Back out taskify changes
Posted by GitBox <gi...@apache.org>.
westonpace commented on a change in pull request #12720:
URL: https://github.com/apache/arrow/pull/12720#discussion_r836868243
##########
File path: cpp/src/arrow/compute/exec/exec_plan.cc
##########
@@ -436,22 +436,11 @@ void MapNode::SubmitTask(std::function<Result<ExecBatch>(ExecBatch)> map_fn,
return Status::OK();
};
- if (executor_) {
- status = task_group_.AddTask([this, task]() -> Result<Future<>> {
- return this->executor_->Submit(this->stop_source_.token(), [this, task]() {
- auto status = task();
- if (this->input_counter_.Increment()) {
- this->Finish(status);
- }
- return status;
- });
- });
- } else {
- status = task();
- if (input_counter_.Increment()) {
- this->Finish(status);
- }
+ status = task();
+ if (input_counter_.Increment()) {
Review comment:
I think it's slightly clearer to readers if this check comes after the `if (!status.ok())` check. Then we can just do...
```
if (input_counter_.Increment()) {
this->Finish();
}
```
##########
File path: cpp/src/arrow/compute/exec/exec_plan.cc
##########
@@ -436,22 +436,11 @@ void MapNode::SubmitTask(std::function<Result<ExecBatch>(ExecBatch)> map_fn,
return Status::OK();
};
- if (executor_) {
- status = task_group_.AddTask([this, task]() -> Result<Future<>> {
- return this->executor_->Submit(this->stop_source_.token(), [this, task]() {
- auto status = task();
- if (this->input_counter_.Increment()) {
- this->Finish(status);
- }
- return status;
- });
- });
- } else {
- status = task();
- if (input_counter_.Increment()) {
- this->Finish(status);
- }
+ status = task();
+ if (input_counter_.Increment()) {
+ this->Finish(status);
}
+
// If we get a cancelled status from AddTask it means this node was stopped
// or errored out already so we can just drop the task.
if (!status.ok() && !status.IsCancelled()) {
Review comment:
We don't need the comment (or the check for `!status.IsCancelled`) anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] sanjibansg commented on a change in pull request #12720: ARROW-15994: [C++] Back out taskify changes
Posted by GitBox <gi...@apache.org>.
sanjibansg commented on a change in pull request #12720:
URL: https://github.com/apache/arrow/pull/12720#discussion_r837980961
##########
File path: cpp/src/arrow/compute/exec/exec_plan.cc
##########
@@ -436,22 +436,11 @@ void MapNode::SubmitTask(std::function<Result<ExecBatch>(ExecBatch)> map_fn,
return Status::OK();
};
- if (executor_) {
- status = task_group_.AddTask([this, task]() -> Result<Future<>> {
- return this->executor_->Submit(this->stop_source_.token(), [this, task]() {
- auto status = task();
- if (this->input_counter_.Increment()) {
- this->Finish(status);
- }
- return status;
- });
- });
- } else {
- status = task();
- if (input_counter_.Increment()) {
- this->Finish(status);
- }
+ status = task();
+ if (input_counter_.Increment()) {
Review comment:
Made the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12720: ARROW-15994: [C++] Back out taskify changes
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12720:
URL: https://github.com/apache/arrow/pull/12720#issuecomment-1082511592
Benchmark runs are scheduled for baseline = ac58b8d5e5f424e2f81da680d3e5c2278c8ed92c and contender = 756f2b7249d00a64bc9efcbbce75445dda6a9008. 756f2b7249d00a64bc9efcbbce75445dda6a9008 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/358a1b2d45414b98a4e1bd06a77417d1...b818f7abff464f3a88f974911ab2c0ea/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/ebf67949be6040cab9699024eadf2232...bacbe2a7b70741a3a5fb760857a8c214/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/d5be0d5857f94bef81e1eae72c2d4bca...fa5fbbf5230348ab8afdf9f03af1a6b0/)
[Finished :arrow_down:0.43% :arrow_up:0.81%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/422b3e9dca51439c979497adda714309...529ad9a82bcb43bfb8e57c58e9667870/)
Buildkite builds:
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/413| `756f2b72` ec2-t3-xlarge-us-east-2>
[Scheduled] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/399| `756f2b72` test-mac-arm>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/409| `756f2b72` ursa-thinkcentre-m75q>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/412| `ac58b8d5` ec2-t3-xlarge-us-east-2>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/398| `ac58b8d5` test-mac-arm>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/408| `ac58b8d5` ursa-thinkcentre-m75q>
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12720: ARROW-15994: [C++] Back out taskify changes
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12720:
URL: https://github.com/apache/arrow/pull/12720#issuecomment-1082511592
Benchmark runs are scheduled for baseline = ac58b8d5e5f424e2f81da680d3e5c2278c8ed92c and contender = 756f2b7249d00a64bc9efcbbce75445dda6a9008. 756f2b7249d00a64bc9efcbbce75445dda6a9008 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/358a1b2d45414b98a4e1bd06a77417d1...b818f7abff464f3a88f974911ab2c0ea/)
[Finished :arrow_down:0.46% :arrow_up:0.59%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/ebf67949be6040cab9699024eadf2232...bacbe2a7b70741a3a5fb760857a8c214/)
[Failed :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/d5be0d5857f94bef81e1eae72c2d4bca...fa5fbbf5230348ab8afdf9f03af1a6b0/)
[Finished :arrow_down:0.43% :arrow_up:0.81%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/422b3e9dca51439c979497adda714309...529ad9a82bcb43bfb8e57c58e9667870/)
Buildkite builds:
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/413| `756f2b72` ec2-t3-xlarge-us-east-2>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/399| `756f2b72` test-mac-arm>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/399| `756f2b72` ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/409| `756f2b72` ursa-thinkcentre-m75q>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/412| `ac58b8d5` ec2-t3-xlarge-us-east-2>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/398| `ac58b8d5` test-mac-arm>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/398| `ac58b8d5` ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/408| `ac58b8d5` ursa-thinkcentre-m75q>
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12720: ARROW-15994: [C++] Back out taskify changes
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12720:
URL: https://github.com/apache/arrow/pull/12720#issuecomment-1082511592
Benchmark runs are scheduled for baseline = ac58b8d5e5f424e2f81da680d3e5c2278c8ed92c and contender = 756f2b7249d00a64bc9efcbbce75445dda6a9008. 756f2b7249d00a64bc9efcbbce75445dda6a9008 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/358a1b2d45414b98a4e1bd06a77417d1...b818f7abff464f3a88f974911ab2c0ea/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/ebf67949be6040cab9699024eadf2232...bacbe2a7b70741a3a5fb760857a8c214/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/d5be0d5857f94bef81e1eae72c2d4bca...fa5fbbf5230348ab8afdf9f03af1a6b0/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/422b3e9dca51439c979497adda714309...529ad9a82bcb43bfb8e57c58e9667870/)
Buildkite builds:
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/413| `756f2b72` ec2-t3-xlarge-us-east-2>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/412| `ac58b8d5` ec2-t3-xlarge-us-east-2>
[Scheduled] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/408| `ac58b8d5` ursa-thinkcentre-m75q>
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12720: ARROW-15994: [C++] Back out taskify changes
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12720:
URL: https://github.com/apache/arrow/pull/12720#issuecomment-1079430167
https://issues.apache.org/jira/browse/ARROW-15994
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12720: ARROW-15994: [C++] Back out taskify changes
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12720:
URL: https://github.com/apache/arrow/pull/12720#issuecomment-1082511592
Benchmark runs are scheduled for baseline = ac58b8d5e5f424e2f81da680d3e5c2278c8ed92c and contender = 756f2b7249d00a64bc9efcbbce75445dda6a9008. 756f2b7249d00a64bc9efcbbce75445dda6a9008 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/358a1b2d45414b98a4e1bd06a77417d1...b818f7abff464f3a88f974911ab2c0ea/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/ebf67949be6040cab9699024eadf2232...bacbe2a7b70741a3a5fb760857a8c214/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/d5be0d5857f94bef81e1eae72c2d4bca...fa5fbbf5230348ab8afdf9f03af1a6b0/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/422b3e9dca51439c979497adda714309...529ad9a82bcb43bfb8e57c58e9667870/)
Buildkite builds:
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/413| `756f2b72` ec2-t3-xlarge-us-east-2>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/412| `ac58b8d5` ec2-t3-xlarge-us-east-2>
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12720: ARROW-15994: [C++] Back out taskify changes
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12720:
URL: https://github.com/apache/arrow/pull/12720#issuecomment-1082511592
Benchmark runs are scheduled for baseline = ac58b8d5e5f424e2f81da680d3e5c2278c8ed92c and contender = 756f2b7249d00a64bc9efcbbce75445dda6a9008. 756f2b7249d00a64bc9efcbbce75445dda6a9008 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/358a1b2d45414b98a4e1bd06a77417d1...b818f7abff464f3a88f974911ab2c0ea/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/ebf67949be6040cab9699024eadf2232...bacbe2a7b70741a3a5fb760857a8c214/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/d5be0d5857f94bef81e1eae72c2d4bca...fa5fbbf5230348ab8afdf9f03af1a6b0/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/422b3e9dca51439c979497adda714309...529ad9a82bcb43bfb8e57c58e9667870/)
Buildkite builds:
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/413| `756f2b72` ec2-t3-xlarge-us-east-2>
[Scheduled] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/399| `756f2b72` test-mac-arm>
[Scheduled] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/409| `756f2b72` ursa-thinkcentre-m75q>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/412| `ac58b8d5` ec2-t3-xlarge-us-east-2>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/398| `ac58b8d5` test-mac-arm>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/408| `ac58b8d5` ursa-thinkcentre-m75q>
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12720: ARROW-15994: [C++] Back out taskify changes
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12720:
URL: https://github.com/apache/arrow/pull/12720#issuecomment-1082511592
Benchmark runs are scheduled for baseline = ac58b8d5e5f424e2f81da680d3e5c2278c8ed92c and contender = 756f2b7249d00a64bc9efcbbce75445dda6a9008. 756f2b7249d00a64bc9efcbbce75445dda6a9008 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/358a1b2d45414b98a4e1bd06a77417d1...b818f7abff464f3a88f974911ab2c0ea/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/ebf67949be6040cab9699024eadf2232...bacbe2a7b70741a3a5fb760857a8c214/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/d5be0d5857f94bef81e1eae72c2d4bca...fa5fbbf5230348ab8afdf9f03af1a6b0/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/422b3e9dca51439c979497adda714309...529ad9a82bcb43bfb8e57c58e9667870/)
Buildkite builds:
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/413| `756f2b72` ec2-t3-xlarge-us-east-2>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/412| `ac58b8d5` ec2-t3-xlarge-us-east-2>
[Scheduled] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/398| `ac58b8d5` test-mac-arm>
[Scheduled] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/408| `ac58b8d5` ursa-thinkcentre-m75q>
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12720: ARROW-15994: [C++] Back out taskify changes
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12720:
URL: https://github.com/apache/arrow/pull/12720#issuecomment-1082511592
Benchmark runs are scheduled for baseline = ac58b8d5e5f424e2f81da680d3e5c2278c8ed92c and contender = 756f2b7249d00a64bc9efcbbce75445dda6a9008. 756f2b7249d00a64bc9efcbbce75445dda6a9008 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/358a1b2d45414b98a4e1bd06a77417d1...b818f7abff464f3a88f974911ab2c0ea/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/ebf67949be6040cab9699024eadf2232...bacbe2a7b70741a3a5fb760857a8c214/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/d5be0d5857f94bef81e1eae72c2d4bca...fa5fbbf5230348ab8afdf9f03af1a6b0/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/422b3e9dca51439c979497adda714309...529ad9a82bcb43bfb8e57c58e9667870/)
Buildkite builds:
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/413| `756f2b72` ec2-t3-xlarge-us-east-2>
[Scheduled] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/409| `756f2b72` ursa-thinkcentre-m75q>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/412| `ac58b8d5` ec2-t3-xlarge-us-east-2>
[Scheduled] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/398| `ac58b8d5` test-mac-arm>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/408| `ac58b8d5` ursa-thinkcentre-m75q>
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12720: ARROW-15994: [C++] Back out taskify changes
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12720:
URL: https://github.com/apache/arrow/pull/12720#issuecomment-1082511592
Benchmark runs are scheduled for baseline = ac58b8d5e5f424e2f81da680d3e5c2278c8ed92c and contender = 756f2b7249d00a64bc9efcbbce75445dda6a9008. 756f2b7249d00a64bc9efcbbce75445dda6a9008 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/358a1b2d45414b98a4e1bd06a77417d1...b818f7abff464f3a88f974911ab2c0ea/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/ebf67949be6040cab9699024eadf2232...bacbe2a7b70741a3a5fb760857a8c214/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/d5be0d5857f94bef81e1eae72c2d4bca...fa5fbbf5230348ab8afdf9f03af1a6b0/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/422b3e9dca51439c979497adda714309...529ad9a82bcb43bfb8e57c58e9667870/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12720: ARROW-15994: [C++] Back out taskify changes
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12720:
URL: https://github.com/apache/arrow/pull/12720#issuecomment-1082511592
Benchmark runs are scheduled for baseline = ac58b8d5e5f424e2f81da680d3e5c2278c8ed92c and contender = 756f2b7249d00a64bc9efcbbce75445dda6a9008. 756f2b7249d00a64bc9efcbbce75445dda6a9008 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/358a1b2d45414b98a4e1bd06a77417d1...b818f7abff464f3a88f974911ab2c0ea/)
[Finished :arrow_down:0.46% :arrow_up:0.59%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/ebf67949be6040cab9699024eadf2232...bacbe2a7b70741a3a5fb760857a8c214/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/d5be0d5857f94bef81e1eae72c2d4bca...fa5fbbf5230348ab8afdf9f03af1a6b0/)
[Finished :arrow_down:0.43% :arrow_up:0.81%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/422b3e9dca51439c979497adda714309...529ad9a82bcb43bfb8e57c58e9667870/)
Buildkite builds:
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/413| `756f2b72` ec2-t3-xlarge-us-east-2>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/399| `756f2b72` test-mac-arm>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/409| `756f2b72` ursa-thinkcentre-m75q>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/412| `ac58b8d5` ec2-t3-xlarge-us-east-2>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/398| `ac58b8d5` test-mac-arm>
[Scheduled] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/398| `ac58b8d5` ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/408| `ac58b8d5` ursa-thinkcentre-m75q>
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org