You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/11/20 16:31:31 UTC

[GitHub] [pulsar] 315157973 commented on a change in pull request #8647: Use Awaitility instead Thread.sleep in InactiveTopicDeleteTest.java

315157973 commented on a change in pull request #8647:
URL: https://github.com/apache/pulsar/pull/8647#discussion_r527809758



##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/service/InactiveTopicDeleteTest.java
##########
@@ -82,12 +84,14 @@ public void testDeleteWhenNoSubscriptions() throws Exception {
         consumer.close();
         producer.close();
 
-        Thread.sleep(2000);
+        Awaitility.await().atMost(2, TimeUnit.SECONDS).until(() -> admin.topics().getList("prop/ns-abc")
+                .contains(topic));
         Assert.assertTrue(admin.topics().getList("prop/ns-abc")
             .contains(topic));

Review comment:
       Thanks lhotari for the reminder




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org