You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/03/07 23:23:48 UTC
[GitHub] [solr] epugh opened a new pull request #735: SOLR-16085: fix curl command, reformatting for easier reading
epugh opened a new pull request #735:
URL: https://github.com/apache/solr/pull/735
https://issues.apache.org/jira/browse/SOLR-16085
# Description
Trying to update my JWT settings, and ran into bug in ref guide
# Solution
fix ref guide
# Tests
Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem.
# Checklist
Please review the following and check all that apply:
- [ ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [ ] I have created a Jira issue and added the issue ID to my pull request title.
- [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [ ] I have developed this patch against the `main` branch.
- [ ] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] cpoerschke commented on a change in pull request #735: SOLR-16085: fix curl command, reformatting for easier reading
Posted by GitBox <gi...@apache.org>.
cpoerschke commented on a change in pull request #735:
URL: https://github.com/apache/solr/pull/735#discussion_r824919325
##########
File path: solr/solr-ref-guide/modules/deployment-guide/pages/jwt-authentication-plugin.adoc
##########
@@ -232,14 +239,21 @@ curl http://localhost:8983/solr/admin/authentication -H 'Content-type:applicatio
[source,bash]
----
-curl http://localhost:8983/api/cluster/security/authentication -H 'Content-type:application/json' -H 'Authorization: Bearer xxx.yyy.zzz' -d -d '{"set-property": {"blockUnknown":true, "wellKnownUrl": "https://example.com/.well-knwon/openid-configuration", "scope": "solr:read solr:write"}}'
Review comment:
yes, good to go. thanks for spotting and fixing this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] cpoerschke commented on a change in pull request #735: SOLR-16085: fix curl command, reformatting for easier reading
Posted by GitBox <gi...@apache.org>.
cpoerschke commented on a change in pull request #735:
URL: https://github.com/apache/solr/pull/735#discussion_r823039053
##########
File path: solr/solr-ref-guide/modules/deployment-guide/pages/jwt-authentication-plugin.adoc
##########
@@ -232,14 +239,21 @@ curl http://localhost:8983/solr/admin/authentication -H 'Content-type:applicatio
[source,bash]
----
-curl http://localhost:8983/api/cluster/security/authentication -H 'Content-type:application/json' -H 'Authorization: Bearer xxx.yyy.zzz' -d -d '{"set-property": {"blockUnknown":true, "wellKnownUrl": "https://example.com/.well-knwon/openid-configuration", "scope": "solr:read solr:write"}}'
Review comment:
`s/-d -d/-d` is the typo being fixed here. `git grep "\-d \-d"` finds no other cases of it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh merged pull request #735: SOLR-16085: fix curl command, reformatting for easier reading
Posted by GitBox <gi...@apache.org>.
epugh merged pull request #735:
URL: https://github.com/apache/solr/pull/735
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on a change in pull request #735: SOLR-16085: fix curl command, reformatting for easier reading
Posted by GitBox <gi...@apache.org>.
epugh commented on a change in pull request #735:
URL: https://github.com/apache/solr/pull/735#discussion_r823070864
##########
File path: solr/solr-ref-guide/modules/deployment-guide/pages/jwt-authentication-plugin.adoc
##########
@@ -232,14 +239,21 @@ curl http://localhost:8983/solr/admin/authentication -H 'Content-type:applicatio
[source,bash]
----
-curl http://localhost:8983/api/cluster/security/authentication -H 'Content-type:application/json' -H 'Authorization: Bearer xxx.yyy.zzz' -d -d '{"set-property": {"blockUnknown":true, "wellKnownUrl": "https://example.com/.well-knwon/openid-configuration", "scope": "solr:read solr:write"}}'
Review comment:
great... Does that mean you are good with this change? I meant to commit this twice, once on fixing the `-d -d` issue, and then seperately the reformatting changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org