You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/04/11 01:49:21 UTC
[GitHub] [ozone] jojochuang commented on a diff in pull request #3263: HDDS-6528. Adding Unit-Test cases for S3-Gateway Bucket-Endpoint Metrics.
jojochuang commented on code in PR #3263:
URL: https://github.com/apache/ozone/pull/3263#discussion_r846892516
##########
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/BucketEndpoint.java:
##########
@@ -145,6 +145,10 @@ public Response get(
} else {
throw ex;
}
+ } catch (OS3Exception ex) {
+ getMetrics().incGetBucketFailure();
+ LOG.debug("Bucket Does not Exist " + bucketName, ex);
+ throw newError(S3ErrorTable.NO_SUCH_BUCKET, bucketName, ex);
Review Comment:
+1 we should just increment the counter and retrhwo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org