You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@seata.apache.org by "yangli-stu (via GitHub)" <gi...@apache.org> on 2024/09/09 11:42:23 UTC
[PR] [WIP] optimize:add independent nacos for the CI process. [incubator-seata]
yangli-stu opened a new pull request, #6836:
URL: https://github.com/apache/incubator-seata/pull/6836
<!-- Please make sure you have read and understood the contributing guidelines -->
- [ ] I have registered the PR [changes](../changes).
### Ⅰ. Describe what this PR did
issue: [6832](https://github.com/apache/incubator-seata/issues/6832)
### Ⅱ. Does this pull request fix one issue?
<!-- If that, add "fixes #xxx" below in the next line, for example, fixes #97. -->
### Ⅲ. Why don't you add test cases (unit test/integration test)?
### Ⅳ. Describe how to verify it
### Ⅴ. Special notes for reviews
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize:add independent nacos for the CI process. [incubator-seata]
Posted by "funky-eyes (via GitHub)" <gi...@apache.org>.
funky-eyes commented on PR #6836:
URL: https://github.com/apache/incubator-seata/pull/6836#issuecomment-2340115761
> 登记完pr信息后，CI流程又失败了。 [DefaultCoreForEventBusTest.test:124 NullPointer](https://github.com/apache/incubator-seata/actions/runs/10787528355/job/29916515801?pr=6836#step:7:17544)
这个问题跟你这个pr无关，不用担心
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] [WIP] optimize:add independent nacos for the CI process. [incubator-seata]
Posted by "yangli-stu (via GitHub)" <gi...@apache.org>.
yangli-stu commented on code in PR #6836:
URL: https://github.com/apache/incubator-seata/pull/6836#discussion_r1750440161
##########
.github/workflows/build.yml:
##########
@@ -16,6 +16,10 @@ jobs:
ports:
- 6379:6379
options: --health-cmd="redis-cli ping" --health-interval=10s --health-timeout=5s --health-retries=3
+ nacos:
+ image: nacos/nacos-server:2.4.2
Review Comment:
好的，关闭了鉴权和增加了健康检测，等这次ci流程结果看看
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] [WIP] optimize:add independent nacos for the CI process. [incubator-seata]
Posted by "funky-eyes (via GitHub)" <gi...@apache.org>.
funky-eyes commented on code in PR #6836:
URL: https://github.com/apache/incubator-seata/pull/6836#discussion_r1751152164
##########
.github/workflows/build.yml:
##########
@@ -16,6 +16,10 @@ jobs:
ports:
- 6379:6379
options: --health-cmd="redis-cli ping" --health-interval=10s --health-timeout=5s --health-retries=3
+ nacos:
+ image: nacos/nacos-server:2.4.2
Review Comment:
> 好的，原本以为是docker compose的写法，刚刚纠正为‘GitHub Actions’的yaml格式了，再试试看
好像不行，是不是github actions容器参数设置的写法不太一样？
It doesn't seem to work. Is the github actions container parameter setting different?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] [WIP] optimize:add independent nacos for the CI process. [incubator-seata]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #6836:
URL: https://github.com/apache/incubator-seata/pull/6836#issuecomment-2339726471
## [Codecov](https://app.codecov.io/gh/apache/incubator-seata/pull/6836?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 52.41%. Comparing base [(`f2577cf`)](https://app.codecov.io/gh/apache/incubator-seata/commit/f2577cf76bbe2514a7d7fa7928e1bad748bab58a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`ca83f91`)](https://app.codecov.io/gh/apache/incubator-seata/commit/ca83f917d90e423c0f76ca2bee842d60064a8064?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/incubator-seata/pull/6836?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## 2.x #6836 +/- ##
============================================
- Coverage 52.45% 52.41% -0.04%
+ Complexity 6385 6382 -3
============================================
Files 1080 1080
Lines 37565 37565
Branches 4451 4451
============================================
- Hits 19703 19691 -12
- Misses 15910 15922 +12
Partials 1952 1952
```
[see 3 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-seata/pull/6836/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] [WIP] optimize:add independent nacos for the CI process. [incubator-seata]
Posted by "funky-eyes (via GitHub)" <gi...@apache.org>.
funky-eyes commented on code in PR #6836:
URL: https://github.com/apache/incubator-seata/pull/6836#discussion_r1750381905
##########
.github/workflows/build.yml:
##########
@@ -16,6 +16,10 @@ jobs:
ports:
- 6379:6379
options: --health-cmd="redis-cli ping" --health-interval=10s --health-timeout=5s --health-retries=3
+ nacos:
+ image: nacos/nacos-server:2.4.2
Review Comment:
这个镜像貌似拉不到，建议换一个，然后你要看下鉴权这块，是否需要配置下否则默认nacos如果开启了鉴权，ci也是过不了的，要保证关闭接口鉴权
This mirror doesn't seem to be able to be pulled. It is recommended to change it. Then you have to take a look at the authentication piece and see if it needs to be configured. Otherwise, if the authentication is turned on by nacos by default, ci will not be able to pass. Make sure to turn off the interface authentication.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] [WIP] optimize:add independent nacos for the CI process. [incubator-seata]
Posted by "yangli-stu (via GitHub)" <gi...@apache.org>.
yangli-stu commented on code in PR #6836:
URL: https://github.com/apache/incubator-seata/pull/6836#discussion_r1751149402
##########
.github/workflows/build.yml:
##########
@@ -16,6 +16,10 @@ jobs:
ports:
- 6379:6379
options: --health-cmd="redis-cli ping" --health-interval=10s --health-timeout=5s --health-retries=3
+ nacos:
+ image: nacos/nacos-server:2.4.2
Review Comment:
好的，原本以为是docker compose的写法，刚刚纠正为‘GitHub Actions’的yaml格式了，再试试看
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] [WIP] optimize:add independent nacos for the CI process. [incubator-seata]
Posted by "yangli-stu (via GitHub)" <gi...@apache.org>.
yangli-stu commented on code in PR #6836:
URL: https://github.com/apache/incubator-seata/pull/6836#discussion_r1751160560
##########
.github/workflows/build.yml:
##########
@@ -16,6 +16,19 @@ jobs:
ports:
- 6379:6379
options: --health-cmd="redis-cli ping" --health-interval=10s --health-timeout=5s --health-retries=3
+ nacos:
+ image: nacos/nacos-server:v2.4.2
+ ports:
+ - 8848:8848
+ env:
+ MODE: standalone
+ SPRING_SECURITY_ENABLED: false
+ healthcheck:
+ test: ["CMD", "curl", "-f", "http://localhost:8848/nacos/health"]
+ interval: 30s
+ timeout: 10s
+ retries: 3
+ start_period: 30s
Review Comment:
是的，改了一下，再试试看～
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize:add independent nacos for the CI process. [incubator-seata]
Posted by "yangli-stu (via GitHub)" <gi...@apache.org>.
yangli-stu commented on PR #6836:
URL: https://github.com/apache/incubator-seata/pull/6836#issuecomment-2339935665
登记完pr信息后，CI流程又失败了。
[DefaultCoreForEventBusTest.test:124 NullPointer](https://github.com/apache/incubator-seata/actions/runs/10787528355/job/29916515801?pr=6836#step:7:17544)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] [WIP] optimize:add independent nacos for the CI process. [incubator-seata]
Posted by "funky-eyes (via GitHub)" <gi...@apache.org>.
funky-eyes commented on PR #6836:
URL: https://github.com/apache/incubator-seata/pull/6836#issuecomment-2339702437
貌似可以了，让我们等待ci的最终运行结果。
It looks like it's working now. Let's wait for the final CI results.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] [WIP] optimize:add independent nacos for the CI process. [incubator-seata]
Posted by "funky-eyes (via GitHub)" <gi...@apache.org>.
funky-eyes commented on code in PR #6836:
URL: https://github.com/apache/incubator-seata/pull/6836#discussion_r1751144994
##########
.github/workflows/build.yml:
##########
@@ -16,6 +16,10 @@ jobs:
ports:
- 6379:6379
options: --health-cmd="redis-cli ping" --health-interval=10s --health-timeout=5s --health-retries=3
+ nacos:
+ image: nacos/nacos-server:2.4.2
Review Comment:
> 好的，关闭了鉴权和增加了健康检测，等这次ci流程结果看看
好像这么改动后，build的ci直接没了，不知道是不是yaml读取出现了问题，比如某些参数填写是错的，导致失效了，帮忙看下哈。
It seems that after making this change, the build CI failed, and I’m not sure if it’s due to issues with reading the YAML file, such as incorrect parameters causing it to become invalid. Could you please help check this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] [WIP] optimize:add independent nacos for the CI process. [incubator-seata]
Posted by "funky-eyes (via GitHub)" <gi...@apache.org>.
funky-eyes commented on code in PR #6836:
URL: https://github.com/apache/incubator-seata/pull/6836#discussion_r1751154490
##########
.github/workflows/build.yml:
##########
@@ -16,6 +16,19 @@ jobs:
ports:
- 6379:6379
options: --health-cmd="redis-cli ping" --health-interval=10s --health-timeout=5s --health-retries=3
+ nacos:
+ image: nacos/nacos-server:v2.4.2
+ ports:
+ - 8848:8848
+ env:
+ MODE: standalone
+ SPRING_SECURITY_ENABLED: false
+ healthcheck:
+ test: ["CMD", "curl", "-f", "http://localhost:8848/nacos/health"]
+ interval: 30s
+ timeout: 10s
+ retries: 3
+ start_period: 30s
Review Comment:
貌似这几个参数需要使用options来设置
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize:add independent nacos for the CI process. [incubator-seata]
Posted by "funky-eyes (via GitHub)" <gi...@apache.org>.
funky-eyes commented on PR #6836:
URL: https://github.com/apache/incubator-seata/pull/6836#issuecomment-2340157782
Thank you for your contributions to Seata. If possible, please send your Dingtalk contact information to my email, and I will invite you to join the Seata developer group.
[jianbin@apache.org](mailto:jianbin@apache.org)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize: add independent nacos for the CI process. [incubator-seata]
Posted by "funky-eyes (via GitHub)" <gi...@apache.org>.
funky-eyes merged PR #6836:
URL: https://github.com/apache/incubator-seata/pull/6836
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org