You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wink.apache.org by "Bryant Luk (JIRA)" <ji...@apache.org> on 2009/12/11 23:02:18 UTC
[jira] Created: (WINK-240) Change logging to be less noisy
Change logging to be less noisy
-------------------------------
Key: WINK-240
URL: https://issues.apache.org/jira/browse/WINK-240
Project: Wink
Issue Type: Improvement
Affects Versions: 1.0
Reporter: Bryant Luk
Fix For: 1.1
Some users do not like the fact that we log every exception thrown (due to their use of exceptions in their method contracts for handling business logic). Perhaps reducing the logging in RequestProcessor may be better:
In RequestProcessor#logException(Throwable) replace statements like:
{code}
logger.error(String.format(messageFormat, exceptionName), t);
{code}
with:
{code}
// don't log the whole call stack unless debugging
if (logger.isDebugEnabled()) {
logger.debug(String.format(messageFormat, exceptionName), t);
} else {
logger.info(String.format(messageFormat, exceptionName));
}
{code}
In a production environment, messages won't be logged but in development environments, a general message will be logged at info with the full call stack at debug.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WINK-240) Change logging to be less noisy
Posted by "Bryant Luk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryant Luk resolved WINK-240.
-----------------------------
Resolution: Fixed
Assignee: Bryant Luk
> Change logging to be less noisy
> -------------------------------
>
> Key: WINK-240
> URL: https://issues.apache.org/jira/browse/WINK-240
> Project: Wink
> Issue Type: Improvement
> Affects Versions: 1.0
> Reporter: Bryant Luk
> Assignee: Bryant Luk
> Fix For: 1.1
>
>
> Some users do not like the fact that we log every exception thrown (due to their use of exceptions in their method contracts for handling business logic). Perhaps reducing the logging in RequestProcessor may be better:
> In RequestProcessor#logException(Throwable) replace statements like:
> {code}
> logger.error(String.format(messageFormat, exceptionName), t);
> {code}
> with:
> {code}
> // don't log the whole call stack unless debugging
> if (logger.isDebugEnabled()) {
> logger.debug(String.format(messageFormat, exceptionName), t);
> } else {
> logger.info(String.format(messageFormat, exceptionName));
> }
> {code}
> In a production environment, messages won't be logged but in development environments, a general message will be logged at info with the full call stack at debug.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (WINK-240) Change logging to be less noisy
Posted by "Mike Rheinheimer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Rheinheimer closed WINK-240.
---------------------------------
Issue is resolved. Closing per Bryant's approval to do so.
> Change logging to be less noisy
> -------------------------------
>
> Key: WINK-240
> URL: https://issues.apache.org/jira/browse/WINK-240
> Project: Wink
> Issue Type: Improvement
> Affects Versions: 1.0
> Reporter: Bryant Luk
> Assignee: Bryant Luk
> Fix For: 1.1
>
>
> Some users do not like the fact that we log every exception thrown (due to their use of exceptions in their method contracts for handling business logic). Perhaps reducing the logging in RequestProcessor may be better:
> In RequestProcessor#logException(Throwable) replace statements like:
> {code}
> logger.error(String.format(messageFormat, exceptionName), t);
> {code}
> with:
> {code}
> // don't log the whole call stack unless debugging
> if (logger.isDebugEnabled()) {
> logger.debug(String.format(messageFormat, exceptionName), t);
> } else {
> logger.info(String.format(messageFormat, exceptionName));
> }
> {code}
> In a production environment, messages won't be logged but in development environments, a general message will be logged at info with the full call stack at debug.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WINK-240) Change logging to be less noisy
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12790917#action_12790917 ]
Hudson commented on WINK-240:
-----------------------------
Integrated in Wink-Trunk-JDK1.6-itests #50 (See [http://hudson.zones.apache.org/hudson/job/Wink-Trunk-JDK1.6-itests/50/])
Reduce logging in error path case
Stacktraces/exception objects still avaialble
in debug mode but in normal mode a simpler
info message is logged. Exception still thrown
to container and in Geronim/Tomcat this
means the stack trace is still printed out to
the container log outside of Wink.
See []
> Change logging to be less noisy
> -------------------------------
>
> Key: WINK-240
> URL: https://issues.apache.org/jira/browse/WINK-240
> Project: Wink
> Issue Type: Improvement
> Affects Versions: 1.0
> Reporter: Bryant Luk
> Assignee: Bryant Luk
> Fix For: 1.1
>
>
> Some users do not like the fact that we log every exception thrown (due to their use of exceptions in their method contracts for handling business logic). Perhaps reducing the logging in RequestProcessor may be better:
> In RequestProcessor#logException(Throwable) replace statements like:
> {code}
> logger.error(String.format(messageFormat, exceptionName), t);
> {code}
> with:
> {code}
> // don't log the whole call stack unless debugging
> if (logger.isDebugEnabled()) {
> logger.debug(String.format(messageFormat, exceptionName), t);
> } else {
> logger.info(String.format(messageFormat, exceptionName));
> }
> {code}
> In a production environment, messages won't be logged but in development environments, a general message will be logged at info with the full call stack at debug.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WINK-240) Change logging to be less noisy
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12790847#action_12790847 ]
Hudson commented on WINK-240:
-----------------------------
Integrated in Wink-Trunk-JDK1.5-itests #49 (See [http://hudson.zones.apache.org/hudson/job/Wink-Trunk-JDK1.5-itests/49/])
Reduce logging in error path case
Stacktraces/exception objects still avaialble
in debug mode but in normal mode a simpler
info message is logged. Exception still thrown
to container and in Geronim/Tomcat this
means the stack trace is still printed out to
the container log outside of Wink.
See []
> Change logging to be less noisy
> -------------------------------
>
> Key: WINK-240
> URL: https://issues.apache.org/jira/browse/WINK-240
> Project: Wink
> Issue Type: Improvement
> Affects Versions: 1.0
> Reporter: Bryant Luk
> Assignee: Bryant Luk
> Fix For: 1.1
>
>
> Some users do not like the fact that we log every exception thrown (due to their use of exceptions in their method contracts for handling business logic). Perhaps reducing the logging in RequestProcessor may be better:
> In RequestProcessor#logException(Throwable) replace statements like:
> {code}
> logger.error(String.format(messageFormat, exceptionName), t);
> {code}
> with:
> {code}
> // don't log the whole call stack unless debugging
> if (logger.isDebugEnabled()) {
> logger.debug(String.format(messageFormat, exceptionName), t);
> } else {
> logger.info(String.format(messageFormat, exceptionName));
> }
> {code}
> In a production environment, messages won't be logged but in development environments, a general message will be logged at info with the full call stack at debug.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WINK-240) Change logging to be less noisy
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12790257#action_12790257 ]
Hudson commented on WINK-240:
-----------------------------
Integrated in Wink-Trunk-JDK1.5 #248 (See [http://hudson.zones.apache.org/hudson/job/Wink-Trunk-JDK1.5/248/])
Reduce logging in error path case
Stacktraces/exception objects still avaialble
in debug mode but in normal mode a simpler
info message is logged. Exception still thrown
to container and in Geronim/Tomcat this
means the stack trace is still printed out to
the container log outside of Wink.
See []
> Change logging to be less noisy
> -------------------------------
>
> Key: WINK-240
> URL: https://issues.apache.org/jira/browse/WINK-240
> Project: Wink
> Issue Type: Improvement
> Affects Versions: 1.0
> Reporter: Bryant Luk
> Fix For: 1.1
>
>
> Some users do not like the fact that we log every exception thrown (due to their use of exceptions in their method contracts for handling business logic). Perhaps reducing the logging in RequestProcessor may be better:
> In RequestProcessor#logException(Throwable) replace statements like:
> {code}
> logger.error(String.format(messageFormat, exceptionName), t);
> {code}
> with:
> {code}
> // don't log the whole call stack unless debugging
> if (logger.isDebugEnabled()) {
> logger.debug(String.format(messageFormat, exceptionName), t);
> } else {
> logger.info(String.format(messageFormat, exceptionName));
> }
> {code}
> In a production environment, messages won't be logged but in development environments, a general message will be logged at info with the full call stack at debug.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.