You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Rajat Khandelwal <ra...@gmail.com> on 2015/04/01 22:10:43 UTC
Review Request 32722: LENS-412: Enable the check for whether a query
can be answered by the storage table's update periods
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32722/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-412
https://issues.apache.org/jira/browse/LENS-412
Repository: lens
Description
-------
Some corner cases missed in previous patch.
Diffs
-----
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java cb84f66ef57e459d34de21749d369729e3859b04
lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java 1094e4413c1355655de00b04f8a64e507e2270ee
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 6e63483dc39d6192fe32019e90b3cfafb42a2e83
lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRange.java ecd7b76d3f4073402e733ea78ecb5db62c4106c1
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java f9a37628ce5da84aab42076f5444735966873101
lens-cube/src/test/java/org/apache/lens/cube/parse/TestDateUtil.java fa2503e929862cf6b440a2eecdd2beb16b77006e
Diff: https://reviews.apache.org/r/32722/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 32722: LENS-412: Enable the check for whether a
query can be answered by the storage table's update periods
Posted by Himanshu Gahlaut <ga...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32722/#review78966
-----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java
<https://reviews.apache.org/r/32722/#comment128085>
@Data will also generate setters, it seems like code doesn't need setters on this class.
- Himanshu Gahlaut
On April 1, 2015, 8:19 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32722/
> -----------------------------------------------------------
>
> (Updated April 1, 2015, 8:19 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-412
> https://issues.apache.org/jira/browse/LENS-412
>
>
> Repository: lens
>
>
> Description
> -------
>
> Some corner cases missed in previous patch.
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java cb84f66ef57e459d34de21749d369729e3859b04
> lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java 1094e4413c1355655de00b04f8a64e507e2270ee
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 6e63483dc39d6192fe32019e90b3cfafb42a2e83
> lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRange.java ecd7b76d3f4073402e733ea78ecb5db62c4106c1
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java f9a37628ce5da84aab42076f5444735966873101
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestDateUtil.java fa2503e929862cf6b440a2eecdd2beb16b77006e
>
> Diff: https://reviews.apache.org/r/32722/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 3.436 s]
> [INFO] Lens ............................................... SUCCESS [ 3.389 s]
> [INFO] Lens API ........................................... SUCCESS [ 8.647 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 13.403 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:13 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 16.305 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 8.924 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [03:31 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 31.087 s]
> [INFO] Lens Server ........................................ SUCCESS [07:37 min]
> [INFO] Lens client ........................................ SUCCESS [ 25.264 s]
> [INFO] Lens CLI ........................................... SUCCESS [04:10 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 1.400 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 11.866 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:32 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.954 s]
> [INFO] Lens Regression .................................... SUCCESS [ 0.535 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 22:13 min
> [INFO] Finished at: 2015-04-02T01:47:27+05:30
> [INFO] Final Memory: 147M/1032M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 32722: LENS-412: Enable the check for whether a
query can be answered by the storage table's update periods
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32722/
-----------------------------------------------------------
(Updated April 2, 2015, 1:49 a.m.)
Review request for lens.
Bugs: LENS-412
https://issues.apache.org/jira/browse/LENS-412
Repository: lens
Description
-------
Some corner cases missed in previous patch.
Diffs
-----
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java cb84f66ef57e459d34de21749d369729e3859b04
lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java 1094e4413c1355655de00b04f8a64e507e2270ee
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 6e63483dc39d6192fe32019e90b3cfafb42a2e83
lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRange.java ecd7b76d3f4073402e733ea78ecb5db62c4106c1
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java f9a37628ce5da84aab42076f5444735966873101
lens-cube/src/test/java/org/apache/lens/cube/parse/TestDateUtil.java fa2503e929862cf6b440a2eecdd2beb16b77006e
Diff: https://reviews.apache.org/r/32722/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 3.436 s]
[INFO] Lens ............................................... SUCCESS [ 3.389 s]
[INFO] Lens API ........................................... SUCCESS [ 8.647 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 13.403 s]
[INFO] Lens Cube .......................................... SUCCESS [03:13 min]
[INFO] Lens DB storage .................................... SUCCESS [ 16.305 s]
[INFO] Lens Query Library ................................. SUCCESS [ 8.924 s]
[INFO] Lens Hive Driver ................................... SUCCESS [03:31 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 31.087 s]
[INFO] Lens Server ........................................ SUCCESS [07:37 min]
[INFO] Lens client ........................................ SUCCESS [ 25.264 s]
[INFO] Lens CLI ........................................... SUCCESS [04:10 min]
[INFO] Lens Examples ...................................... SUCCESS [ 1.400 s]
[INFO] Lens Distribution .................................. SUCCESS [ 11.866 s]
[INFO] Lens ML Lib ........................................ SUCCESS [01:32 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.954 s]
[INFO] Lens Regression .................................... SUCCESS [ 0.535 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 22:13 min
[INFO] Finished at: 2015-04-02T01:47:27+05:30
[INFO] Final Memory: 147M/1032M
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal