You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Adrian Cole <no...@github.com> on 2014/11/19 07:50:06 UTC
[jclouds] JCLOUDS-480 start supporting version 4 signatures for
aws-ec2. (#610)
This is a work-in-progress, but I've verified through manual testing that it works in frankfurt. The code is a variant of something I've created in the past https://github.com/Netflix/feign/blob/master/sax/src/test/java/feign/sax/examples/AWSSignatureVersion4.java
As ec2 has some really old unit tests, there's still some grunt work needed to complete this change.
You can merge this Pull Request by running:
git pull https://github.com/adriancole/jclouds adrian.signaturev4-forms
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/610
-- Commit Summary --
* JCLOUDS-480 start supporting version 4 signatures for aws-ec2.
-- File Changes --
M apis/ec2/src/main/java/org/jclouds/ec2/binders/BindS3UploadPolicyAndSignature.java (10)
M apis/ec2/src/test/java/org/jclouds/ec2/features/BaseEC2ApiTest.java (8)
M apis/sts/src/main/java/org/jclouds/aws/config/FormSigningHttpApiModule.java (14)
M apis/sts/src/main/java/org/jclouds/aws/filters/FormSigner.java (264)
A apis/sts/src/main/java/org/jclouds/aws/filters/FormSignerV4.java (187)
R apis/sts/src/test/java/org/jclouds/aws/filters/FormSignerV2Test.java (20)
M apis/sts/src/test/java/org/jclouds/aws/util/AWSUtilsTest.java (4)
M core/src/main/java/org/jclouds/rest/RequestSigner.java (5)
M providers/aws-ec2/src/main/java/org/jclouds/aws/ec2/config/AWSEC2HttpApiModule.java (3)
M providers/aws-ec2/src/test/java/org/jclouds/aws/ec2/compute/AWSEC2TemplateBuilderLiveTest.java (6)
M providers/aws-ec2/src/test/java/org/jclouds/aws/ec2/features/BaseAWSEC2ApiTest.java (8)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/610.patch
https://github.com/jclouds/jclouds/pull/610.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/610
Re: [jclouds] JCLOUDS-480 start supporting version 4 signatures for
aws-ec2. (#610)
Posted by Adrian Cole <no...@github.com>.
> @@ -66,154 +65,151 @@
> import com.google.common.collect.TreeMultimap;
> import com.google.common.io.ByteProcessor;
> import com.google.common.net.HttpHeaders;
> +import com.google.inject.ImplementedBy;
> +
> +@ImplementedBy(FormSigner.FormSignerV2.class)
> +public interface FormSigner extends HttpRequestFilter {
> +
> + /**
> + *
> + * @see <a href=
> + * "http://docs.amazonwebservices.com/AWSEC2/latest/APIReference/Query-Common-Parameters.html"
> + * />
> + */
> + static final class FormSignerV2 implements FormSigner, RequestSigner {
changes here are just indenting due to bumping the impl out to its own class.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/610/files#r20560047
Re: [jclouds] JCLOUDS-480 start supporting version 4 signatures for
aws-ec2. (#610)
Posted by Adrian Cole <no...@github.com>.
base abstraction live tests added and pass
```
-------------------------------------------------------
T E S T S
-------------------------------------------------------
Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=utf8
Running TestSuite
Configuring TestNG with: TestNG652Configurator
Starting test signatureV4(org.jclouds.aws.filters.FormSignerV4LiveTest)
Starting test testAssumeRole(org.jclouds.sts.STSApiLiveTest)
[TestNG] Test testAssumeRole(org.jclouds.sts.STSApiLiveTest) skipped.
Test suite progress: tests succeeded: 0, failed: 0, skipped: 1.
Starting test testCreateFederatedUser(org.jclouds.sts.STSApiLiveTest)
[TestNG] Test testCreateFederatedUser(org.jclouds.sts.STSApiLiveTest) succeeded: 943ms
Test suite progress: tests succeeded: 1, failed: 0, skipped: 1.
Starting test testCreateTemporaryCredentials(org.jclouds.sts.STSApiLiveTest)
[TestNG] Test signatureV4(org.jclouds.aws.filters.FormSignerV4LiveTest) succeeded: 996ms
Test suite progress: tests succeeded: 2, failed: 0, skipped: 1.
Starting test signatureV4_session(org.jclouds.aws.filters.FormSignerV4LiveTest)
[TestNG] Test testCreateTemporaryCredentials(org.jclouds.sts.STSApiLiveTest) succeeded: 335ms
Test suite progress: tests succeeded: 3, failed: 0, skipped: 1.
[TestNG] Test signatureV4_session(org.jclouds.aws.filters.FormSignerV4LiveTest) succeeded: 738ms
Test suite progress: tests succeeded: 4, failed: 0, skipped: 1.
Tests run: 5, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 3.412 sec - in TestSuite
Results :
Tests run: 5, Failures: 0, Errors: 0, Skipped: 1
```
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/610#issuecomment-64006796
Re: [jclouds] JCLOUDS-480 start supporting version 4 signatures for
aws-ec2. (#610)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #1411](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1411/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/610#issuecomment-63999839
Re: [jclouds] JCLOUDS-480 start supporting version 4 signatures for
aws-ec2. (#610)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #1398](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1398/) UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/610#issuecomment-63674253
Re: [jclouds] JCLOUDS-480 start supporting version 4 signatures for
aws-ec2. (#610)
Posted by Adrian Cole <no...@github.com>.
no more expect tests in aws-ec2. next step, port the restannotationprocessor tests,
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/610#issuecomment-63746894
Re: [jclouds] JCLOUDS-480 start supporting version 4 signatures for
aws-ec2. (#610)
Posted by Andrew Phillips <no...@github.com>.
> I'm going to merge this and move onto s3.
@adriancole PR is still open - are we waiting for something? Any way I can help?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/610#issuecomment-64459318
Re: [jclouds] JCLOUDS-480 start supporting version 4 signatures for
aws-ec2. (#610)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #1933](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1933/) UNSTABLE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/610#issuecomment-63603055
Re: [jclouds] JCLOUDS-480 start supporting version 4 signatures for
aws-ec2. (#610)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #1396](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1396/) UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/610#issuecomment-63601155
Re: [jclouds] JCLOUDS-480 start supporting version 4 signatures for
aws-ec2. (#610)
Posted by Adrian Cole <no...@github.com>.
I thought I merged it!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/610#issuecomment-64466909
Re: [jclouds] JCLOUDS-480 start supporting version 4 signatures for
aws-ec2. (#610)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #1947](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1947/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/610#issuecomment-63859540
Re: [jclouds] JCLOUDS-480 start supporting version 4 signatures for
aws-ec2. (#610)
Posted by Adrian Cole <ad...@gmail.com>.
I'm going to merge this and move onto s3.
Re: [jclouds] JCLOUDS-480 start supporting version 4 signatures for
aws-ec2. (#610)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #1951](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1951/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/610#issuecomment-64015265
Re: [jclouds] JCLOUDS-480 start supporting version 4 signatures for
aws-ec2. (#610)
Posted by Adrian Cole <no...@github.com>.
Ran live tests, noting failures in JCLOUDS-775.
No signature errors in logs, and out of almost 2500 requests, there was one 401, which resolved on the next request.
I'm not saying this is bug-free code, just that I have confidence that once unit tests are in, this is safe to merge and backport.
```
2014-11-19 21:33:52,372 DEBUG [jclouds.wire] (TestNG) >> "Action=DescribeInstances&Version=2012-06-01"
2014-11-19 21:33:52,373 DEBUG [jclouds.headers] (TestNG) >> POST https://ec2.us-west-1.amazonaws.com/ HTTP/1.1
2014-11-19 21:33:52,373 DEBUG [jclouds.headers] (TestNG) >> Host: ec2.us-west-1.amazonaws.com
2014-11-19 21:33:52,373 DEBUG [jclouds.headers] (TestNG) >> X-Amz-Date: 20141120T053352Z
2014-11-19 21:33:52,373 DEBUG [jclouds.headers] (TestNG) >> Authorization: AWS4-HMAC-SHA256 Credential=REDACTED/20141120/us-west-1/ec2/aws4_request, SignedHeaders=host;x-amz-date, Signature=5d6d25e864720ac0305ac9c52e2d5dd3f42b721e7fb0b4bffbc722014c666ea4
2014-11-19 21:33:52,373 DEBUG [jclouds.headers] (TestNG) >> Content-Type: application/x-www-form-urlencoded
2014-11-19 21:33:52,373 DEBUG [jclouds.headers] (TestNG) >> Content-Length: 43
2014-11-19 21:33:52,482 DEBUG [jclouds.headers] (TestNG) << HTTP/1.1 401 Unauthorized
2014-11-19 21:33:52,482 DEBUG [jclouds.headers] (TestNG) << Date: Thu, 20 Nov 2014 05:33:51 GMT
2014-11-19 21:33:52,482 DEBUG [jclouds.headers] (TestNG) << Transfer-Encoding: chunked
2014-11-19 21:33:52,482 DEBUG [jclouds.headers] (TestNG) << Server: AmazonEC2
2014-11-19 21:33:52,492 DEBUG [jclouds.wire] (TestNG) >> "Action=DescribeInstances&Version=2012-06-01"
2014-11-19 21:33:52,492 DEBUG [jclouds.headers] (TestNG) >> POST https://ec2.sa-east-1.amazonaws.com/ HTTP/1.1
2014-11-19 21:33:52,492 DEBUG [jclouds.headers] (TestNG) >> Host: ec2.sa-east-1.amazonaws.com
2014-11-19 21:33:52,492 DEBUG [jclouds.headers] (TestNG) >> X-Amz-Date: 20141120T053352Z
2014-11-19 21:33:52,492 DEBUG [jclouds.headers] (TestNG) >> Authorization: AWS4-HMAC-SHA256 Credential=REDACTED/20141120/sa-east-1/ec2/aws4_request, SignedHeaders=host;x-amz-date, Signature=b6222e76f4a8ee21ba7f7b340cb04c003835a2c1bd1863f1bc3e9a97a78c4321
2014-11-19 21:33:52,492 DEBUG [jclouds.headers] (TestNG) >> Content-Type: application/x-www-form-urlencoded
2014-11-19 21:33:52,492 DEBUG [jclouds.headers] (TestNG) >> Content-Length: 43
2014-11-19 21:33:52,506 DEBUG [jclouds.headers] (TestNG) << HTTP/1.1 200 OK
```
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/610#issuecomment-63766553
Re: [jclouds] JCLOUDS-480 start supporting version 4 signatures for
aws-ec2. (#610)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #1410](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1410/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/610#issuecomment-63897806
Re: [jclouds] JCLOUDS-480 start supporting version 4 signatures for
aws-ec2. (#610)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests-java-7 #315](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-7/315/) FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/610#issuecomment-63748082
Re: [jclouds] JCLOUDS-480 start supporting version 4 signatures for
aws-ec2. (#610)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #1403](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1403/) UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/610#issuecomment-63749043
Re: [jclouds] JCLOUDS-480 start supporting version 4 signatures for
aws-ec2. (#610)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests-java-7 #319](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-7/319/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/610#issuecomment-63763880
Re: [jclouds] JCLOUDS-480 start supporting version 4 signatures for
aws-ec2. (#610)
Posted by Adrian Cole <no...@github.com>.
added first mock compute service tests. There's a monster left AWSEC2ComputeServiceExpectTest, and then a bunch of RestAnnotaionProcessor tests, which I may have to just mildly adapt as I don't have 8 hours to rewrite them all and also be able to address the tons of other fixes we need.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/610#issuecomment-63707122
Re: [jclouds] JCLOUDS-480 start supporting version 4 signatures for
aws-ec2. (#610)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #1400](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1400/) UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/610#issuecomment-63709797
Re: [jclouds] JCLOUDS-480 start supporting version 4 signatures for
aws-ec2. (#610)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests-java-7 #323](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-7/323/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/610#issuecomment-63997926
Re: [jclouds] JCLOUDS-480 start supporting version 4 signatures for
aws-ec2. (#610)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #1408](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1408/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/610#issuecomment-63840385
Re: [jclouds] JCLOUDS-480 start supporting version 4 signatures for
aws-ec2. (#610)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #1936](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1936/) FAILURE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/610#issuecomment-63699169
Re: [jclouds] JCLOUDS-480 start supporting version 4 signatures for
aws-ec2. (#610)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #1940](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1940/) UNSTABLE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/610#issuecomment-63751574
Re: [jclouds] JCLOUDS-480 start supporting version 4 signatures for
aws-ec2. (#610)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #1399](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1399/) FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/610#issuecomment-63695368
Re: [jclouds] JCLOUDS-480 start supporting version 4 signatures for
aws-ec2. (#610)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests-java-7 #322](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-7/322/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/610#issuecomment-63896725
Re: [jclouds] JCLOUDS-480 start supporting version 4 signatures for
aws-ec2. (#610)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #1937](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1937/) UNSTABLE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/610#issuecomment-63714482
Re: [jclouds] JCLOUDS-480 start supporting version 4 signatures for
aws-ec2. (#610)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #1943](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1943/) UNSTABLE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/610#issuecomment-63762126
Re: [jclouds] JCLOUDS-480 start supporting version 4 signatures for
aws-ec2. (#610)
Posted by Andrew Phillips <no...@github.com>.
> jclouds-pull-requests #1412 UNSTABLE
Curious about [this test failure](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/org.apache.jclouds.provider$aws-ec2/1412/testReport/junit/org.jclouds.aws.ec2.compute/AWSEC2ComputeServiceApiMockTest/launchVPCSpotInstanceSubnetId/). It looks transient so I don't think we need to spend time on this, but perhaps something to be aware of...
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/610#issuecomment-64208246
Re: [jclouds] JCLOUDS-480 start supporting version 4 signatures for
aws-ec2. (#610)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #1406](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1406/) UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/610#issuecomment-63750128
Re: [jclouds] JCLOUDS-480 start supporting version 4 signatures for
aws-ec2. (#610)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests-java-7 #312](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-7/312/) FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/610#issuecomment-63708440
Re: [jclouds] JCLOUDS-480 start supporting version 4 signatures for
aws-ec2. (#610)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests-java-7 #321](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-7/321/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/610#issuecomment-63882305
Re: [jclouds] JCLOUDS-480 start supporting version 4 signatures for
aws-ec2. (#610)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #1407](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1407/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/610#issuecomment-63764212
Re: [jclouds] JCLOUDS-480 start supporting version 4 signatures for
aws-ec2. (#610)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #1935](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1935/) UNSTABLE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/610#issuecomment-63690421
Re: [jclouds] JCLOUDS-480 start supporting version 4 signatures for
aws-ec2. (#610)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #1948](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1948/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/610#issuecomment-63888202
Re: [jclouds] JCLOUDS-480 start supporting version 4 signatures for
aws-ec2. (#610)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests-java-7 #316](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-7/316/) FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/610#issuecomment-63748229
Re: [jclouds] JCLOUDS-480 start supporting version 4 signatures for
aws-ec2. (#610)
Posted by Andrew Phillips <no...@github.com>.
Closed #610.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/610#event-198544727
Re: [jclouds] JCLOUDS-480 start supporting version 4 signatures for
aws-ec2. (#610)
Posted by Adrian Cole <no...@github.com>.
got a base mock webserver test class working. I will convert all failing tests to that.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/610#issuecomment-63692497
Re: [jclouds] JCLOUDS-480 start supporting version 4 signatures for
aws-ec2. (#610)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #1949](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1949/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/610#issuecomment-63900775
Re: [jclouds] JCLOUDS-480 start supporting version 4 signatures for
aws-ec2. (#610)
Posted by Adrian Cole <no...@github.com>.
ok fixed the aws-ec2 tests so that they now pass with v4 signature.
TODO: run live tests (which may be in very bad shape anyway)
TODO: backfill unit test for FormSignerV4
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/610#issuecomment-63763008
Re: [jclouds] JCLOUDS-480 start supporting version 4 signatures for
aws-ec2. (#610)
Posted by Adrian Cole <no...@github.com>.
unit tests are in. ready for review
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/610#issuecomment-63894525
Re: [jclouds] JCLOUDS-480 start supporting version 4 signatures for
aws-ec2. (#610)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests-java-7 #320](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-7/320/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/610#issuecomment-63838888
Re: [jclouds] JCLOUDS-480 start supporting version 4 signatures for
aws-ec2. (#610)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #1941](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1941/) UNSTABLE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/610#issuecomment-63755525
Re: [jclouds] JCLOUDS-480 start supporting version 4 signatures for
aws-ec2. (#610)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #1950](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1950/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/610#issuecomment-64005118
Re: [jclouds] JCLOUDS-480 start supporting version 4 signatures for
aws-ec2. (#610)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests-java-7 #308](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-7/308/) FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/610#issuecomment-63600524
Re: [jclouds] JCLOUDS-480 start supporting version 4 signatures for
aws-ec2. (#610)
Posted by Andrew Phillips <no...@github.com>.
> I thought I merged it!
Er...yes...[here it is](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commit;h=a449b24e7dd9d4872b3d729a3c63add5b6033318). Wonder why GitHub was confused.
Anyway, lazy me. Sorry!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/610#issuecomment-64471302
Re: [jclouds] JCLOUDS-480 start supporting version 4 signatures for
aws-ec2. (#610)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests-java-7 #311](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-7/311/) FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/610#issuecomment-63694742
Re: [jclouds] JCLOUDS-480 start supporting version 4 signatures for
aws-ec2. (#610)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #1409](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1409/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/610#issuecomment-63884120
Re: [jclouds] JCLOUDS-480 start supporting version 4 signatures for
aws-ec2. (#610)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #1944](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1944/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/610#issuecomment-63765942
Re: [jclouds] JCLOUDS-480 start supporting version 4 signatures for
aws-ec2. (#610)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #1412](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1412/) UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/610#issuecomment-64010238
Re: [jclouds] JCLOUDS-480 start supporting version 4 signatures for
aws-ec2. (#610)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests-java-7 #324](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-7/324/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/610#issuecomment-64009006
Re: [jclouds] JCLOUDS-480 start supporting version 4 signatures for
aws-ec2. (#610)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests-java-7 #318](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-7/318/) FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/610#issuecomment-63749404
Re: [jclouds] JCLOUDS-480 start supporting version 4 signatures for
aws-ec2. (#610)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests-java-7 #310](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-7/310/) FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/610#issuecomment-63672523
Re: [jclouds] JCLOUDS-480 start supporting version 4 signatures for
aws-ec2. (#610)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #1404](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1404/) UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/610#issuecomment-63749045