You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/03/30 00:42:58 UTC
[GitHub] [druid] sthetland opened a new pull request #11048: link check fixes
sthetland opened a new pull request #11048:
URL: https://github.com/apache/druid/pull/11048
Fixing some old links. I've resolved them in various ways, either fixing the link or removing and writing the link out of the text (especially if the topic seems stale, and likely alternative link targets are hard to find).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis commented on a change in pull request #11048: Fix old broken link
Posted by GitBox <gi...@apache.org>.
clintropolis commented on a change in pull request #11048:
URL: https://github.com/apache/druid/pull/11048#discussion_r604383868
##########
File path: docs/querying/aggregations.md
##########
@@ -395,7 +395,7 @@ The [Approximate Histogram](../development/extensions-core/approximate-histogram
The algorithm used by this deprecated aggregator is highly distribution-dependent and its output is subject to serious distortions when the input does not fit within the algorithm's limitations.
-A [study published by the DataSketches team](https://datasketches.apache.org/docs/Quantiles/DruidApproxHistogramStudy.html) demonstrates some of the known failure modes of this algorithm:
+Some of the known failure modes of this algorithm include:
Review comment:
Ah, it has changed slightly, https://datasketches.apache.org/docs/QuantilesStudies/DruidApproxHistogramStudy.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis commented on a change in pull request #11048: Fix old broken link
Posted by GitBox <gi...@apache.org>.
clintropolis commented on a change in pull request #11048:
URL: https://github.com/apache/druid/pull/11048#discussion_r603732929
##########
File path: docs/querying/aggregations.md
##########
@@ -395,7 +395,7 @@ The [Approximate Histogram](../development/extensions-core/approximate-histogram
The algorithm used by this deprecated aggregator is highly distribution-dependent and its output is subject to serious distortions when the input does not fit within the algorithm's limitations.
-A [study published by the DataSketches team](https://datasketches.apache.org/docs/Quantiles/DruidApproxHistogramStudy.html) demonstrates some of the known failure modes of this algorithm:
+Some of the known failure modes of this algorithm include:
Review comment:
Is there any reason to remove this link (it doesn't seem broken)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] sthetland commented on a change in pull request #11048: Fix old broken link
Posted by GitBox <gi...@apache.org>.
sthetland commented on a change in pull request #11048:
URL: https://github.com/apache/druid/pull/11048#discussion_r604344303
##########
File path: docs/querying/aggregations.md
##########
@@ -395,7 +395,7 @@ The [Approximate Histogram](../development/extensions-core/approximate-histogram
The algorithm used by this deprecated aggregator is highly distribution-dependent and its output is subject to serious distortions when the input does not fit within the algorithm's limitations.
-A [study published by the DataSketches team](https://datasketches.apache.org/docs/Quantiles/DruidApproxHistogramStudy.html) demonstrates some of the known failure modes of this algorithm:
+Some of the known failure modes of this algorithm include:
Review comment:
It seems broken to me though, and I can't find a new link for it. Are you able to still see it? If it isn't broken, nope, no reason.. let's keep it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] sthetland commented on a change in pull request #11048: Fix old broken link
Posted by GitBox <gi...@apache.org>.
sthetland commented on a change in pull request #11048:
URL: https://github.com/apache/druid/pull/11048#discussion_r604478338
##########
File path: docs/querying/aggregations.md
##########
@@ -395,7 +395,7 @@ The [Approximate Histogram](../development/extensions-core/approximate-histogram
The algorithm used by this deprecated aggregator is highly distribution-dependent and its output is subject to serious distortions when the input does not fit within the algorithm's limitations.
-A [study published by the DataSketches team](https://datasketches.apache.org/docs/Quantiles/DruidApproxHistogramStudy.html) demonstrates some of the known failure modes of this algorithm:
+Some of the known failure modes of this algorithm include:
Review comment:
Good find! Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] suneet-s merged pull request #11048: Fix old broken link
Posted by GitBox <gi...@apache.org>.
suneet-s merged pull request #11048:
URL: https://github.com/apache/druid/pull/11048
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] suneet-s commented on pull request #11048: Fix old broken link
Posted by GitBox <gi...@apache.org>.
suneet-s commented on pull request #11048:
URL: https://github.com/apache/druid/pull/11048#issuecomment-813791798
@sthetland do you mind merging master back in to your PR. I think there were some issues with the master branch last week. I think CI should pass after that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org