You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Gaurav Nagar <gn...@hortonworks.com> on 2015/11/04 09:00:28 UTC
Review Request 39931: Hive View: Queries from history don't display
query body
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39931/
-----------------------------------------------------------
Review request for Ambari, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.
Bugs: AMBARI-13707
https://issues.apache.org/jira/browse/AMBARI-13707
Repository: ambari
Description
-------
Moved prefixing of '/' to filepath only when we query from HdfsApi in getFilePage.
Diffs
-----
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/files/FileService.java 1b8d7cc
Diff: https://reviews.apache.org/r/39931/diff/
Testing
-------
Manual testing done.
Thanks,
Gaurav Nagar
Re: Review Request 39931: Hive View: Queries from history don't
display query body
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39931/#review106720
-----------------------------------------------------------
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/files/FileService.java (lines 102 - 104)
<https://reviews.apache.org/r/39931/#comment165459>
Please edit corresponding unit test for this small change.
If there are no existing unit tests for this class, then create a seperate task to create missing unit tests for this class. We can commit this samll change but we need to track the missing coverage of unit tests on JIRA
- Jaimin Jetly
On Nov. 4, 2015, 8 a.m., Gaurav Nagar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39931/
> -----------------------------------------------------------
>
> (Updated Nov. 4, 2015, 8 a.m.)
>
>
> Review request for Ambari, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.
>
>
> Bugs: AMBARI-13707
> https://issues.apache.org/jira/browse/AMBARI-13707
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Moved prefixing of '/' to filepath only when we query from HdfsApi in getFilePage.
>
>
> Diffs
> -----
>
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/files/FileService.java 1b8d7cc
>
> Diff: https://reviews.apache.org/r/39931/diff/
>
>
> Testing
> -------
>
> Manual testing done.
>
>
> Thanks,
>
> Gaurav Nagar
>
>
Re: Review Request 39931: Hive View: Queries from history don't
display query body
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39931/#review108102
-----------------------------------------------------------
Ship it!
Ship It!
- Sumit Mohanty
On Nov. 26, 2015, 9:02 a.m., Gaurav Nagar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39931/
> -----------------------------------------------------------
>
> (Updated Nov. 26, 2015, 9:02 a.m.)
>
>
> Review request for Ambari, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.
>
>
> Bugs: AMBARI-13707
> https://issues.apache.org/jira/browse/AMBARI-13707
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Moved prefixing of '/' to filepath only when we query from HdfsApi in getFilePage.
>
>
> Diffs
> -----
>
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/files/FileService.java 1b8d7cc
> contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/files/FileServiceTest.java d6f640c
>
> Diff: https://reviews.apache.org/r/39931/diff/
>
>
> Testing
> -------
>
> Manual testing done.
>
>
> Thanks,
>
> Gaurav Nagar
>
>
Re: Review Request 39931: Hive View: Queries from history don't
display query body
Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39931/
-----------------------------------------------------------
(Updated Nov. 26, 2015, 9:02 a.m.)
Review request for Ambari, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.
Changes
-------
Added test cases
Bugs: AMBARI-13707
https://issues.apache.org/jira/browse/AMBARI-13707
Repository: ambari
Description
-------
Moved prefixing of '/' to filepath only when we query from HdfsApi in getFilePage.
Diffs (updated)
-----
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/files/FileService.java 1b8d7cc
contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/files/FileServiceTest.java d6f640c
Diff: https://reviews.apache.org/r/39931/diff/
Testing
-------
Manual testing done.
Thanks,
Gaurav Nagar