You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Nitin Galave <ni...@gmail.com> on 2019/08/08 10:58:40 UTC

Review Request 71251: UI Improvement for Roles create update and delete log on Audit -> Admin Tab.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71251/
-----------------------------------------------------------

Review request for ranger, Gautam Borad, Mehul Parikh, Pradeep Agrawal, and Velmurugan Periasamy.


Bugs: RANGER-2527
    https://issues.apache.org/jira/browse/RANGER-2527


Repository: ranger


Description
-------

Step to Reproduce:

1. Go to Users/Groups/Roles Tab, Create Roles.
2. Go to Audit -> Admin Tab .click on Roles create log.
its seem that log displayed on UI is not proper format.


Diffs
-----

  security-admin/src/main/java/org/apache/ranger/service/RangerRoleService.java 29d20a1 
  security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 5c5d54e 
  security-admin/src/main/webapp/scripts/views/reports/OperationDiffDetail.js 93458c9 
  security-admin/src/main/webapp/styles/xa.css ee637d2 
  security-admin/src/main/webapp/templates/reports/RoleOperationDiff_tmpl.html 6e3644d 
  security-admin/src/main/webapp/templates/reports/RoleUpdateOperationDiff_tmpl.html f433ecf 


Diff: https://reviews.apache.org/r/71251/diff/1/


Testing
-------

Tested that : Roles CRUD logs are getting displayed in proper format on Audit>>Admin tab.


Thanks,

Nitin Galave


Re: Review Request 71251: UI Improvement for Roles create update and delete log on Audit -> Admin Tab.

Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71251/#review217127
-----------------------------------------------------------


Ship it!




Ship It!

- Velmurugan Periasamy


On Aug. 8, 2019, 10:58 a.m., Nitin Galave wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71251/
> -----------------------------------------------------------
> 
> (Updated Aug. 8, 2019, 10:58 a.m.)
> 
> 
> Review request for ranger, Gautam Borad, Mehul Parikh, Pradeep Agrawal, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2527
>     https://issues.apache.org/jira/browse/RANGER-2527
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Step to Reproduce:
> 
> 1. Go to Users/Groups/Roles Tab, Create Roles.
> 2. Go to Audit -> Admin Tab .click on Roles create log.
> its seem that log displayed on UI is not proper format.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/service/RangerRoleService.java 29d20a1 
>   security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 5c5d54e 
>   security-admin/src/main/webapp/scripts/views/reports/OperationDiffDetail.js 93458c9 
>   security-admin/src/main/webapp/styles/xa.css ee637d2 
>   security-admin/src/main/webapp/templates/reports/RoleOperationDiff_tmpl.html 6e3644d 
>   security-admin/src/main/webapp/templates/reports/RoleUpdateOperationDiff_tmpl.html f433ecf 
> 
> 
> Diff: https://reviews.apache.org/r/71251/diff/1/
> 
> 
> Testing
> -------
> 
> Tested that : Roles CRUD logs are getting displayed in proper format on Audit>>Admin tab.
> 
> 
> Thanks,
> 
> Nitin Galave
> 
>


Re: Review Request 71251: UI Improvement for Roles create update and delete log on Audit -> Admin Tab.

Posted by Pradeep Agrawal <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71251/#review217153
-----------------------------------------------------------


Ship it!




Ship It!

- Pradeep Agrawal


On Aug. 8, 2019, 10:58 a.m., Nitin Galave wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71251/
> -----------------------------------------------------------
> 
> (Updated Aug. 8, 2019, 10:58 a.m.)
> 
> 
> Review request for ranger, Gautam Borad, Mehul Parikh, Pradeep Agrawal, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2527
>     https://issues.apache.org/jira/browse/RANGER-2527
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Step to Reproduce:
> 
> 1. Go to Users/Groups/Roles Tab, Create Roles.
> 2. Go to Audit -> Admin Tab .click on Roles create log.
> its seem that log displayed on UI is not proper format.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/service/RangerRoleService.java 29d20a1 
>   security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 5c5d54e 
>   security-admin/src/main/webapp/scripts/views/reports/OperationDiffDetail.js 93458c9 
>   security-admin/src/main/webapp/styles/xa.css ee637d2 
>   security-admin/src/main/webapp/templates/reports/RoleOperationDiff_tmpl.html 6e3644d 
>   security-admin/src/main/webapp/templates/reports/RoleUpdateOperationDiff_tmpl.html f433ecf 
> 
> 
> Diff: https://reviews.apache.org/r/71251/diff/1/
> 
> 
> Testing
> -------
> 
> Tested that : Roles CRUD logs are getting displayed in proper format on Audit>>Admin tab.
> 
> 
> Thanks,
> 
> Nitin Galave
> 
>