You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "eric-maynard (via GitHub)" <gi...@apache.org> on 2025/05/11 05:41:28 UTC
[PR] Remove FILE from default SUPPORTED_CATALOG_STORAGE_TYPES [polaris]
eric-maynard opened a new pull request, #1566:
URL: https://github.com/apache/polaris/pull/1566
FILE has been included in the default value for `SUPPORTED_CATALOG_STORAGE_TYPES` since the config's inception, but we should consider removing it as users who don't read through `configuring-polaris-for-production.md` might be inadvertently leaving an insecure storage type enabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove FILE from default SUPPORTED_CATALOG_STORAGE_TYPES [polaris]
Posted by "eric-maynard (via GitHub)" <gi...@apache.org>.
eric-maynard commented on PR #1566:
URL: https://github.com/apache/polaris/pull/1566#issuecomment-2895207332
@snazy can you clarify if there is a technical reason for the -1 here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove FILE from default SUPPORTED_CATALOG_STORAGE_TYPES [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #1566:
URL: https://github.com/apache/polaris/pull/1566#discussion_r2084652846
##########
quarkus/service/src/test/java/org/apache/polaris/service/quarkus/catalog/GetConfigTest.java:
##########
@@ -39,7 +39,14 @@ public class GetConfigTest {
@ValueSource(booleans = {true, false})
public void testGetConfig(boolean enableGenericTable) {
TestServices services =
- TestServices.builder().config(Map.of("ENABLE_GENERIC_TABLES", enableGenericTable)).build();
+ TestServices.builder()
+ .config(
+ Map.of(
+ "ENABLE_GENERIC_TABLES",
+ enableGenericTable,
+ "SUPPORTED_CATALOG_STORAGE_TYPES",
Review Comment:
For Quarkus test, I believe it should be possible to put this setting in a test profile in `application-test.properties` and/or `application-it.properties` and reduce the amount of code changes in tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove FILE from default SUPPORTED_CATALOG_STORAGE_TYPES [polaris]
Posted by "snazy (via GitHub)" <gi...@apache.org>.
snazy commented on PR #1566:
URL: https://github.com/apache/polaris/pull/1566#issuecomment-2895213548
Sure, #1532 has to go in first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove FILE from default SUPPORTED_CATALOG_STORAGE_TYPES [polaris]
Posted by "eric-maynard (via GitHub)" <gi...@apache.org>.
eric-maynard closed pull request #1566: Remove FILE from default SUPPORTED_CATALOG_STORAGE_TYPES
URL: https://github.com/apache/polaris/pull/1566
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove FILE from default SUPPORTED_CATALOG_STORAGE_TYPES [polaris]
Posted by "eric-maynard (via GitHub)" <gi...@apache.org>.
eric-maynard commented on PR #1566:
URL: https://github.com/apache/polaris/pull/1566#issuecomment-2895227244
Why does #1532 have to go in first? It seems like 1532 subsumes this PR but
they should merge quite neatly.
On Tue, May 20, 2025 at 6:04 PM Robert Stupp ***@***.***>
wrote:
> *snazy* left a comment (apache/polaris#1566)
> <https://github.com/apache/polaris/pull/1566#issuecomment-2895219545>
>
> And this one duplicates work from #1532
> <https://github.com/apache/polaris/pull/1532>
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/polaris/pull/1566#issuecomment-2895219545>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AFRE3SGBTQ7CE5F5R5Q5ACT27NOBZAVCNFSM6AAAAAB43T76IKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQOJVGIYTSNJUGU>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove FILE from default SUPPORTED_CATALOG_STORAGE_TYPES [polaris]
Posted by "eric-maynard (via GitHub)" <gi...@apache.org>.
eric-maynard commented on PR #1566:
URL: https://github.com/apache/polaris/pull/1566#issuecomment-2871677149
#1532 does a lot more than this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove FILE from default SUPPORTED_CATALOG_STORAGE_TYPES [polaris]
Posted by "eric-maynard (via GitHub)" <gi...@apache.org>.
eric-maynard commented on code in PR #1566:
URL: https://github.com/apache/polaris/pull/1566#discussion_r2087416766
##########
quarkus/service/src/test/java/org/apache/polaris/service/quarkus/catalog/GetConfigTest.java:
##########
@@ -39,7 +39,14 @@ public class GetConfigTest {
@ValueSource(booleans = {true, false})
public void testGetConfig(boolean enableGenericTable) {
TestServices services =
- TestServices.builder().config(Map.of("ENABLE_GENERIC_TABLES", enableGenericTable)).build();
+ TestServices.builder()
+ .config(
+ Map.of(
+ "ENABLE_GENERIC_TABLES",
+ enableGenericTable,
+ "SUPPORTED_CATALOG_STORAGE_TYPES",
Review Comment:
Good call, I'll try to remove this from all the Quarkus tests I can. This particular test seems to still need it even after updating `application-test.properties` though
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove FILE from default SUPPORTED_CATALOG_STORAGE_TYPES [polaris]
Posted by "snazy (via GitHub)" <gi...@apache.org>.
snazy commented on PR #1566:
URL: https://github.com/apache/polaris/pull/1566#issuecomment-2895219545
And this one duplicates work from #1532
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org