You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2023/01/19 08:06:04 UTC
[GitHub] [shardingsphere] taojintianxia opened a new pull request, #23649: Refactor : refactor the distribution for E2E metrics (#23639)
taojintianxia opened a new pull request, #23649:
URL: https://github.com/apache/shardingsphere/pull/23649
Fixes #23639.
Changes proposed in this pull request:
- refactor the proxy distribution
- remove the assembly related file from metrics E2E
- refactor the content of metrics E2E docker and docker-compose
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] taojintianxia commented on pull request #23649: Refactor : refactor the distribution for E2E metrics (#23639)
Posted by GitBox <gi...@apache.org>.
taojintianxia commented on PR #23649:
URL: https://github.com/apache/shardingsphere/pull/23649#issuecomment-1396584334
**remember this : **
build release must not contain the `-T1C` parameter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] taojintianxia commented on a diff in pull request #23649: Refactor : refactor the distribution for E2E metrics (#23639)
Posted by GitBox <gi...@apache.org>.
taojintianxia commented on code in PR #23649:
URL: https://github.com/apache/shardingsphere/pull/23649#discussion_r1080993608
##########
.github/workflows/e2e-agent.yml:
##########
@@ -78,7 +78,9 @@ jobs:
restore-keys: |
${{ env.REPOSITORY_NAME }}-maven-third-party-
- name: Build Project
- run: ./mvnw -B clean install -DskipITs -DskipTests
+ run: |
+ ./mvnw -B clean install -DskipITs -DskipTests
+ ./mvnw -B clean install -DskipITs -DskipTests -Prelease
Review Comment:
added temporarilly, will be removed when the other plugin E2E finished.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu merged pull request #23649: Refactor : refactor the distribution for E2E metrics (#23639)
Posted by GitBox <gi...@apache.org>.
terrymanu merged PR #23649:
URL: https://github.com/apache/shardingsphere/pull/23649
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org