You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "Mike Drob (Jira)" <ji...@apache.org> on 2022/02/07 18:37:00 UTC
[jira] [Reopened] (SOLR-12901) Make UnifiedHighlighter the default
[ https://issues.apache.org/jira/browse/SOLR-12901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Drob reopened SOLR-12901:
------------------------------
I'm seeing a reproducible test failure after commit 101296f606f on main:
{{gradlew :solr:core:test --tests "org.apache.solr.handler.component.CustomHighlightComponentTest.test" -Ptests.jvms=16 -Ptests.jvmargs=-XX:TieredStopAtLevel=1 -Ptests.seed=1F939F360ED456AA -Ptests.file.encoding=ISO-8859-1}}
The probably relevant line:
{noformat}
2> 6455 ERROR (qtp73637062-302) [n:127.0.0.1:52731_solr c:collection52 s:shard1 r:core_node7 x:collection52_shard1_replica_n1] o.a.s.h.RequestHandlerBase java.lang.IllegalArgumentException: fieldsIn must not be empty
2> => java.lang.IllegalArgumentException: fieldsIn must not be empty
2> at org.apache.lucene.search.uhighlight.UnifiedHighlighter.highlightFieldsAsObjects(UnifiedHighlighter.java:539) {noformat}
> Make UnifiedHighlighter the default
> -----------------------------------
>
> Key: SOLR-12901
> URL: https://issues.apache.org/jira/browse/SOLR-12901
> Project: Solr
> Issue Type: Improvement
> Components: highlighter
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Blocker
> Fix For: 9.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> I think the UnifiedHighlighter should be the default in 8.0. It's faster and more accurate than alternatives.
> The original highlighter however has some benefits:
> * Different passage/snippet delineation options; somewhat more flexible. Though no i18n BreakIterator based one.
> * Seems to handle some "special" Queries and/or QueryParsers by default better -- namely SurroundQParser. Though SOLR-12895 will address this UH issue.
> * Considers boosts in the query when computing a passage score
> * hl.alternateField, hl.maxAlternateFieldLength, hl.highlightAlternate options. Instead the UH has hl.defaultSummary boolean
> See https://builds.apache.org/job/Solr-reference-guide-master/javadoc/highlighting.html
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org