You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/06/29 15:45:16 UTC

[GitHub] [lucene-solr] antogruz opened a new pull request #2520: SOLR-15355 - Upgrade hadoop to version 3.2.2 to fix CVE

antogruz opened a new pull request #2520:
URL: https://github.com/apache/lucene-solr/pull/2520


   To do that, I’ve needed to update 2 other files:
   
   1) The HttpServer2.java. It has been forked from hadoop and would not be compatible anymore with this new version. I’ve only patched what was necessary to make the code compile and the test pass
   
   2) TestSolrCloudWithSecureImpersonation.java. This test is checking the exception thrown for some keyword. However, with the new version of hadoop, a different exception is thrown, "invalid IPv6 address". As it seems that the important check in this test is that an exception is raised, I thought that removing this rigid assertion would keep the spirit of the test.
    


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-solr] antogruz commented on pull request #2520: SOLR-15355 - Upgrade hadoop to version 3.2.2 to fix CVE

Posted by GitBox <gi...@apache.org>.
antogruz commented on pull request #2520:
URL: https://github.com/apache/lucene-solr/pull/2520#issuecomment-870718435


   Hey @dsmiley, for your information this is the Pull Request about fixing hadoop CVE.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-solr] dsmiley merged pull request #2520: SOLR-15355 - Upgrade hadoop to version 3.2.2 to fix CVE

Posted by GitBox <gi...@apache.org>.
dsmiley merged pull request #2520:
URL: https://github.com/apache/lucene-solr/pull/2520


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-solr] dsmiley commented on pull request #2520: SOLR-15355 - Upgrade hadoop to version 3.2.2 to fix CVE

Posted by GitBox <gi...@apache.org>.
dsmiley commented on pull request #2520:
URL: https://github.com/apache/lucene-solr/pull/2520#issuecomment-871104080


   RE HttpServer2, If tests pass; works for me.
   I looked a bit at the assertion you removed about the exception message and it's fine I suppose.  I doubt it's pertinent what the message string actually is.
   I'll run tests tonight.  If pass, I'll aim to merge this Friday.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-solr] markrmiller commented on pull request #2520: SOLR-15355 - Upgrade hadoop to version 3.2.2 to fix CVE

Posted by GitBox <gi...@apache.org>.
markrmiller commented on pull request #2520:
URL: https://github.com/apache/lucene-solr/pull/2520#issuecomment-870728208


   Forget in test code, so only done to modify something to make the test world happy. Perhaps allowing a file out location customization or something of the like. Don't even know what might be still necessary there after subsequent updates, so anything that has the tests happy is likely fine. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-solr] risdenk commented on pull request #2520: SOLR-15355 - Upgrade hadoop to version 3.2.2 to fix CVE

Posted by GitBox <gi...@apache.org>.
risdenk commented on pull request #2520:
URL: https://github.com/apache/lucene-solr/pull/2520#issuecomment-872398904


   > The HttpServer2.java. It has been forked from hadoop and would not be compatible anymore with this new version. I’ve only patched what was necessary to make the code compile and the test pass
   
   Ideally we wouldn't need these forks of the Hadoop. I don't remember exactly what changes where in there when I helped merge the updates. There are some security manager fixes in a few of the forked classes as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-solr] antogruz commented on pull request #2520: SOLR-15355 - Upgrade hadoop to version 3.2.2 to fix CVE

Posted by GitBox <gi...@apache.org>.
antogruz commented on pull request #2520:
URL: https://github.com/apache/lucene-solr/pull/2520#issuecomment-870717186


   Hello @markrmiller, I mention you since you added the HttpServer2.java file back in 2016 forking it from hadoop project. Please tell me if we should handle this file another way than patching it when needed. Maybe now that hadoop 3 is here we could directly import it instead of forking it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-solr] antogruz edited a comment on pull request #2520: SOLR-15355 - Upgrade hadoop to version 3.2.2 to fix CVE

Posted by GitBox <gi...@apache.org>.
antogruz edited a comment on pull request #2520:
URL: https://github.com/apache/lucene-solr/pull/2520#issuecomment-870717186


   Hello @markrmiller, I mention you since you added the HttpServer2.java file back in 2016 forking it from hadoop project. Please tell me if we should handle this file another way that patching it when needed. Maybe now that hadoop 3 is here we could directly import it instead of forking it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-solr] markrmiller edited a comment on pull request #2520: SOLR-15355 - Upgrade hadoop to version 3.2.2 to fix CVE

Posted by GitBox <gi...@apache.org>.
markrmiller edited a comment on pull request #2520:
URL: https://github.com/apache/lucene-solr/pull/2520#issuecomment-870728208


   Forked in test code, so only done to modify something to make the test world happy. Perhaps allowing a file out location customization or something of the like. Don't even know what might be still necessary there after subsequent updates, so anything that has the tests happy is likely fine. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org