You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/03/25 16:11:45 UTC

[GitHub] [incubator-kyuubi] cxzl25 commented on a change in pull request #2202: [KYUUBI #2201] Show ExecutionId when running status on query engine page

cxzl25 commented on a change in pull request #2202:
URL: https://github.com/apache/incubator-kyuubi/pull/2202#discussion_r835416937



##########
File path: kyuubi-server/src/test/scala/org/apache/kyuubi/events/KyuubiEventLoggingServiceSuite.scala
##########
@@ -82,7 +82,7 @@ class KyuubiEventLoggingServiceSuite extends WithKyuubiServer with HiveJDBCTestH
       val engineTable = engineStatementEventPath.getParent
       val resultSet2 = statement.executeQuery(s"SELECT * FROM `json`.`${engineTable}`" +
         "where statement = \"" + sql + "\"")
-      val engineStates = Array(INITIALIZED, PENDING, RUNNING, COMPILED, FINISHED)
+      val engineStates = Array(INITIALIZED, PENDING, RUNNING, COMPILED, COMPILED, FINISHED)

Review comment:
       There are indeed a lot of event logs. I read the spark engine. There are two events for starting the engine, two events for session opening and closing, and a new event for each statement execution state change, which is about 5 indivual.
   
   My changes here will add an event to each statement.
   
   Because the user's sql may not be executed quickly sometimes, the session page can better track the execution of a specific user's entire session.
   
   I also planned to do one thing, like the spark thrift server, to list a list of jobids that are continuously generated by the statement, so that there are more events.
   
   ![image](https://user-images.githubusercontent.com/3898450/160158887-0c351ffe-b992-437a-ae6c-2ee2848d9992.png)
   
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org