You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/08/27 08:36:20 UTC

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1294: fix use of addroute/delroute

xiaoxiang781216 commented on code in PR #1294:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1294#discussion_r956556577


##########
examples/mld/mld_main.c:
##########
@@ -258,9 +258,10 @@ int main(int argc, FAR char *argv[])
   FAR char *iobuffer = NULL;
   struct sockaddr_in6 host;
 #ifdef CONFIG_NET_ROUTE
-  struct sockaddr_in6 target;
-  struct sockaddr_in6 router;
-  struct sockaddr_in6 netmask;
+  struct sockaddr_storage target;

Review Comment:
   The default stack is 2KB which should be enough. BTW, since printf consume the stack around 256bytes, so the increase from sockaddr_storage(~384 bytes) is safe.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org