You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2009/04/01 17:43:13 UTC
[jira] Created: (CASSANDRA-37) Remove JDK-derived code from project
Remove JDK-derived code from project
------------------------------------
Key: CASSANDRA-37
URL: https://issues.apache.org/jira/browse/CASSANDRA-37
Project: Cassandra
Issue Type: Bug
Reporter: Jonathan Ellis
Priority: Critical
Some classes appear to have been copied from the JDK source and altered to improve them for use in Cassandra. Unfortunately neither the classic JDK nor the OpenJDK license is compatible with the Apache license that Cassandra is operating under. See https://issues.apache.org/jira/browse/LEGAL-46
Modified JDK classes include:
- BitSet [JDK: BitSet]
- DataInputBuffer [ByteArrayInputStream]
- DataOutputBuffer [ByteArrayOutputStream]
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-37) Remove JDK-derived code from
project
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12698800#action_12698800 ]
Jonathan Ellis commented on CASSANDRA-37:
-----------------------------------------
the only nontrivial change here is to change BitSet serialization to use the JDK's hooks for that since we can't access private fields directly anymore. the tests make sure to exercise that part of the code (verified by cobertura). Performance impact should be minimal since these are only read once in the process's lifetime.
> Remove JDK-derived code from project
> ------------------------------------
>
> Key: CASSANDRA-37
> URL: https://issues.apache.org/jira/browse/CASSANDRA-37
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Critical
> Fix For: 0.3
>
> Attachments: 0001-add-SSTable-tests.-in-particular-we-want-to-be-sure.patch, 0002-r-m-copied-JDK-code.patch
>
>
> Some classes appear to have been copied from the JDK source and altered to improve them for use in Cassandra. Unfortunately neither the classic JDK nor the OpenJDK license is compatible with the Apache license that Cassandra is operating under. See https://issues.apache.org/jira/browse/LEGAL-46
> Modified JDK classes include:
> - BitSet [JDK: BitSet]
> - FastByteArrayInputStream [ByteArrayInputStream]
> - FastByteArrayOutputStream [ByteArrayOutputStream]
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-37) Remove JDK-derived code from project
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-37?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-37:
------------------------------------
Attachment: 37.tgz
rebased to HEAD + 65
> Remove JDK-derived code from project
> ------------------------------------
>
> Key: CASSANDRA-37
> URL: https://issues.apache.org/jira/browse/CASSANDRA-37
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Critical
> Fix For: 0.3
>
> Attachments: 0001-add-SSTable-tests.-in-particular-we-want-to-be-sure.patch, 0002-r-m-copied-JDK-code.patch, 37.tgz
>
>
> Some classes appear to have been copied from the JDK source and altered to improve them for use in Cassandra. Unfortunately neither the classic JDK nor the OpenJDK license is compatible with the Apache license that Cassandra is operating under. See https://issues.apache.org/jira/browse/LEGAL-46
> Modified JDK classes include:
> - BitSet [JDK: BitSet]
> - FastByteArrayInputStream [ByteArrayInputStream]
> - FastByteArrayOutputStream [ByteArrayOutputStream]
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-37) Remove JDK-derived code from
project
Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12698878#action_12698878 ]
Eric Evans commented on CASSANDRA-37:
-------------------------------------
The only nit I have is that in SSTable, dataFile_ has been made implicitly public in order to make it accessible from SSTableTest. Perhaps it would be better to keep it private and use a getter instead?
Other than that, +1
> Remove JDK-derived code from project
> ------------------------------------
>
> Key: CASSANDRA-37
> URL: https://issues.apache.org/jira/browse/CASSANDRA-37
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Critical
> Fix For: 0.3
>
> Attachments: 0001-add-SSTable-tests.-in-particular-we-want-to-be-sure.patch, 0002-r-m-copied-JDK-code.patch, 37.tgz
>
>
> Some classes appear to have been copied from the JDK source and altered to improve them for use in Cassandra. Unfortunately neither the classic JDK nor the OpenJDK license is compatible with the Apache license that Cassandra is operating under. See https://issues.apache.org/jira/browse/LEGAL-46
> Modified JDK classes include:
> - BitSet [JDK: BitSet]
> - FastByteArrayInputStream [ByteArrayInputStream]
> - FastByteArrayOutputStream [ByteArrayOutputStream]
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-37) Remove JDK-derived code from project
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-37?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-37:
------------------------------------
Attachment: 0002-r-m-copied-JDK-code.patch
> Remove JDK-derived code from project
> ------------------------------------
>
> Key: CASSANDRA-37
> URL: https://issues.apache.org/jira/browse/CASSANDRA-37
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Critical
> Fix For: 0.3
>
> Attachments: 0001-add-SSTable-tests.-in-particular-we-want-to-be-sure.patch, 0002-r-m-copied-JDK-code.patch
>
>
> Some classes appear to have been copied from the JDK source and altered to improve them for use in Cassandra. Unfortunately neither the classic JDK nor the OpenJDK license is compatible with the Apache license that Cassandra is operating under. See https://issues.apache.org/jira/browse/LEGAL-46
> Modified JDK classes include:
> - BitSet [JDK: BitSet]
> - FastByteArrayInputStream [ByteArrayInputStream]
> - FastByteArrayOutputStream [ByteArrayOutputStream]
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-37) Remove JDK-derived code from
project
Posted by "Ian Holsman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12706290#action_12706290 ]
Ian Holsman commented on CASSANDRA-37:
--------------------------------------
Hey JB.
lucene/solr have a 'OpenBitSet' class in their code. would this be suitable as a replacement for BitSet ?
http://lucene.apache.org/java/2_4_0/api/org/apache/lucene/util/OpenBitSet.html
> Remove JDK-derived code from project
> ------------------------------------
>
> Key: CASSANDRA-37
> URL: https://issues.apache.org/jira/browse/CASSANDRA-37
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Critical
> Fix For: 0.3
>
> Attachments: 0001-add-SSTable-tests.-in-particular-we-want-to-be-sure.patch, 0002-r-m-copied-JDK-code.patch, 37.tgz
>
>
> Some classes appear to have been copied from the JDK source and altered to improve them for use in Cassandra. Unfortunately neither the classic JDK nor the OpenJDK license is compatible with the Apache license that Cassandra is operating under. See https://issues.apache.org/jira/browse/LEGAL-46
> Modified JDK classes include:
> - BitSet [JDK: BitSet]
> - FastByteArrayInputStream [ByteArrayInputStream]
> - FastByteArrayOutputStream [ByteArrayOutputStream]
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-37) Remove JDK-derived code from project
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-37?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-37:
------------------------------------
Attachment: 0001-add-SSTable-tests.-in-particular-we-want-to-be-sure.patch
> Remove JDK-derived code from project
> ------------------------------------
>
> Key: CASSANDRA-37
> URL: https://issues.apache.org/jira/browse/CASSANDRA-37
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Critical
> Fix For: 0.3
>
> Attachments: 0001-add-SSTable-tests.-in-particular-we-want-to-be-sure.patch, 0002-r-m-copied-JDK-code.patch
>
>
> Some classes appear to have been copied from the JDK source and altered to improve them for use in Cassandra. Unfortunately neither the classic JDK nor the OpenJDK license is compatible with the Apache license that Cassandra is operating under. See https://issues.apache.org/jira/browse/LEGAL-46
> Modified JDK classes include:
> - BitSet [JDK: BitSet]
> - FastByteArrayInputStream [ByteArrayInputStream]
> - FastByteArrayOutputStream [ByteArrayOutputStream]
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-37) Remove JDK-derived code from
project
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12698881#action_12698881 ]
Jonathan Ellis commented on CASSANDRA-37:
-----------------------------------------
thanks for the feedback.
it's package-local, which means classes in the same package (like its associated test) can access it. to java that is quite different than public. :)
my understanding (and I could be wrong) is that this is a reasonably idiomatic use of package local.
> Remove JDK-derived code from project
> ------------------------------------
>
> Key: CASSANDRA-37
> URL: https://issues.apache.org/jira/browse/CASSANDRA-37
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Critical
> Fix For: 0.3
>
> Attachments: 0001-add-SSTable-tests.-in-particular-we-want-to-be-sure.patch, 0002-r-m-copied-JDK-code.patch, 37.tgz
>
>
> Some classes appear to have been copied from the JDK source and altered to improve them for use in Cassandra. Unfortunately neither the classic JDK nor the OpenJDK license is compatible with the Apache license that Cassandra is operating under. See https://issues.apache.org/jira/browse/LEGAL-46
> Modified JDK classes include:
> - BitSet [JDK: BitSet]
> - FastByteArrayInputStream [ByteArrayInputStream]
> - FastByteArrayOutputStream [ByteArrayOutputStream]
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-37) Remove JDK-derived code from
project
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12699368#action_12699368 ]
Todd Lipcon commented on CASSANDRA-37:
--------------------------------------
Agreed that package-local is idiomatic for accessing semi-private stuff from within unit tests
> Remove JDK-derived code from project
> ------------------------------------
>
> Key: CASSANDRA-37
> URL: https://issues.apache.org/jira/browse/CASSANDRA-37
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Critical
> Fix For: 0.3
>
> Attachments: 0001-add-SSTable-tests.-in-particular-we-want-to-be-sure.patch, 0002-r-m-copied-JDK-code.patch, 37.tgz
>
>
> Some classes appear to have been copied from the JDK source and altered to improve them for use in Cassandra. Unfortunately neither the classic JDK nor the OpenJDK license is compatible with the Apache license that Cassandra is operating under. See https://issues.apache.org/jira/browse/LEGAL-46
> Modified JDK classes include:
> - BitSet [JDK: BitSet]
> - FastByteArrayInputStream [ByteArrayInputStream]
> - FastByteArrayOutputStream [ByteArrayOutputStream]
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CASSANDRA-37) Remove JDK-derived code from
project
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-37?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis reassigned CASSANDRA-37:
---------------------------------------
Assignee: Jonathan Ellis
> Remove JDK-derived code from project
> ------------------------------------
>
> Key: CASSANDRA-37
> URL: https://issues.apache.org/jira/browse/CASSANDRA-37
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Critical
>
> Some classes appear to have been copied from the JDK source and altered to improve them for use in Cassandra. Unfortunately neither the classic JDK nor the OpenJDK license is compatible with the Apache license that Cassandra is operating under. See https://issues.apache.org/jira/browse/LEGAL-46
> Modified JDK classes include:
> - BitSet [JDK: BitSet]
> - DataInputBuffer [ByteArrayInputStream]
> - DataOutputBuffer [ByteArrayOutputStream]
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-37) Remove JDK-derived code from
project
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12703640#action_12703640 ]
Hudson commented on CASSANDRA-37:
---------------------------------
Integrated in Cassandra #51 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/51/])
r/m copied JDK code
patch by jbellis; reviewed by Eric Evans for
add SSTable tests. in particular we want to be sure to test bloomfilter
[de]serialize since that's going to change a lot.
patch by jbellis; reviewed by Eric Evans for
> Remove JDK-derived code from project
> ------------------------------------
>
> Key: CASSANDRA-37
> URL: https://issues.apache.org/jira/browse/CASSANDRA-37
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Critical
> Fix For: 0.3
>
> Attachments: 0001-add-SSTable-tests.-in-particular-we-want-to-be-sure.patch, 0002-r-m-copied-JDK-code.patch, 37.tgz
>
>
> Some classes appear to have been copied from the JDK source and altered to improve them for use in Cassandra. Unfortunately neither the classic JDK nor the OpenJDK license is compatible with the Apache license that Cassandra is operating under. See https://issues.apache.org/jira/browse/LEGAL-46
> Modified JDK classes include:
> - BitSet [JDK: BitSet]
> - FastByteArrayInputStream [ByteArrayInputStream]
> - FastByteArrayOutputStream [ByteArrayOutputStream]
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-37) Remove JDK-derived code from project
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-37?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-37:
------------------------------------
Fix Version/s: 0.3
> Remove JDK-derived code from project
> ------------------------------------
>
> Key: CASSANDRA-37
> URL: https://issues.apache.org/jira/browse/CASSANDRA-37
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Critical
> Fix For: 0.3
>
>
> Some classes appear to have been copied from the JDK source and altered to improve them for use in Cassandra. Unfortunately neither the classic JDK nor the OpenJDK license is compatible with the Apache license that Cassandra is operating under. See https://issues.apache.org/jira/browse/LEGAL-46
> Modified JDK classes include:
> - BitSet [JDK: BitSet]
> - DataInputBuffer [ByteArrayInputStream]
> - DataOutputBuffer [ByteArrayOutputStream]
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-37) Remove JDK-derived code from project
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-37?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-37:
------------------------------------
Description:
Some classes appear to have been copied from the JDK source and altered to improve them for use in Cassandra. Unfortunately neither the classic JDK nor the OpenJDK license is compatible with the Apache license that Cassandra is operating under. See https://issues.apache.org/jira/browse/LEGAL-46
Modified JDK classes include:
- BitSet [JDK: BitSet]
- FastByteArrayInputStream [ByteArrayInputStream]
- FastByteArrayOutputStream [ByteArrayOutputStream]
was:
Some classes appear to have been copied from the JDK source and altered to improve them for use in Cassandra. Unfortunately neither the classic JDK nor the OpenJDK license is compatible with the Apache license that Cassandra is operating under. See https://issues.apache.org/jira/browse/LEGAL-46
Modified JDK classes include:
- BitSet [JDK: BitSet]
- DataInputBuffer [ByteArrayInputStream]
- DataOutputBuffer [ByteArrayOutputStream]
> Remove JDK-derived code from project
> ------------------------------------
>
> Key: CASSANDRA-37
> URL: https://issues.apache.org/jira/browse/CASSANDRA-37
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Critical
> Fix For: 0.3
>
>
> Some classes appear to have been copied from the JDK source and altered to improve them for use in Cassandra. Unfortunately neither the classic JDK nor the OpenJDK license is compatible with the Apache license that Cassandra is operating under. See https://issues.apache.org/jira/browse/LEGAL-46
> Modified JDK classes include:
> - BitSet [JDK: BitSet]
> - FastByteArrayInputStream [ByteArrayInputStream]
> - FastByteArrayOutputStream [ByteArrayOutputStream]
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.